Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0
    • Component/s: build
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          I reproduced locally.

          Step 15 : RUN cd /usr/share/maven/lib && ln -s ../../java/commons-lang.jar .
           ---> Running in 2c7c00f7c356
          ln: failed to create symbolic link './commons-lang.jar': File exists
          The command '/bin/sh -c cd /usr/share/maven/lib && ln -s ../../java/commons-lang.jar .' returned a non-zero code: 1
          

          There are two occurrences of the following code.

          dev-support/docker/Dockerfile
          # Fixing the Apache commons / Maven dependency problem under Ubuntu:
          # See http://wiki.apache.org/commons/VfsProblems
          RUN cd /usr/share/maven/lib && ln -s ../../java/commons-lang.jar .
          

          We should remove either one of the two.

          Show
          ajisakaa Akira Ajisaka added a comment - I reproduced locally. Step 15 : RUN cd /usr/share/maven/lib && ln -s ../../java/commons-lang.jar . ---> Running in 2c7c00f7c356 ln: failed to create symbolic link './commons-lang.jar': File exists The command '/bin/sh -c cd /usr/share/maven/lib && ln -s ../../java/commons-lang.jar .' returned a non-zero code: 1 There are two occurrences of the following code. dev-support/docker/Dockerfile # Fixing the Apache commons / Maven dependency problem under Ubuntu: # See http: //wiki.apache.org/commons/VfsProblems RUN cd /usr/share/maven/lib && ln -s ../../java/commons-lang.jar . We should remove either one of the two.
          Hide
          sekikn Kengo Seki added a comment -

          Attaching a patch. After applying this, test-patch works in docker mode on branch-2, as follows:

          [sekikn@localhost hadoop]$ /home/sekikn/yetus/precommit/smart-apply-patch.sh --plugins=all ~/HADOOP-12681.branch-2.00.patch 
          Processing: /home/sekikn/HADOOP-12681.branch-2.00.patch
          Patch file /home/sekikn/HADOOP-12681.branch-2.00.patch copied to /tmp/yetus-5197.32233
          Applying the patch:
          Sun Dec 27 23:41:33 JST 2015
          cd /home/sekikn/dev/hadoop
          git apply --binary -v --stat --apply -p0 /tmp/yetus-5197.32233/patch
          Applied patch dev-support/docker/Dockerfile cleanly.
           dev-support/docker/Dockerfile |    4 ----
           1 file changed, 4 deletions(-)
          [sekikn@localhost hadoop]$ /home/sekikn/yetus/precommit/test-patch.sh --dirty-workspace --docker --project=hadoop MAPREDUCE-6584
          /tmp/yetus-4717.16695 has been created
          Running in developer mode
          Processing: MAPREDUCE-6584
          MAPREDUCE-6584 patch is being downloaded at Sun Dec 27 23:46:06 JST 2015 from
          https://issues.apache.org/jira/secure/attachment/12779516/MAPREDUCE-6584-branch-2.01.patch
          
          (snip)
          
          -1 overall
          
           _____     _ _                _ 
          |  ___|_ _(_) |_   _ _ __ ___| |
          | |_ / _` | | | | | | '__/ _ \ |
          |  _| (_| | | | |_| | | |  __/_|
          |_|  \__,_|_|_|\__,_|_|  \___(_)
                                          
          
          
          | Vote |      Subsystem |  Runtime   | Comment
          ============================================================================
          |   0  |        reexec  |  0m 0s     | Docker mode activated. 
          |  +1  |       @author  |  0m 0s     | The patch does not contain any @author 
          |      |                |            | tags.
          |  -1  |    test4tests  |  0m 0s     | The patch doesn't appear to include any 
          |      |                |            | new or modified tests. Please justify why
          |      |                |            | no new tests are needed for this patch.
          |      |                |            | Also please list what manual steps were
          |      |                |            | performed to verify this patch.
          |  +1  |    mvninstall  |  6m 10s    | branch-2 passed 
          |  +1  |       compile  |  0m 21s    | branch-2 passed 
          |  +1  |       mvnsite  |  0m 27s    | branch-2 passed 
          |  +1  |    mvneclipse  |  0m 12s    | branch-2 passed 
          |  +1  |       javadoc  |  0m 21s    | branch-2 passed 
          |  +1  |    mvninstall  |  0m 24s    | the patch passed 
          |  +1  |       compile  |  0m 21s    | the patch passed 
          |  +1  |         javac  |  0m 21s    | the patch passed 
          |  +1  |       mvnsite  |  0m 28s    | the patch passed 
          |  +1  |    mvneclipse  |  0m 11s    | the patch passed 
          |  +1  |    whitespace  |  0m 0s     | Patch has no whitespace issues. 
          |  +1  |           xml  |  0m 0s     | The patch has no ill-formed XML file. 
          |  +1  |       javadoc  |  0m 21s    | the patch passed 
          |  +1  |    asflicense  |  0m 18s    | Patch does not generate ASF License 
          |      |                |            | warnings.
          |      |                |  10m 2s    | 
          
          
          || Subsystem || Report/Notes ||
          ============================================================================
          | Docker | Client=1.7.1 Server=1.7.1 Image:yetus/hadoop:577e74f |
          | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12779516/MAPREDUCE-6584-branch-2.01.patch |
          | JIRA Issue | MAPREDUCE-6584 |
          | Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  xml  |
          | uname | Linux 7ba42874cad1 2.6.32-573.8.1.el6.x86_64 #1 SMP Tue Nov 10 18:01:38 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux |
          | Build tool | maven |
          | Personality | /testptch/patchprocess/precommit/personality/provided.sh |
          | git revision | branch-2 / 42160d3 |
          | Default Java | 1.7.0_80 |
          | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core |
          | Max memory used | 75MB |
          | Powered by | Apache Yetus 0.2.0-SNAPSHOT   http://yetus.apache.org |
          
          Show
          sekikn Kengo Seki added a comment - Attaching a patch. After applying this, test-patch works in docker mode on branch-2, as follows: [sekikn@localhost hadoop]$ /home/sekikn/yetus/precommit/smart-apply-patch.sh --plugins=all ~/HADOOP-12681.branch-2.00.patch Processing: /home/sekikn/HADOOP-12681.branch-2.00.patch Patch file /home/sekikn/HADOOP-12681.branch-2.00.patch copied to /tmp/yetus-5197.32233 Applying the patch: Sun Dec 27 23:41:33 JST 2015 cd /home/sekikn/dev/hadoop git apply --binary -v --stat --apply -p0 /tmp/yetus-5197.32233/patch Applied patch dev-support/docker/Dockerfile cleanly. dev-support/docker/Dockerfile | 4 ---- 1 file changed, 4 deletions(-) [sekikn@localhost hadoop]$ /home/sekikn/yetus/precommit/test-patch.sh --dirty-workspace --docker --project=hadoop MAPREDUCE-6584 /tmp/yetus-4717.16695 has been created Running in developer mode Processing: MAPREDUCE-6584 MAPREDUCE-6584 patch is being downloaded at Sun Dec 27 23:46:06 JST 2015 from https: //issues.apache.org/jira/secure/attachment/12779516/MAPREDUCE-6584-branch-2.01.patch (snip) -1 overall _____ _ _ _ | ___|_ _(_) |_ _ _ __ ___| | | |_ / _` | | | | | | '__/ _ \ | | _| (_| | | | |_| | | | __/_| |_| \__,_|_|_|\__,_|_| \___(_) | Vote | Subsystem | Runtime | Comment ============================================================================ | 0 | reexec | 0m 0s | Docker mode activated. | +1 | @author | 0m 0s | The patch does not contain any @author | | | | tags. | -1 | test4tests | 0m 0s | The patch doesn't appear to include any | | | | new or modified tests. Please justify why | | | | no new tests are needed for this patch. | | | | Also please list what manual steps were | | | | performed to verify this patch. | +1 | mvninstall | 6m 10s | branch-2 passed | +1 | compile | 0m 21s | branch-2 passed | +1 | mvnsite | 0m 27s | branch-2 passed | +1 | mvneclipse | 0m 12s | branch-2 passed | +1 | javadoc | 0m 21s | branch-2 passed | +1 | mvninstall | 0m 24s | the patch passed | +1 | compile | 0m 21s | the patch passed | +1 | javac | 0m 21s | the patch passed | +1 | mvnsite | 0m 28s | the patch passed | +1 | mvneclipse | 0m 11s | the patch passed | +1 | whitespace | 0m 0s | Patch has no whitespace issues. | +1 | xml | 0m 0s | The patch has no ill-formed XML file. | +1 | javadoc | 0m 21s | the patch passed | +1 | asflicense | 0m 18s | Patch does not generate ASF License | | | | warnings. | | | 10m 2s | || Subsystem || Report/Notes || ============================================================================ | Docker | Client=1.7.1 Server=1.7.1 Image:yetus/hadoop:577e74f | | JIRA Patch URL | https: //issues.apache.org/jira/secure/attachment/12779516/MAPREDUCE-6584-branch-2.01.patch | | JIRA Issue | MAPREDUCE-6584 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml | | uname | Linux 7ba42874cad1 2.6.32-573.8.1.el6.x86_64 #1 SMP Tue Nov 10 18:01:38 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-2 / 42160d3 | | Default Java | 1.7.0_80 | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core | | Max memory used | 75MB | | Powered by | Apache Yetus 0.2.0-SNAPSHOT http: //yetus.apache.org |
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to the testing environment has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/8313/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/8313/console in case of problems.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 shellcheck 0m 7s There were no new shellcheck issues.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 asflicense 0m 41s Patch does not generate ASF License warnings.
          1m 13s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5d9212c
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779582/HADOOP-12681.branch-2.00.patch
          JIRA Issue HADOOP-12681
          Optional Tests asflicense shellcheck
          uname Linux 7b828dc42900 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 42160d3
          shellcheck v0.4.1
          modules C: U:
          Max memory used 29MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8313/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 shellcheck 0m 7s There were no new shellcheck issues. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 41s Patch does not generate ASF License warnings. 1m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:5d9212c JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779582/HADOOP-12681.branch-2.00.patch JIRA Issue HADOOP-12681 Optional Tests asflicense shellcheck uname Linux 7b828dc42900 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 42160d3 shellcheck v0.4.1 modules C: U: Max memory used 29MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8313/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2 and branch-2.8. Thanks Kengo Seki for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2 and branch-2.8. Thanks Kengo Seki for the contribution!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9027 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9027/)
          Add HADOOP-12681 to 2.8.0 in CHANGES.txt. (aajisaka: rev a0249da8a775dac246b329e3668fe85fe8213b2b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9027 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9027/ ) Add HADOOP-12681 to 2.8.0 in CHANGES.txt. (aajisaka: rev a0249da8a775dac246b329e3668fe85fe8213b2b) hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              sekikn Kengo Seki
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development