Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12555

WASB to read credentials from a credential provider

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fs/azure
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      The hadoop-azure file system now supports configuration of the Azure Storage account credentials using the standard Hadoop Credential Provider API. For details, please refer to the documentation on hadoop-azure and the Credential Provider API.

      Description

      As HADOOP-12548 is going to do for s3, WASB should be able to read a password from a credential provider.

      1. HADOOP-12555-001.patch
        7 kB
        Larry McCay
      2. HADOOP-12555-002.patch
        8 kB
        Larry McCay
      3. HADOOP-12555-003.patch
        7 kB
        Larry McCay
      4. HADOOP-12555-004.patch
        10 kB
        Larry McCay
      5. HADOOP-12555-005.patch
        10 kB
        Larry McCay

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -

          HADOOP-12548 contains the original discussion on this and more details about the implementation.

          Show
          cnauroth Chris Nauroth added a comment - HADOOP-12548 contains the original discussion on this and more details about the implementation.
          Hide
          lmccay Larry McCay added a comment -

          Hi Chris Nauroth - I am looking at this briefly today and have come to the conclusion that all we really need to do is change SimpleKeyProvider to use the Configuration.getPassword method instead of the Configuration.get method to resolve the accountKey.

          This will provide backward compatibility for existing config stored keys but also allow for the same property name to be used to get the key from a credential provider.

          Thoughts?

          Show
          lmccay Larry McCay added a comment - Hi Chris Nauroth - I am looking at this briefly today and have come to the conclusion that all we really need to do is change SimpleKeyProvider to use the Configuration.getPassword method instead of the Configuration.get method to resolve the accountKey. This will provide backward compatibility for existing config stored keys but also allow for the same property name to be used to get the key from a credential provider. Thoughts?
          Hide
          cnauroth Chris Nauroth added a comment -

          Larry McCay, I think you're right. Thanks for digging into it.

          My only other suggestion would be that we update the site documentation to mention that this is integrated with the credential provider functionality. It might be better to defer this though to a separate JIRA focused solely on comprehensive credential provider docs. (There were a lot of documentation ideas discussed back on HADOOP-12548.)

          Show
          cnauroth Chris Nauroth added a comment - Larry McCay , I think you're right. Thanks for digging into it. My only other suggestion would be that we update the site documentation to mention that this is integrated with the credential provider functionality. It might be better to defer this though to a separate JIRA focused solely on comprehensive credential provider docs. (There were a lot of documentation ideas discussed back on HADOOP-12548 .)
          Hide
          lmccay Larry McCay added a comment -

          Agreed.
          I've started those docs already.
          Let's take that discussion over to this HADOOP-11031 which we will repurpose for these docs.

          Show
          lmccay Larry McCay added a comment - Agreed. I've started those docs already. Let's take that discussion over to this HADOOP-11031 which we will repurpose for these docs.
          Hide
          cnauroth Chris Nauroth added a comment -

          Let's take that discussion over to this HADOOP-11031 which we will repurpose for these docs.

          +1, thanks!

          Show
          cnauroth Chris Nauroth added a comment - Let's take that discussion over to this HADOOP-11031 which we will repurpose for these docs. +1, thanks!
          Hide
          lmccay Larry McCay added a comment -

          Initial patch with getPassword uptake, docs and test

          Show
          lmccay Larry McCay added a comment - Initial patch with getPassword uptake, docs and test
          Hide
          lmccay Larry McCay added a comment -

          Precommit tests don't seem to be getting kicked off but I found a couple checkstyle things in the test class. v002 addresses them.

          Show
          lmccay Larry McCay added a comment - Precommit tests don't seem to be getting kicked off but I found a couple checkstyle things in the test class. v002 addresses them.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 21s trunk passed
          +1 compile 0m 17s trunk passed with JDK v1.8.0_72
          +1 compile 0m 20s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 24s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 35s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95
          -1 mvninstall 0m 15s hadoop-azure in the patch failed.
          -1 compile 0m 13s hadoop-azure in the patch failed with JDK v1.8.0_72.
          -1 javac 0m 13s hadoop-azure in the patch failed with JDK v1.8.0_72.
          -1 compile 0m 14s hadoop-azure in the patch failed with JDK v1.7.0_95.
          -1 javac 0m 14s hadoop-azure in the patch failed with JDK v1.7.0_95.
          +1 checkstyle 0m 12s the patch passed
          -1 mvnsite 0m 16s hadoop-azure in the patch failed.
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 11s hadoop-azure in the patch failed.
          +1 javadoc 0m 11s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95
          -1 unit 0m 13s hadoop-azure in the patch failed with JDK v1.8.0_72.
          -1 unit 0m 15s hadoop-azure in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          14m 37s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788848/HADOOP-12555-002.patch
          JIRA Issue HADOOP-12555
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0937c618e470 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d5abd29
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_72.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_72.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_95.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_95.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-mvnsite-hadoop-tools_hadoop-azure.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/testReport/
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 21s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_72 +1 compile 0m 20s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95 -1 mvninstall 0m 15s hadoop-azure in the patch failed. -1 compile 0m 13s hadoop-azure in the patch failed with JDK v1.8.0_72. -1 javac 0m 13s hadoop-azure in the patch failed with JDK v1.8.0_72. -1 compile 0m 14s hadoop-azure in the patch failed with JDK v1.7.0_95. -1 javac 0m 14s hadoop-azure in the patch failed with JDK v1.7.0_95. +1 checkstyle 0m 12s the patch passed -1 mvnsite 0m 16s hadoop-azure in the patch failed. +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 11s hadoop-azure in the patch failed. +1 javadoc 0m 11s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95 -1 unit 0m 13s hadoop-azure in the patch failed with JDK v1.8.0_72. -1 unit 0m 15s hadoop-azure in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 14m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788848/HADOOP-12555-002.patch JIRA Issue HADOOP-12555 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0937c618e470 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d5abd29 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_72.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_72.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-mvnsite-hadoop-tools_hadoop-azure.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8675/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          lmccay Larry McCay added a comment -

          Eclipse removed a bunch of imports for some reason. Fixed. Need to find whatever setting is doing that. :/

          Show
          lmccay Larry McCay added a comment - Eclipse removed a bunch of imports for some reason. Fixed. Need to find whatever setting is doing that. :/
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 38s trunk passed
          +1 compile 0m 16s trunk passed with JDK v1.8.0_72
          +1 compile 0m 17s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 0m 33s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 14s the patch passed with JDK v1.8.0_72
          +1 javac 0m 14s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.7.0_95
          +1 javac 0m 15s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 20s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 43s the patch passed
          +1 javadoc 0m 11s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95
          +1 unit 1m 12s hadoop-azure in the patch passed with JDK v1.8.0_72.
          +1 unit 1m 26s hadoop-azure in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          16m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788926/HADOOP-12555-003.patch
          JIRA Issue HADOOP-12555
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 45a959eaafb7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d5abd29
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8676/testReport/
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8676/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 38s trunk passed +1 compile 0m 16s trunk passed with JDK v1.8.0_72 +1 compile 0m 17s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 18s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_72 +1 javac 0m 14s the patch passed +1 compile 0m 15s the patch passed with JDK v1.7.0_95 +1 javac 0m 15s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 43s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95 +1 unit 1m 12s hadoop-azure in the patch passed with JDK v1.8.0_72. +1 unit 1m 26s hadoop-azure in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 16m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788926/HADOOP-12555-003.patch JIRA Issue HADOOP-12555 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 45a959eaafb7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d5abd29 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8676/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8676/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          lmccay Larry McCay added a comment -

          Chris Nauroth - precommit has passed - can you take a look when you have a few cycles?

          Show
          lmccay Larry McCay added a comment - Chris Nauroth - precommit has passed - can you take a look when you have a few cycles?
          Hide
          lmccay Larry McCay added a comment -

          Added logging of potential IOE from getPassword.

          Show
          lmccay Larry McCay added a comment - Added logging of potential IOE from getPassword.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 32s trunk passed
          +1 compile 5m 58s trunk passed with JDK v1.8.0_72
          +1 compile 6m 38s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 1s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 16s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 56s the patch passed
          +1 compile 5m 38s the patch passed with JDK v1.8.0_72
          +1 javac 5m 38s the patch passed
          +1 compile 6m 35s the patch passed with JDK v1.7.0_95
          +1 javac 6m 35s the patch passed
          +1 checkstyle 1m 2s the patch passed
          +1 mvnsite 1m 20s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 28s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95
          -1 unit 19m 31s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 3s hadoop-azure in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 26s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 17s hadoop-azure in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          78m 46s



          Reason Tests
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789006/HADOOP-12555-004.patch
          JIRA Issue HADOOP-12555
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle
          uname Linux e2469e6ebe56 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5e7d4d5
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8685/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8685/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8685/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8685/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 32s trunk passed +1 compile 5m 58s trunk passed with JDK v1.8.0_72 +1 compile 6m 38s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 4s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 16s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 5m 38s the patch passed with JDK v1.8.0_72 +1 javac 5m 38s the patch passed +1 compile 6m 35s the patch passed with JDK v1.7.0_95 +1 javac 6m 35s the patch passed +1 checkstyle 1m 2s the patch passed +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95 -1 unit 19m 31s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 1m 3s hadoop-azure in the patch passed with JDK v1.8.0_72. +1 unit 7m 26s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 17s hadoop-azure in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 78m 46s Reason Tests JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789006/HADOOP-12555-004.patch JIRA Issue HADOOP-12555 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle uname Linux e2469e6ebe56 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5e7d4d5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8685/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8685/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8685/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8685/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          lmccay Larry McCay added a comment -

          I don't think the failure is related to this patch in any way.

          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project hadoop-common: There was a timeout or other error in the fork -> [Help 1]

          I'll try and resubmit the patch and see what happens.

          Show
          lmccay Larry McCay added a comment - I don't think the failure is related to this patch in any way. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project hadoop-common: There was a timeout or other error in the fork -> [Help 1] I'll try and resubmit the patch and see what happens.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hi Larry McCay. This looks great. I'd just like to request a couple of minor changes:

          1. Please change SimpleKeyProvider#LOG from public to private.
          2. Please correct the typo in "credentials" in index.md:
            In addition to using the credential provider framework to protect your credenitals, it's
            
          Show
          cnauroth Chris Nauroth added a comment - Hi Larry McCay . This looks great. I'd just like to request a couple of minor changes: Please change SimpleKeyProvider#LOG from public to private . Please correct the typo in "credentials" in index.md: In addition to using the credential provider framework to protect your credenitals, it's
          Hide
          lmccay Larry McCay added a comment -

          Will do!

          Credenitals.

          Good catch.

          Show
          lmccay Larry McCay added a comment - Will do! Credenitals. Good catch.
          Hide
          lmccay Larry McCay added a comment -

          v005 addresses review comments.

          Show
          lmccay Larry McCay added a comment - v005 addresses review comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 26s trunk passed
          +1 compile 5m 44s trunk passed with JDK v1.8.0_72
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 22s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 1s trunk passed
          +1 javadoc 1m 3s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 18s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 57s the patch passed
          +1 compile 5m 40s the patch passed with JDK v1.8.0_72
          +1 javac 5m 40s the patch passed
          +1 compile 6m 38s the patch passed with JDK v1.7.0_95
          +1 javac 6m 38s the patch passed
          +1 checkstyle 1m 2s the patch passed
          +1 mvnsite 1m 21s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 27s the patch passed
          +1 javadoc 1m 5s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 17s the patch passed with JDK v1.7.0_95
          +1 unit 7m 16s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 1m 5s hadoop-azure in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 35s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 20s hadoop-azure in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          66m 44s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789076/HADOOP-12555-005.patch
          JIRA Issue HADOOP-12555
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle
          uname Linux ad0641824e45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 66289a3
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8690/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8690/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 26s trunk passed +1 compile 5m 44s trunk passed with JDK v1.8.0_72 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 22s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 1m 3s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 18s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 57s the patch passed +1 compile 5m 40s the patch passed with JDK v1.8.0_72 +1 javac 5m 40s the patch passed +1 compile 6m 38s the patch passed with JDK v1.7.0_95 +1 javac 6m 38s the patch passed +1 checkstyle 1m 2s the patch passed +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 17s the patch passed with JDK v1.7.0_95 +1 unit 7m 16s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 1m 5s hadoop-azure in the patch passed with JDK v1.8.0_72. +1 unit 7m 35s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 20s hadoop-azure in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 66m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789076/HADOOP-12555-005.patch JIRA Issue HADOOP-12555 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle uname Linux ad0641824e45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 66289a3 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8690/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8690/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for patch v005. I have committed this to trunk, branch-2 and branch-2.8. Larry McCay, thank you for contributing this patch.

          Show
          cnauroth Chris Nauroth added a comment - +1 for patch v005. I have committed this to trunk, branch-2 and branch-2.8. Larry McCay , thank you for contributing this patch.
          Hide
          lmccay Larry McCay added a comment -

          Thanks, Chris Nauroth!

          Show
          lmccay Larry McCay added a comment - Thanks, Chris Nauroth !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9344 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9344/)
          HADOOP-12555. WASB to read credentials from a credential provider. (cnauroth: rev 27b77751c1163ab4a1ce081a426e5190d1b8aff4)

          • hadoop-common-project/hadoop-common/src/site/markdown/CredentialProviderAPI.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbUriAndConfiguration.java
          • hadoop-tools/hadoop-azure/src/site/markdown/index.md
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/SimpleKeyProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9344 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9344/ ) HADOOP-12555 . WASB to read credentials from a credential provider. (cnauroth: rev 27b77751c1163ab4a1ce081a426e5190d1b8aff4) hadoop-common-project/hadoop-common/src/site/markdown/CredentialProviderAPI.md hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbUriAndConfiguration.java hadoop-tools/hadoop-azure/src/site/markdown/index.md hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/SimpleKeyProvider.java

            People

            • Assignee:
              lmccay Larry McCay
              Reporter:
              cnauroth Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development