Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12846

Credential Provider Recursive Dependencies

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are a few credential provider integration points in which the use of a certain type of provider in a certain filesystem causes a recursive infinite loop.

      For instance, a component such as sqoop can be protecting a db password in a credential provider within the wasb/azure filesystem. Now that HADOOP-12555 has introduced the ability to protect the access keys for wasb we suddenly need access to wasb to get the database keys which initiates the attempt to get the access keys from wasb - since there is a provider path configured for sqoop.

      For such integrations, those in which it doesn't make sense to protect the access keys inside the thing that we need the keys to access, we need a solution to avoid this recursion - other than dictating what filesystems can be used by other components.

      This patch proposes the ability to scrub the configured provider path of any provider types that would be incompatible with the integration point. In other words, before calling Configuration.getPassword for the access keys to wasb, we can remove any configured providers that require access to wasb.

      This will require some regex expressions that can be used to identify the configuration of such provider uri's within the provider path parameter.

      1. HADOOP-12846-001.patch
        8 kB
        Larry McCay
      2. HADOOP-12846-002.patch
        8 kB
        Larry McCay
      3. HADOOP-12846-003.patch
        8 kB
        Larry McCay
      4. HADOOP-12846-004.patch
        8 kB
        Larry McCay

        Issue Links

          Activity

          Hide
          lmccay Larry McCay added a comment -

          Given a configuration (command line) such as -D hadoop.security.credential.provider.path=jceks://wasb/user/hrt_qa/sqoopdbpasswd.jceks this would result in a infinite loop. With a call to ProviderUtils.excludeCredentialProviderTypes(",?jceks://wasb.*,?") this would result in a new configuration object that had no providers in it and therefore no incompatibility at the integration point that looks up access keys. It would therefore avoid the infinite loop.

          I will have a patch available at some point later today or this evening.

          Show
          lmccay Larry McCay added a comment - Given a configuration (command line) such as -D hadoop.security.credential.provider.path=jceks://wasb/user/hrt_qa/sqoopdbpasswd.jceks this would result in a infinite loop. With a call to ProviderUtils.excludeCredentialProviderTypes(",?jceks://wasb.*,?") this would result in a new configuration object that had no providers in it and therefore no incompatibility at the integration point that looks up access keys. It would therefore avoid the infinite loop. I will have a patch available at some point later today or this evening.
          Hide
          cnauroth Chris Nauroth added a comment -

          Larry McCay, thank you for picking this up.

          This will require some regex expressions that can be used to identify the configuration of such provider uri's within the provider path parameter.

          Unfortunately, I don't think regex matching alone would solve the problem completely. The challenge is that our configuration magic allows different deployments to use different scheme names in file system URIs to refer to the same FileSystem implementation.

          In the example you gave, the "wasb" scheme maps to org.apache.hadoop.fs.azure.NativeAzureFileSystem. This is the default scheme as defined within the code of NativeAzureFileSystem. However, it's also possible that someone has used custom configuration to map a different scheme name to the same class. For example:

          <property>
            <name>fs.customfs.impl</name>
            <value>org.apache.hadoop.fs.azure.NativeAzureFileSystem</value>
          </property>
          

          With that configuration in place, a credential provider URI with "jceks://customfs/..." would hit the same problem, but a regex match against "wasb" wouldn't exclude it.

          I think a complete solution would somehow have to figure out the real mapping of scheme to file system class from configuration, and then do the exclusion based on class instead of scheme. The method FileSystem#getFileSystemClass(String, Configuration) might be helpful here.

          Show
          cnauroth Chris Nauroth added a comment - Larry McCay , thank you for picking this up. This will require some regex expressions that can be used to identify the configuration of such provider uri's within the provider path parameter. Unfortunately, I don't think regex matching alone would solve the problem completely. The challenge is that our configuration magic allows different deployments to use different scheme names in file system URIs to refer to the same FileSystem implementation. In the example you gave, the "wasb" scheme maps to org.apache.hadoop.fs.azure.NativeAzureFileSystem . This is the default scheme as defined within the code of NativeAzureFileSystem . However, it's also possible that someone has used custom configuration to map a different scheme name to the same class. For example: <property> <name>fs.customfs.impl</name> <value>org.apache.hadoop.fs.azure.NativeAzureFileSystem</value> </property> With that configuration in place, a credential provider URI with "jceks://customfs/..." would hit the same problem, but a regex match against "wasb" wouldn't exclude it. I think a complete solution would somehow have to figure out the real mapping of scheme to file system class from configuration, and then do the exclusion based on class instead of scheme. The method FileSystem#getFileSystemClass(String, Configuration) might be helpful here.
          Hide
          lmccay Larry McCay added a comment -

          Chris Nauroth - if someone does map a custom scheme name - does the default one not work at all?
          I wondering whether we could - at least in the near term - just say that provider URIs need to use the default scheme names.

          Show
          lmccay Larry McCay added a comment - Chris Nauroth - if someone does map a custom scheme name - does the default one not work at all? I wondering whether we could - at least in the near term - just say that provider URIs need to use the default scheme names.
          Hide
          cnauroth Chris Nauroth added a comment -

          Larry McCay, the default scheme (the one returned by however the FileSystem chooses to override the getScheme method) continues to work even in the presence of additional custom mappings. Focusing on the default scheme names might be an acceptable compromise near-term.

          However, I'm wondering if we might be able to cover everything right now without too much difficulty by using something like the following pseudo-code.

          credentialProviderPath = conf.get("hadoop.security.credential.provider.path")
          fsScheme = parseFileSystemScheme(credentialProviderPath)
          fsClass = FileSystem.getFileSystemClass(fsScheme, conf)
          if (NativeAzureFileSystem.class.isAssignableFrom(fsClass))
            exclude
          

          Let me know your thoughts on this. Thanks!

          Show
          cnauroth Chris Nauroth added a comment - Larry McCay , the default scheme (the one returned by however the FileSystem chooses to override the getScheme method) continues to work even in the presence of additional custom mappings. Focusing on the default scheme names might be an acceptable compromise near-term. However, I'm wondering if we might be able to cover everything right now without too much difficulty by using something like the following pseudo-code. credentialProviderPath = conf.get( "hadoop.security.credential.provider.path" ) fsScheme = parseFileSystemScheme(credentialProviderPath) fsClass = FileSystem.getFileSystemClass(fsScheme, conf) if (NativeAzureFileSystem.class.isAssignableFrom(fsClass)) exclude Let me know your thoughts on this. Thanks!
          Hide
          lmccay Larry McCay added a comment -

          Understood.

          I'll see what I can do.
          This will require a list of regex expressions rather than just one as well.
          It might be able to be done with one complicated expression that was dynamically built but not sure it is worth it.

          Show
          lmccay Larry McCay added a comment - Understood. I'll see what I can do. This will require a list of regex expressions rather than just one as well. It might be able to be done with one complicated expression that was dynamically built but not sure it is worth it.
          Hide
          lmccay Larry McCay added a comment -

          Actually that won't need any regex - even though I already wrote it!

          Show
          lmccay Larry McCay added a comment - Actually that won't need any regex - even though I already wrote it!
          Hide
          lmccay Larry McCay added a comment -

          Initial patch takes the approach suggested by Chris Nauroth. If the provider path does indeed need to be altered a clone of the original configuration object with the altered path. This is so that we don't make assumptions about who may have been given the same configuration object and change it out from under them.

          Show
          lmccay Larry McCay added a comment - Initial patch takes the approach suggested by Chris Nauroth . If the provider path does indeed need to be altered a clone of the original configuration object with the altered path. This is so that we don't make assumptions about who may have been given the same configuration object and change it out from under them.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 3m 9s Maven dependency ordering for branch
          +1 mvninstall 7m 12s trunk passed
          +1 compile 6m 30s trunk passed with JDK v1.8.0_72
          +1 compile 7m 13s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 1m 30s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 2m 8s trunk passed
          +1 javadoc 1m 11s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 21s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 0s the patch passed
          +1 compile 6m 28s the patch passed with JDK v1.8.0_72
          -1 javac 7m 44s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 1 new + 740 unchanged - 0 fixed = 741 total (was 740)
          +1 javac 6m 28s the patch passed
          +1 compile 7m 11s the patch passed with JDK v1.7.0_95
          -1 javac 14m 55s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 735 unchanged - 0 fixed = 736 total (was 735)
          +1 javac 7m 11s the patch passed
          +1 checkstyle 1m 6s root: patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
          +1 mvnsite 1m 26s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 36s the patch passed
          -1 javadoc 2m 12s hadoop-common-project_hadoop-common-jdk1.8.0_72 with JDK v1.8.0_72 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
          +1 javadoc 1m 8s the patch passed with JDK v1.8.0_72
          -1 javadoc 3m 54s hadoop-common-project_hadoop-common-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
          +1 javadoc 1m 21s the patch passed with JDK v1.7.0_95
          +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 1m 17s hadoop-azure in the patch passed with JDK v1.8.0_72.
          +1 unit 8m 23s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 33s hadoop-azure in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          76m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790318/HADOOP-12846-001.patch
          JIRA Issue HADOOP-12846
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux eeb6b2a204bd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 798babf
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          javadoc hadoop-common-project_hadoop-common-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          javadoc hadoop-common-project_hadoop-common-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 3m 9s Maven dependency ordering for branch +1 mvninstall 7m 12s trunk passed +1 compile 6m 30s trunk passed with JDK v1.8.0_72 +1 compile 7m 13s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 7s trunk passed +1 mvnsite 1m 30s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 8s trunk passed +1 javadoc 1m 11s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 21s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 0s the patch passed +1 compile 6m 28s the patch passed with JDK v1.8.0_72 -1 javac 7m 44s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 1 new + 740 unchanged - 0 fixed = 741 total (was 740) +1 javac 6m 28s the patch passed +1 compile 7m 11s the patch passed with JDK v1.7.0_95 -1 javac 14m 55s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 735 unchanged - 0 fixed = 736 total (was 735) +1 javac 7m 11s the patch passed +1 checkstyle 1m 6s root: patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3) +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 36s the patch passed -1 javadoc 2m 12s hadoop-common-project_hadoop-common-jdk1.8.0_72 with JDK v1.8.0_72 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) +1 javadoc 1m 8s the patch passed with JDK v1.8.0_72 -1 javadoc 3m 54s hadoop-common-project_hadoop-common-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) +1 javadoc 1m 21s the patch passed with JDK v1.7.0_95 +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 1m 17s hadoop-azure in the patch passed with JDK v1.8.0_72. +1 unit 8m 23s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 33s hadoop-azure in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 76m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790318/HADOOP-12846-001.patch JIRA Issue HADOOP-12846 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux eeb6b2a204bd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 798babf Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt javadoc hadoop-common-project_hadoop-common-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt javadoc hadoop-common-project_hadoop-common-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8734/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          lmccay Larry McCay added a comment -

          v002 addresses the warnings and javadoc error found in precommit. I've also done some more clean up and renamed the new method in ProviderUtils more appropriately.

          Show
          lmccay Larry McCay added a comment - v002 addresses the warnings and javadoc error found in precommit. I've also done some more clean up and renamed the new method in ProviderUtils more appropriately.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 0s trunk passed
          +1 compile 6m 31s trunk passed with JDK v1.8.0_72
          +1 compile 7m 9s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 1m 27s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 2m 10s trunk passed
          +1 javadoc 1m 12s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 22s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          -1 mvninstall 0m 15s hadoop-azure in the patch failed.
          -1 compile 6m 49s root in the patch failed with JDK v1.8.0_72.
          -1 javac 6m 49s root in the patch failed with JDK v1.8.0_72.
          -1 compile 7m 12s root in the patch failed with JDK v1.7.0_95.
          -1 javac 7m 12s root in the patch failed with JDK v1.7.0_95.
          +1 checkstyle 1m 9s root: patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
          -1 mvnsite 0m 19s hadoop-azure in the patch failed.
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 12s hadoop-azure in the patch failed.
          +1 javadoc 1m 9s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 22s the patch passed with JDK v1.7.0_95
          -1 unit 8m 7s hadoop-common in the patch failed with JDK v1.8.0_72.
          -1 unit 0m 16s hadoop-azure in the patch failed with JDK v1.8.0_72.
          +1 unit 8m 36s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 0m 17s hadoop-azure in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          70m 35s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790319/HADOOP-12846-002.patch
          JIRA Issue HADOOP-12846
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 21e81d4a7166 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 03cfb45
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-mvnsite-hadoop-tools_hadoop-azure.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 0s trunk passed +1 compile 6m 31s trunk passed with JDK v1.8.0_72 +1 compile 7m 9s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 1m 27s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 10s trunk passed +1 javadoc 1m 12s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 22s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch -1 mvninstall 0m 15s hadoop-azure in the patch failed. -1 compile 6m 49s root in the patch failed with JDK v1.8.0_72. -1 javac 6m 49s root in the patch failed with JDK v1.8.0_72. -1 compile 7m 12s root in the patch failed with JDK v1.7.0_95. -1 javac 7m 12s root in the patch failed with JDK v1.7.0_95. +1 checkstyle 1m 9s root: patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3) -1 mvnsite 0m 19s hadoop-azure in the patch failed. +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 12s hadoop-azure in the patch failed. +1 javadoc 1m 9s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 22s the patch passed with JDK v1.7.0_95 -1 unit 8m 7s hadoop-common in the patch failed with JDK v1.8.0_72. -1 unit 0m 16s hadoop-azure in the patch failed with JDK v1.8.0_72. +1 unit 8m 36s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 0m 17s hadoop-azure in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 70m 35s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790319/HADOOP-12846-002.patch JIRA Issue HADOOP-12846 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 21e81d4a7166 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 03cfb45 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-mvnsite-hadoop-tools_hadoop-azure.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8735/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          lmccay Larry McCay added a comment -

          Not sure how the previous one got through the testing phase but v003 addresses the build problems there.

          Show
          lmccay Larry McCay added a comment - Not sure how the previous one got through the testing phase but v003 addresses the build problems there.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hi Larry McCay. This looks great overall! I have a few small comments.

            public static Configuration excludeIncompatibleCredentialProviders(
                Configuration config, Class fileSystemClass) throws IOException {
              ...
                  Class<?> clazz = null;
                  try {
                    String scheme = path.toUri().getScheme();
                    clazz = FileSystem.getFileSystemClass(scheme, config);
              ...
          

          I think we can improve type safety in the above code by changing the type of fileSystemClass and clazz to Class<? extends FileSystem>. The call to FileSystem#getFileSystemClass always returns Class<? extends FileSystem>. It would never be valid to call this method and pass a Class that doesn't satisfy that type constraint. With the suggested change, that would be enforced at compile time.

                      LOG.warn("Filesystem based provider" +
                          " excluded from provider path due to recursive dependency: "
                          + provider);
          

          I'd like to suggest logging this at debug level instead of warn. In some deployments, this might not be an unusual condition. If something like Sqoop uses a credential provider for a database password, then logging this at warn could potentially display it to the console on every Sqoop invocation, which wouldn't be a good user experience.

                } catch (URISyntaxException e) {
                  LOG.warn("Credential Provider URI is invalid." + provider);
                }
          

          Is logging a warning and trying to proceed the right thing to do here, or should a bad URI cause an abort by throwing an exception?

          Do you want to update S3A to use the new ProviderUtils method too?

          Show
          cnauroth Chris Nauroth added a comment - Hi Larry McCay . This looks great overall! I have a few small comments. public static Configuration excludeIncompatibleCredentialProviders( Configuration config, Class fileSystemClass) throws IOException { ... Class <?> clazz = null ; try { String scheme = path.toUri().getScheme(); clazz = FileSystem.getFileSystemClass(scheme, config); ... I think we can improve type safety in the above code by changing the type of fileSystemClass and clazz to Class<? extends FileSystem> . The call to FileSystem#getFileSystemClass always returns Class<? extends FileSystem> . It would never be valid to call this method and pass a Class that doesn't satisfy that type constraint. With the suggested change, that would be enforced at compile time. LOG.warn( "Filesystem based provider" + " excluded from provider path due to recursive dependency: " + provider); I'd like to suggest logging this at debug level instead of warn. In some deployments, this might not be an unusual condition. If something like Sqoop uses a credential provider for a database password, then logging this at warn could potentially display it to the console on every Sqoop invocation, which wouldn't be a good user experience. } catch (URISyntaxException e) { LOG.warn( "Credential Provider URI is invalid." + provider); } Is logging a warning and trying to proceed the right thing to do here, or should a bad URI cause an abort by throwing an exception? Do you want to update S3A to use the new ProviderUtils method too?
          Hide
          lmccay Larry McCay added a comment -

          Hey Chris Nauroth - thanks for the review.

          I was letting the bad URI go through and get caught by the credential provider factory rather than stop things here.
          I also intended to follow up with a separate patch for s3a - I can add it in here instead if you think that is better.

          Show
          lmccay Larry McCay added a comment - Hey Chris Nauroth - thanks for the review. I was letting the bad URI go through and get caught by the credential provider factory rather than stop things here. I also intended to follow up with a separate patch for s3a - I can add it in here instead if you think that is better.
          Hide
          cnauroth Chris Nauroth added a comment -

          I was letting the bad URI go through and get caught by the credential provider factory rather than stop things here.

          I see now. That makes sense.

          I also intended to follow up with a separate patch for s3a - I can add it in here instead if you think that is better.

          I don't have a strong preference. Feel free to split that into a different patch if you prefer.

          I think the only things left then are the type safety change and the switch to debug level logging. Thanks!

          Show
          cnauroth Chris Nauroth added a comment - I was letting the bad URI go through and get caught by the credential provider factory rather than stop things here. I see now. That makes sense. I also intended to follow up with a separate patch for s3a - I can add it in here instead if you think that is better. I don't have a strong preference. Feel free to split that into a different patch if you prefer. I think the only things left then are the type safety change and the switch to debug level logging. Thanks!
          Hide
          lmccay Larry McCay added a comment -

          v004 addresses the review comments.

          Show
          lmccay Larry McCay added a comment - v004 addresses the review comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 7m 59s trunk passed
          +1 compile 9m 39s trunk passed with JDK v1.8.0_72
          +1 compile 8m 7s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 1m 29s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 2m 11s trunk passed
          +1 javadoc 1m 9s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 22s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 2s the patch passed
          +1 compile 6m 27s the patch passed with JDK v1.8.0_72
          -1 javac 7m 43s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 1 new + 740 unchanged - 0 fixed = 741 total (was 740)
          +1 javac 6m 27s the patch passed
          +1 compile 7m 24s the patch passed with JDK v1.7.0_95
          -1 javac 15m 7s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 735 unchanged - 0 fixed = 736 total (was 735)
          +1 javac 7m 24s the patch passed
          +1 checkstyle 1m 7s root: patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
          +1 mvnsite 1m 25s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 38s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 25s the patch passed with JDK v1.7.0_95
          +1 unit 8m 21s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 1m 17s hadoop-azure in the patch passed with JDK v1.8.0_72.
          +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 34s hadoop-azure in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          78m 47s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790322/HADOOP-12846-003.patch
          JIRA Issue HADOOP-12846
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4437f9d7f148 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 03cfb45
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8736/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8736/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8736/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8736/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 59s trunk passed +1 compile 9m 39s trunk passed with JDK v1.8.0_72 +1 compile 8m 7s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 10s trunk passed +1 mvnsite 1m 29s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 11s trunk passed +1 javadoc 1m 9s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 22s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 2s the patch passed +1 compile 6m 27s the patch passed with JDK v1.8.0_72 -1 javac 7m 43s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 1 new + 740 unchanged - 0 fixed = 741 total (was 740) +1 javac 6m 27s the patch passed +1 compile 7m 24s the patch passed with JDK v1.7.0_95 -1 javac 15m 7s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 735 unchanged - 0 fixed = 736 total (was 735) +1 javac 7m 24s the patch passed +1 checkstyle 1m 7s root: patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3) +1 mvnsite 1m 25s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 38s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 25s the patch passed with JDK v1.7.0_95 +1 unit 8m 21s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 1m 17s hadoop-azure in the patch passed with JDK v1.8.0_72. +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 34s hadoop-azure in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 78m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790322/HADOOP-12846-003.patch JIRA Issue HADOOP-12846 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4437f9d7f148 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 03cfb45 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8736/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8736/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8736/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8736/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 42s Maven dependency ordering for branch
          +1 mvninstall 7m 14s trunk passed
          +1 compile 6m 14s trunk passed with JDK v1.8.0_72
          +1 compile 7m 0s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 13s trunk passed
          +1 javadoc 1m 6s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 16s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 0s the patch passed
          +1 compile 6m 24s the patch passed with JDK v1.8.0_72
          +1 javac 6m 24s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.7.0_95
          +1 javac 6m 46s the patch passed
          +1 checkstyle 1m 3s root: patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 mvnsite 1m 23s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 30s the patch passed
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 19s the patch passed with JDK v1.7.0_95
          +1 unit 7m 48s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 1m 14s hadoop-azure in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 48s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 29s hadoop-azure in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          72m 14s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790327/HADOOP-12846-004.patch
          JIRA Issue HADOOP-12846
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ec0ccd13d5ac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 03cfb45
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8737/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8737/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 42s Maven dependency ordering for branch +1 mvninstall 7m 14s trunk passed +1 compile 6m 14s trunk passed with JDK v1.8.0_72 +1 compile 7m 0s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 5s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 13s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 16s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 0s the patch passed +1 compile 6m 24s the patch passed with JDK v1.8.0_72 +1 javac 6m 24s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed +1 checkstyle 1m 3s root: patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 mvnsite 1m 23s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 30s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_95 +1 unit 7m 48s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 1m 14s hadoop-azure in the patch passed with JDK v1.8.0_72. +1 unit 7m 48s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 29s hadoop-azure in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 72m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790327/HADOOP-12846-004.patch JIRA Issue HADOOP-12846 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ec0ccd13d5ac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 03cfb45 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8737/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8737/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for patch v004. I have committed this to trunk, branch-2 and branch-2.8. Larry McCay, thanks very much for fixing this bug.

          Show
          cnauroth Chris Nauroth added a comment - +1 for patch v004. I have committed this to trunk, branch-2 and branch-2.8. Larry McCay , thanks very much for fixing this bug.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9385 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9385/)
          HADOOP-12846. Credential Provider Recursive Dependencies. Contributed by (cnauroth: rev 7634d404b750eafa135a37fa275325d0398255fb)

          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbUriAndConfiguration.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/SimpleKeyProvider.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ProviderUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9385 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9385/ ) HADOOP-12846 . Credential Provider Recursive Dependencies. Contributed by (cnauroth: rev 7634d404b750eafa135a37fa275325d0398255fb) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbUriAndConfiguration.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/SimpleKeyProvider.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ProviderUtils.java
          Hide
          lmccay Larry McCay added a comment -

          Thanks, Chris Nauroth!

          Show
          lmccay Larry McCay added a comment - Thanks, Chris Nauroth !

            People

            • Assignee:
              lmccay Larry McCay
              Reporter:
              lmccay Larry McCay
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development