Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12526

[Branch-2] there are duplicate dependency definitions in pom's

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 2.7.1, 2.6.2
    • Fix Version/s: 2.8.0, 2.7.2, 2.6.3
    • Component/s: build
    • Labels:
      None

      Description

      There are several places where dependencies are defined multiple times within pom's, and are causing maven build warnings. They should be fixed. This is specific to branch-2.6.

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          there are branch-2 patches to fix these; just cherry pick them in

          Show
          stevel@apache.org Steve Loughran added a comment - there are branch-2 patches to fix these; just cherry pick them in
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Steve Loughran, do you have the JIRA numbers?

          IAC, we can close this as dup if there are existing tickets.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Steve Loughran , do you have the JIRA numbers? IAC, we can close this as dup if there are existing tickets.
          Hide
          sjlee0 Sangjin Lee added a comment -

          I've been looking into it. There are 5 issues (duplications), and some of the fixes can be cherry-picked but not all. I'll update with more info later today.

          Show
          sjlee0 Sangjin Lee added a comment - I've been looking into it. There are 5 issues (duplications), and some of the fixes can be cherry-picked but not all. I'll update with more info later today.
          Hide
          sjlee0 Sangjin Lee added a comment -

          There are 5 issues of duplicate dependency definitions.

          (1) hadoop-project/pom.xml: jsp-api defined twice

          • branches affected: branch-2.6
          • HADOOP-10563 fixed it but the fix is much bigger than just cleaning up jsp-api, thus cannot be easily cherry-picked
          • I propose fixing it manually (trivial)

          (2) hadoop-project/pom.xml: curator-framework and curator-test defined twice

          • branches affected: branch-2.6
          • HADOOP-12230 fixed it, and we can cherry-pick this

          (3) hadoop-project/pom.xml: maven-enforcer-plugin defined in 2 places

          • branches affected: branch-2, branch-2.6, branch-2.7
          • it was fixed (in trunk) by MAPREDUCE-3003 but the fix is much bigger than fixing this, and cannot be easily cherry-picked
          • I propose fixing it manually (trivial)

          (4) hadoop-auth/pom.xml: jetty-util defined twice

          • branches affected: branch-2, branch-2.6, branch-2.7
          • the trunk did not have the problem to begin with
          • I propose fixing it manually (trivial)

          (5) hadoop-common/pom.xml: maven-surefire-plugin defined in 2 places

          • branches affected: branch-2, branch-2.6, branch-2.7
          • fixed by HADOOP-9242, and can be cherry-picked

          So I'll go ahead and cherry-pick the fixes for (2) and (5). For others, I'll fix them using this JIRA. Will post the fixes soon.

          Show
          sjlee0 Sangjin Lee added a comment - There are 5 issues of duplicate dependency definitions. (1) hadoop-project/pom.xml: jsp-api defined twice branches affected: branch-2.6 HADOOP-10563 fixed it but the fix is much bigger than just cleaning up jsp-api, thus cannot be easily cherry-picked I propose fixing it manually (trivial) (2) hadoop-project/pom.xml: curator-framework and curator-test defined twice branches affected: branch-2.6 HADOOP-12230 fixed it, and we can cherry-pick this (3) hadoop-project/pom.xml: maven-enforcer-plugin defined in 2 places branches affected: branch-2, branch-2.6, branch-2.7 it was fixed (in trunk) by MAPREDUCE-3003 but the fix is much bigger than fixing this, and cannot be easily cherry-picked I propose fixing it manually (trivial) (4) hadoop-auth/pom.xml: jetty-util defined twice branches affected: branch-2, branch-2.6, branch-2.7 the trunk did not have the problem to begin with I propose fixing it manually (trivial) (5) hadoop-common/pom.xml: maven-surefire-plugin defined in 2 places branches affected: branch-2, branch-2.6, branch-2.7 fixed by HADOOP-9242 , and can be cherry-picked So I'll go ahead and cherry-pick the fixes for (2) and (5). For others, I'll fix them using this JIRA. Will post the fixes soon.
          Hide
          sjlee0 Sangjin Lee added a comment -

          v.1 patch for branch-2 (and branch-2.7).

          The redundant definition for jetty-util has been removed.

          The maven-enforcer-plugin issue is bit more involved. The trunk version removed one section entirely (MAPREDUCE-3003), but I'm not sure if that was completely intentional. In that JIRA, that section was left in for 0.23.

          Here, I'm essentially combining these two sections, and implementing the intent that's implied in the existing code. One section defines a number of executions that are not meant to be inherited to child pom's, and another section defines an execution that's meant to be inherited. The patch fixes the pom so that it does do that. Currently the inherited action is not really being inherited due to this issue.

          Show
          sjlee0 Sangjin Lee added a comment - v.1 patch for branch-2 (and branch-2.7). The redundant definition for jetty-util has been removed. The maven-enforcer-plugin issue is bit more involved. The trunk version removed one section entirely ( MAPREDUCE-3003 ), but I'm not sure if that was completely intentional. In that JIRA, that section was left in for 0.23. Here, I'm essentially combining these two sections, and implementing the intent that's implied in the existing code. One section defines a number of executions that are not meant to be inherited to child pom's, and another section defines an execution that's meant to be inherited. The patch fixes the pom so that it does do that. Currently the inherited action is not really being inherited due to this issue.
          Hide
          sjlee0 Sangjin Lee added a comment -

          v.1 for branch-2.6

          Show
          sjlee0 Sangjin Lee added a comment - v.1 for branch-2.6
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 1m 49s branch-2.6 passed
          +1 mvneclipse 0m 19s branch-2.6 passed
          -1 javadoc 0m 10s hadoop-auth in branch-2.6 failed with JDK v1.8.0_60.
          +1 javadoc 0m 21s branch-2.6 passed with JDK v1.7.0_79
          +1 mvninstall 0m 23s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          -1 whitespace 0m 0s The patch has 966 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 22s The patch has 67 line(s) with tabs.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 javadoc 0m 11s hadoop-auth in the patch failed with JDK v1.8.0_60.
          +1 javadoc 0m 21s the patch passed with JDK v1.7.0_79
          +1 unit 12m 21s hadoop-auth in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 7s hadoop-project in the patch passed with JDK v1.8.0_60.
          +1 unit 12m 49s hadoop-auth in the patch passed with JDK v1.7.0_79.
          +1 unit 0m 10s hadoop-project in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 23s Patch generated 58 ASF License warnings.
          31m 23s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-31
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769891/HADOOP-12526-branch-2.6.001.patch
          JIRA Issue HADOOP-12526
          Optional Tests asflicense javac javadoc mvninstall unit xml
          uname Linux 440f674953a9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision branch-2.6 / 8f8f3b1
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/whitespace-tabs.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-auth hadoop-project U: .
          Max memory used 189MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 1m 49s branch-2.6 passed +1 mvneclipse 0m 19s branch-2.6 passed -1 javadoc 0m 10s hadoop-auth in branch-2.6 failed with JDK v1.8.0_60. +1 javadoc 0m 21s branch-2.6 passed with JDK v1.7.0_79 +1 mvninstall 0m 23s the patch passed +1 mvneclipse 0m 19s the patch passed -1 whitespace 0m 0s The patch has 966 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 22s The patch has 67 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. -1 javadoc 0m 11s hadoop-auth in the patch failed with JDK v1.8.0_60. +1 javadoc 0m 21s the patch passed with JDK v1.7.0_79 +1 unit 12m 21s hadoop-auth in the patch passed with JDK v1.8.0_60. +1 unit 0m 7s hadoop-project in the patch passed with JDK v1.8.0_60. +1 unit 12m 49s hadoop-auth in the patch passed with JDK v1.7.0_79. +1 unit 0m 10s hadoop-project in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 23s Patch generated 58 ASF License warnings. 31m 23s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-31 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769891/HADOOP-12526-branch-2.6.001.patch JIRA Issue HADOOP-12526 Optional Tests asflicense javac javadoc mvninstall unit xml uname Linux 440f674953a9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision branch-2.6 / 8f8f3b1 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/whitespace-tabs.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-auth hadoop-project U: . Max memory used 189MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7982/console This message was automatically generated.
          Hide
          sjlee0 Sangjin Lee added a comment -

          The -1's are not applicable. Since the run was on branch-2.6 (which does not support JDK 1.8), the javadoc errors are not relevant. Also, the reported whitespace errors and asflicense errors are strangely about the patchprocess files! cc Allen Wittenauer

          And since this is a dependency clean-up in pom files, unit tests are not really feasible.

          Show
          sjlee0 Sangjin Lee added a comment - The -1's are not applicable. Since the run was on branch-2.6 (which does not support JDK 1.8), the javadoc errors are not relevant. Also, the reported whitespace errors and asflicense errors are strangely about the patchprocess files! cc Allen Wittenauer And since this is a dependency clean-up in pom files, unit tests are not really feasible.
          Hide
          aw Allen Wittenauer added a comment -

          Also, the reported whitespace errors and asflicense errors are strangely about the patchprocess files!

          This is a bug in the branch, not Yetus. This branch is missing HADOOP-11917 which fixes the bug.

          Show
          aw Allen Wittenauer added a comment - Also, the reported whitespace errors and asflicense errors are strangely about the patchprocess files! This is a bug in the branch, not Yetus. This branch is missing HADOOP-11917 which fixes the bug.
          Hide
          aw Allen Wittenauer added a comment -

          Also, it's good to see that minor branch detection in Yetus is working. It's another new feature vs. trunk's test-patch.

          Show
          aw Allen Wittenauer added a comment - Also, it's good to see that minor branch detection in Yetus is working. It's another new feature vs. trunk's test-patch.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Can I get reviews on these changes?

          Show
          sjlee0 Sangjin Lee added a comment - Can I get reviews on these changes?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3. Please revert back if you disagree.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3. Please revert back if you disagree.
          Hide
          sjlee0 Sangjin Lee added a comment -

          I'm fine with moving it to 2.7.3. I added back 2.8.0 and 2.6.3 as we want them in those releases too.

          Show
          sjlee0 Sangjin Lee added a comment - I'm fine with moving it to 2.7.3. I added back 2.8.0 and 2.6.3 as we want them in those releases too.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 29s branch-2.6 passed
          +1 compile 2m 14s branch-2.6 passed with JDK v1.8.0_60
          +1 compile 1m 55s branch-2.6 passed with JDK v1.7.0_79
          +1 mvneclipse 0m 28s branch-2.6 passed
          -1 javadoc 0m 13s hadoop-auth in branch-2.6 failed with JDK v1.8.0_60.
          +1 javadoc 0m 21s branch-2.6 passed with JDK v1.7.0_79
          +1 mvninstall 0m 23s the patch passed
          +1 compile 2m 8s the patch passed with JDK v1.8.0_60
          +1 javac 2m 8s the patch passed
          +1 compile 1m 57s the patch passed with JDK v1.7.0_79
          +1 javac 1m 57s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          -1 whitespace 0m 0s The patch has 2217 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 54s The patch has 67 line(s) with tabs.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          -1 javadoc 0m 11s hadoop-auth in the patch failed with JDK v1.8.0_60.
          +1 javadoc 0m 20s the patch passed with JDK v1.7.0_79
          +1 unit 4m 40s hadoop-auth in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 7s hadoop-project in the patch passed with JDK v1.8.0_60.
          +1 unit 4m 56s hadoop-auth in the patch passed with JDK v1.7.0_79.
          +1 unit 0m 9s hadoop-project in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 29s Patch generated 69 ASF License warnings.
          29m 38s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-07
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769891/HADOOP-12526-branch-2.6.001.patch
          JIRA Issue HADOOP-12526
          Optional Tests asflicense javac javadoc mvninstall unit xml compile
          uname Linux 9c3d8074dd29 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
          git revision branch-2.6 / cab916c
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/whitespace-tabs.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-auth hadoop-project U: .
          Max memory used 190MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 29s branch-2.6 passed +1 compile 2m 14s branch-2.6 passed with JDK v1.8.0_60 +1 compile 1m 55s branch-2.6 passed with JDK v1.7.0_79 +1 mvneclipse 0m 28s branch-2.6 passed -1 javadoc 0m 13s hadoop-auth in branch-2.6 failed with JDK v1.8.0_60. +1 javadoc 0m 21s branch-2.6 passed with JDK v1.7.0_79 +1 mvninstall 0m 23s the patch passed +1 compile 2m 8s the patch passed with JDK v1.8.0_60 +1 javac 2m 8s the patch passed +1 compile 1m 57s the patch passed with JDK v1.7.0_79 +1 javac 1m 57s the patch passed +1 mvneclipse 0m 20s the patch passed -1 whitespace 0m 0s The patch has 2217 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 54s The patch has 67 line(s) with tabs. +1 xml 0m 2s The patch has no ill-formed XML file. -1 javadoc 0m 11s hadoop-auth in the patch failed with JDK v1.8.0_60. +1 javadoc 0m 20s the patch passed with JDK v1.7.0_79 +1 unit 4m 40s hadoop-auth in the patch passed with JDK v1.8.0_60. +1 unit 0m 7s hadoop-project in the patch passed with JDK v1.8.0_60. +1 unit 4m 56s hadoop-auth in the patch passed with JDK v1.7.0_79. +1 unit 0m 9s hadoop-project in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 29s Patch generated 69 ASF License warnings. 29m 38s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-07 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769891/HADOOP-12526-branch-2.6.001.patch JIRA Issue HADOOP-12526 Optional Tests asflicense javac javadoc mvninstall unit xml compile uname Linux 9c3d8074dd29 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision branch-2.6 / cab916c Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/whitespace-tabs.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-auth hadoop-project U: . Max memory used 190MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1: whatever is breaking the builds, I don't think it's this pom diff

          Show
          stevel@apache.org Steve Loughran added a comment - +1: whatever is breaking the builds, I don't think it's this pom diff
          Hide
          stevel@apache.org Steve Loughran added a comment -

          BTW, log on javadoc still says some duplicates are there

          mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-branch-2.6-1 -Pdocs -DskipTests clean javadoc:javadoc -DskipTests=true
          [INFO] Scanning for projects...
          [WARNING] 
          [WARNING] Some problems were encountered while building the effective model for org.apache.hadoop:hadoop-auth:jar:2.6.3-SNAPSHOT
          [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.mortbay.jetty:jetty-util:jar -> duplicate declaration of version (?) @ line 60, column 17
          
          Show
          stevel@apache.org Steve Loughran added a comment - BTW, log on javadoc still says some duplicates are there mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-branch-2.6-1 -Pdocs -DskipTests clean javadoc:javadoc -DskipTests= true [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.hadoop:hadoop-auth:jar:2.6.3-SNAPSHOT [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.mortbay.jetty:jetty-util:jar -> duplicate declaration of version (?) @ line 60, column 17
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Javadoc + java8 problems are fixed in HADOOP-10134; feel free to cherry pick that as its just a javadoc patch

          Show
          stevel@apache.org Steve Loughran added a comment - Javadoc + java8 problems are fixed in HADOOP-10134 ; feel free to cherry pick that as its just a javadoc patch
          Hide
          sjlee0 Sangjin Lee added a comment -

          Yes, that's prior to the patch I believe: https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt

          The patched javadoc output does not have that problem.

          Show
          sjlee0 Sangjin Lee added a comment - Yes, that's prior to the patch I believe: https://builds.apache.org/job/PreCommit-HADOOP-Build/8051/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-auth-jdk1.8.0_60.txt The patched javadoc output does not have that problem.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Committed the patch to branch-2, branch-2.7, and branch-2.6. Thanks Steve Loughran for your review!

          Show
          sjlee0 Sangjin Lee added a comment - Committed the patch to branch-2, branch-2.7, and branch-2.6. Thanks Steve Loughran for your review!
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Sangjin Lee Moved entries of CHANGES.txt to 2.6.3 of based on the rule to update CHANGES.txt described on Hadoop wiki since it can cause conflicts when cherrypicking.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Sangjin Lee Moved entries of CHANGES.txt to 2.6.3 of based on the rule to update CHANGES.txt described on Hadoop wiki since it can cause conflicts when cherrypicking.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8791 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8791/)
          Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8791 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8791/ ) Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2596 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2596/)
          Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2596 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2596/ ) Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #668 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/668/)
          Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #668 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/668/ ) Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1392 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1392/)
          Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1392 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1392/ ) Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #656 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/656/)
          Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #656 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/656/ ) Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #596 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/596/)
          Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #596 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/596/ ) Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2535 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2535/)
          Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2535 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2535/ ) Updated CHANGES.txt to move HADOOP-12526 to 2.6.3. (ozawa: rev d90769757ae95770c5a5bac78110db3f9e38014f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Pulled this into 2.7.2 to keep the release up-to-date with 2.6.3. Changing fix-versions to reflect the same.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.7.2 to keep the release up-to-date with 2.6.3. Changing fix-versions to reflect the same.

            People

            • Assignee:
              sjlee0 Sangjin Lee
              Reporter:
              sjlee0 Sangjin Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development