Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12230

hadoop-project declares duplicate, conflicting curator dependencies

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.7.2, 2.6.3
    • Component/s: build
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-11492 bumped up the curator version in trunk & branch-2, but it looks like there were a couple of extra curator dependencies in branch-2 that didn't get updated, and are still down as 2.6.0

      This isn't that serious, maven will have picked the latest one, but its still messy.

      1. HADOOP-12230.branch-2.00.patch
        0.6 kB
        Akira Ajisaka
      2. HADOOP-12230.branch-2.01.patch
        0.7 kB
        Rakesh R
      3. HADOOP-12230-00.patch
        0.6 kB
        Rakesh R

        Issue Links

          Activity

          Hide
          rakeshr Rakesh R added a comment -

          Hi Steve Loughran, I could see two occurrences in hadoop-project and I'm attaching a patch based on branch-2.7. Kindly review, Thanks!

          Show
          rakeshr Rakesh R added a comment - Hi Steve Loughran , I could see two occurrences in hadoop-project and I'm attaching a patch based on branch-2.7. Kindly review, Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 0s The patch command could not apply the patch during dryrun.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764296/HADOOP-12230-00.patch
          Optional Tests javadoc javac unit
          git revision trunk / 06abc57
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7742/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764296/HADOOP-12230-00.patch Optional Tests javadoc javac unit git revision trunk / 06abc57 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7742/console This message was automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          Note: The attached patch is based on branch2-7. I think the patch is failing because it is trying to apply the patch against trunk.

          Show
          rakeshr Rakesh R added a comment - Note: The attached patch is based on branch2-7 . I think the patch is failing because it is trying to apply the patch against trunk .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Looks good to me. +1 pending Jenkins. Renamed the patch to run Jenkins on branch-2.

          Show
          ajisakaa Akira Ajisaka added a comment - Looks good to me. +1 pending Jenkins. Renamed the patch to run Jenkins on branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 24s Pre-patch branch-2 compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 6m 19s There were no new javac warning messages.
          +1 javadoc 10m 16s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 14s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
              34m 14s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764638/HADOOP-12230.branch-2.00.patch
          Optional Tests javadoc javac unit
          git revision branch-2 / c6f30e5
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7750/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7750/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 24s Pre-patch branch-2 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 6m 19s There were no new javac warning messages. +1 javadoc 10m 16s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 14s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.     34m 14s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764638/HADOOP-12230.branch-2.00.patch Optional Tests javadoc javac unit git revision branch-2 / c6f30e5 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7750/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7750/console This message was automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          Thank you Akira Ajisaka for the reviews and the help in getting Jenkins report.

          Show
          rakeshr Rakesh R added a comment - Thank you Akira Ajisaka for the reviews and the help in getting Jenkins report.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, the patch needs no test because it is to remove duplicate dependency.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, the patch needs no test because it is to remove duplicate dependency.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Cancelling my +1. You need to remove duplicating declaration instead of setting the right version. Would you remove the following code?

                <dependency>
                  <groupId>org.apache.curator</groupId>
                  <artifactId>curator-framework</artifactId>
                  <version>2.6.0</version>
                </dependency>
                <dependency>
                  <groupId>org.apache.curator</groupId>
                  <artifactId>curator-test</artifactId>
                  <version>2.6.0</version>
                </dependency>
          
          Show
          ajisakaa Akira Ajisaka added a comment - Cancelling my +1. You need to remove duplicating declaration instead of setting the right version. Would you remove the following code? <dependency> <groupId>org.apache.curator</groupId> <artifactId>curator-framework</artifactId> <version>2.6.0</version> </dependency> <dependency> <groupId>org.apache.curator</groupId> <artifactId>curator-test</artifactId> <version>2.6.0</version> </dependency>
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Sorry for the back and forth.

          Show
          ajisakaa Akira Ajisaka added a comment - Sorry for the back and forth.
          Hide
          rakeshr Rakesh R added a comment -

          Thanks again Akira Ajisaka for the detailed review, I didn't notice the duplicate declaration. Attached another patch modifying the same.

          Show
          rakeshr Rakesh R added a comment - Thanks again Akira Ajisaka for the detailed review, I didn't notice the duplicate declaration. Attached another patch modifying the same.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 5s Pre-patch branch-2 compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 6m 1s There were no new javac warning messages.
          +1 javadoc 9m 50s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 15s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
              33m 14s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764746/HADOOP-12230.branch-2.01.patch
          Optional Tests javadoc javac unit
          git revision branch-2 / 07f9405
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7755/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7755/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 5s Pre-patch branch-2 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 6m 1s There were no new javac warning messages. +1 javadoc 9m 50s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 15s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.     33m 14s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764746/HADOOP-12230.branch-2.01.patch Optional Tests javadoc javac unit git revision branch-2 / 07f9405 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7755/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7755/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2 and branch-2.7. Thanks Steve Loughran for reporting this and thanks Rakesh R for creating patches.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2 and branch-2.7. Thanks Steve Loughran for reporting this and thanks Rakesh R for creating patches.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Committed it to branch-2.6 for 2.6.3.

          Show
          sjlee0 Sangjin Lee added a comment - Committed it to branch-2.6 for 2.6.3.

            People

            • Assignee:
              rakeshr Rakesh R
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.25h
                0.25h
                Remaining:
                Remaining Estimate - 0.25h
                0.25h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development