Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Delete.java and Server.java cannot be compiled with "unmappable character ofr encoding ASCII".

      [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:416: error: unmappable character for encoding ASCII
      [javadoc] * by searching for 68?95?99.7 rule. We flag an RPC as slow RPC
      [javadoc] ^
      [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:416: error: unmappable character for encoding ASCII
      [javadoc] * by searching for 68?95?99.7 rule. We flag an RPC as slow RPC
      [javadoc] ^
      [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:416: error: unmappable character for encoding ASCII
      [javadoc] * by searching for 68?95?99.7 rule. We flag an RPC as slow RPC
      [javadoc] ^
      [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:416: error: unmappable character for encoding ASCII
      [javadoc] * by searching for 68?95?99.7 rule. We flag an RPC as slow RPC
      [javadoc] ^
      [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:416: error: unmappable character for encoding ASCII
      [javadoc] * by searching for 68?95?99.7 rule. We flag an RPC as slow RPC
      [javadoc] ^
      [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:416: error: unmappable character for encoding ASCII
      [javadoc] * by searching for 68?95?99.7 rule. We flag an RPC as slow RPC

      1. HADOOP-12457.02.patch
        3 kB
        Akira Ajisaka
      2. HADOOP-12457.01.patch
        2 kB
        Akira Ajisaka
      3. HADOOP-12457.00.patch
        0.9 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1325 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1325/)
          HADOOP-12457. [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1325 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1325/ ) HADOOP-12457 . [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #541 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/541/)
          HADOOP-12457. [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #541 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/541/ ) HADOOP-12457 . [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #601 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/601/)
          HADOOP-12457. [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #601 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/601/ ) HADOOP-12457 . [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8712 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8712/)
          HADOOP-12457. [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8712 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8712/ ) HADOOP-12457 . [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/589/)
          HADOOP-12457. [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/589/ ) HADOOP-12457 . [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2531 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2531/)
          HADOOP-12457. [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2531 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2531/ ) HADOOP-12457 . [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2478 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2478/)
          HADOOP-12457. [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2478 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2478/ ) HADOOP-12457 . [JDK8] Fix a failure of compiling common by javadoc. (ozawa: rev ea6b183a1a649ad2874050ade8856286728c654c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Committed this to trunk and branch-2. Thanks Akira Ajisaka for your contribution and thanks Steve Loughran for your review.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Akira Ajisaka for your contribution and thanks Steve Loughran for your review.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Li Lu Opened HADOOP-12516. Could you give us the detail of the problem there?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Li Lu Opened HADOOP-12516 . Could you give us the detail of the problem there?
          Hide
          gtCarrera9 Li Lu added a comment -

          Thanks for the pointer Tsuyoshi Ozawa! I do remember this problem when working with jdiff. I can provide some more detail if you need in the new issue.

          Show
          gtCarrera9 Li Lu added a comment - Thanks for the pointer Tsuyoshi Ozawa ! I do remember this problem when working with jdiff. I can provide some more detail if you need in the new issue.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          This looks like a bug reported by Li Lu on HADOOP-11776. https://issues.apache.org/jira/browse/HADOOP-11776?focusedCommentId=14391868&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14391868

          I will create new issue to address the problem.
          The patch itself works well. +1, checking this in.

          Show
          ozawa Tsuyoshi Ozawa added a comment - This looks like a bug reported by Li Lu on HADOOP-11776 . https://issues.apache.org/jira/browse/HADOOP-11776?focusedCommentId=14391868&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14391868 I will create new issue to address the problem. The patch itself works well. +1, checking this in.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 29s trunk passed
          +1 compile 5m 18s trunk passed with JDK v1.8.0_60
          +1 compile 4m 53s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 18s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 1m 6s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 14s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 37s the patch passed
          +1 compile 5m 16s the patch passed with JDK v1.8.0_60
          +1 javac 5m 16s the patch passed
          +1 compile 5m 15s the patch passed with JDK v1.7.0_79
          +1 javac 5m 15s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 10s the patch passed
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 11s the patch passed with JDK v1.7.0_79
          -1 unit 8m 15s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 7m 53s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          53m 26s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestMetricsSystemImpl
            hadoop.ha.TestZKFailoverController
            hadoop.ipc.TestDecayRpcScheduler



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-26
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768746/HADOOP-12457.02.patch
          JIRA Issue HADOOP-12457
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 739b3465e062 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh
          git revision trunk / 123b3db
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/testReport/
          Max memory used 231MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 29s trunk passed +1 compile 5m 18s trunk passed with JDK v1.8.0_60 +1 compile 4m 53s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 18s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 14s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 37s the patch passed +1 compile 5m 16s the patch passed with JDK v1.8.0_60 +1 javac 5m 16s the patch passed +1 compile 5m 15s the patch passed with JDK v1.7.0_79 +1 javac 5m 15s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 11s the patch passed with JDK v1.7.0_79 -1 unit 8m 15s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 7m 53s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 53m 26s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestMetricsSystemImpl   hadoop.ha.TestZKFailoverController   hadoop.ipc.TestDecayRpcScheduler Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-26 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768746/HADOOP-12457.02.patch JIRA Issue HADOOP-12457 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 739b3465e062 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh git revision trunk / 123b3db Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/testReport/ Max memory used 231MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7936/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'm compiling with JDK8u60.

          macaa:~ aajisaka$ java -version
          java version "1.8.0_60-ea"
          Java(TM) SE Runtime Environment (build 1.8.0_60-ea-b25)
          Java HotSpot(TM) 64-Bit Server VM (build 25.60-b23, mixed mode)
          

          [javadoc] Error: duplicate comment id: org.apache.hadoop.metrics2.MetricsSystem.register_changed(java.lang.String, java.lang.String, T)

          I cannot find register_changed method in o.a.h.metrics2.MetricsSystem.java. Where is the file that is causing this error?

          Show
          ajisakaa Akira Ajisaka added a comment - I'm compiling with JDK8u60. macaa:~ aajisaka$ java -version java version "1.8.0_60-ea" Java(TM) SE Runtime Environment (build 1.8.0_60-ea-b25) Java HotSpot(TM) 64-Bit Server VM (build 25.60-b23, mixed mode) [javadoc] Error: duplicate comment id: org.apache.hadoop.metrics2.MetricsSystem.register_changed(java.lang.String, java.lang.String, T) I cannot find register_changed method in o.a.h.metrics2.MetricsSystem.java. Where is the file that is causing this error?
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Akira Ajisaka are you compiling source code with JDK8? I faced following error:

          [javadoc] Warning: incorrectly formatted @link in text: Retrieve the Bloom filter used by this instance of the Reader.
          [javadoc] @return a Bloom filter (see

          Unknown macro: {@link Filter}

          )
          [javadoc] Error: duplicate comment id: org.apache.hadoop.metrics2.MetricsSystem.register_changed(java.lang.String, java.lang.String, T)

          Show
          ozawa Tsuyoshi Ozawa added a comment - Akira Ajisaka are you compiling source code with JDK8? I faced following error: [javadoc] Warning: incorrectly formatted @link in text: Retrieve the Bloom filter used by this instance of the Reader. [javadoc] @return a Bloom filter (see Unknown macro: {@link Filter} ) [javadoc] Error: duplicate comment id: org.apache.hadoop.metrics2.MetricsSystem.register_changed(java.lang.String, java.lang.String, T)
          Hide
          ajisakaa Akira Ajisaka added a comment -

          With 02 patch and the patch in YARN-4300, "mvn package -Pdist,docs -DskipTests" passed on my environment.

          Show
          ajisakaa Akira Ajisaka added a comment - With 02 patch and the patch in YARN-4300 , "mvn package -Pdist,docs -DskipTests" passed on my environment.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Fixed Configuration.java.

          Show
          ajisakaa Akira Ajisaka added a comment - Fixed Configuration.java.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 13s trunk passed
          +1 compile 5m 4s trunk passed with JDK v1.8.0_60
          +1 compile 4m 47s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 18s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 12s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 32s the patch passed
          +1 compile 5m 0s the patch passed with JDK v1.8.0_60
          +1 javac 5m 0s the patch passed
          +1 compile 4m 49s the patch passed with JDK v1.7.0_79
          +1 javac 4m 49s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 13s the patch passed with JDK v1.7.0_79
          -1 unit 7m 48s hadoop-common in the patch failed with JDK v1.8.0_60.
          +1 unit 8m 13s hadoop-common in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          51m 43s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.metrics2.impl.TestMetricsSystemImpl



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-26
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768730/HADOOP-12457.01.patch
          JIRA Issue HADOOP-12457
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 74898654009a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh
          git revision trunk / 123b3db
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7935/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7935/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7935/testReport/
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7935/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 13s trunk passed +1 compile 5m 4s trunk passed with JDK v1.8.0_60 +1 compile 4m 47s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 18s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 12s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 32s the patch passed +1 compile 5m 0s the patch passed with JDK v1.8.0_60 +1 javac 5m 0s the patch passed +1 compile 4m 49s the patch passed with JDK v1.7.0_79 +1 javac 4m 49s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 13s the patch passed with JDK v1.7.0_79 -1 unit 7m 48s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 8m 13s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 51m 43s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.metrics2.impl.TestMetricsSystemImpl Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-26 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768730/HADOOP-12457.01.patch JIRA Issue HADOOP-12457 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 74898654009a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh git revision trunk / 123b3db Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7935/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7935/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7935/testReport/ Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7935/console This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          My bashrc

          export LANG=C
          export LC_ALL=C
          

          Command: mvn package -Pdist,docs -DskipTests

          Show
          ozawa Tsuyoshi Ozawa added a comment - My bashrc export LANG=C export LC_ALL=C Command: mvn package -Pdist,docs -DskipTests
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Filed YARN-4300.

          Show
          ajisakaa Akira Ajisaka added a comment - Filed YARN-4300 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Executed "mvn package -Pdist -Dtar -DskipTests" and got the following error.

          [ERROR] /Users/aajisaka/git/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/nodelabels/ScriptBasedNodeLabelsProvider.java:116: error: exception not thrown: java.lang.Exception
          [ERROR] * @throws Exception
          [ERROR] ^
          

          I'll file a separate jira for fixing this.

          Show
          ajisakaa Akira Ajisaka added a comment - Executed "mvn package -Pdist -Dtar -DskipTests" and got the following error. [ERROR] /Users/aajisaka/git/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/nodelabels/ScriptBasedNodeLabelsProvider.java:116: error: exception not thrown: java.lang.Exception [ERROR] * @throws Exception [ERROR] ^ I'll file a separate jira for fixing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Sure. What command are you using to reproduce the error? I'd like to fix all the failures and then create a patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Sure. What command are you using to reproduce the error? I'd like to fix all the failures and then create a patch.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Akira Ajisaka On my local, a next failure appeared - could you also fix it?

          [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:182: error: unmappable character for encoding ASCII
          [javadoc] * The former is resolved to ?default? if <tt>$

          Unknown macro: {<i>NAME</i>}

          </tt> environment variable is undefined

          Show
          ozawa Tsuyoshi Ozawa added a comment - Akira Ajisaka On my local, a next failure appeared - could you also fix it? [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:182: error: unmappable character for encoding ASCII [javadoc] * The former is resolved to ? default ? if <tt>$ Unknown macro: {<i>NAME</i>} </tt> environment variable is undefined
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Fixed Delete.java. Thanks Tsuyoshi Ozawa for reviewing the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Fixed Delete.java. Thanks Tsuyoshi Ozawa for reviewing the patch.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Steve Loughran I think we should address all these kind of problems under hadoop-common-project here. Thoughts?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Steve Loughran I think we should address all these kind of problems under hadoop-common-project here. Thoughts?
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Good catch. This can be reproduced when LANG=C is set and -Dfile.encoding=UTF-8 is NOT set.

          Akira Ajisaka, in fact the patch is not enough - could you also fix Delete.java?

          [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java:68: error: unmappable character for encoding ASCII
          [javadoc] "-safely: option requires safety confirmation???if enabled, " +
          [javadoc] ^
          [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java:68: error: unmappable character for encoding ASCII
          [javadoc] "-safely: option requires safety confirmation???if enabled, " +
          [javadoc] ^
          [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java:68: error: unmappable character for encoding ASCII
          [javadoc] "-safely: option requires safety confirmation???if enabled, " +
          [javadoc]

          Show
          ozawa Tsuyoshi Ozawa added a comment - Good catch. This can be reproduced when LANG=C is set and -Dfile.encoding=UTF-8 is NOT set. Akira Ajisaka , in fact the patch is not enough - could you also fix Delete.java? [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java:68: error: unmappable character for encoding ASCII [javadoc] "-safely: option requires safety confirmation???if enabled, " + [javadoc] ^ [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java:68: error: unmappable character for encoding ASCII [javadoc] "-safely: option requires safety confirmation???if enabled, " + [javadoc] ^ [javadoc] /home/ubuntu/hadoop-dev/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java:68: error: unmappable character for encoding ASCII [javadoc] "-safely: option requires safety confirmation???if enabled, " + [javadoc]
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 24s trunk passed
          +1 compile 5m 1s trunk passed with JDK v1.8.0_60
          +1 compile 4m 45s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 18s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 52s trunk passed
          +1 javadoc 1m 1s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 13s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 41s the patch passed
          +1 compile 4m 56s the patch passed with JDK v1.8.0_60
          +1 javac 4m 56s the patch passed
          +1 compile 4m 49s the patch passed with JDK v1.7.0_79
          +1 javac 4m 49s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 1m 1s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 13s the patch passed with JDK v1.7.0_79
          -1 unit 7m 41s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 7m 37s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          51m 1s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.test.TestTimedOutTestsListener
            hadoop.ipc.TestDecayRpcScheduler



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-26
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768702/HADOOP-12457.00.patch
          JIRA Issue HADOOP-12457
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 3578d5f44a1b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh
          git revision trunk / 5acdde4
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/testReport/
          Max memory used 230MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 24s trunk passed +1 compile 5m 1s trunk passed with JDK v1.8.0_60 +1 compile 4m 45s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 18s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 1m 1s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 13s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 41s the patch passed +1 compile 4m 56s the patch passed with JDK v1.8.0_60 +1 javac 4m 56s the patch passed +1 compile 4m 49s the patch passed with JDK v1.7.0_79 +1 javac 4m 49s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 13s the patch passed with JDK v1.7.0_79 -1 unit 7m 41s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 7m 37s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 51m 1s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.test.TestTimedOutTestsListener   hadoop.ipc.TestDecayRpcScheduler Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-26 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768702/HADOOP-12457.00.patch JIRA Issue HADOOP-12457 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 3578d5f44a1b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh git revision trunk / 5acdde4 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/testReport/ Max memory used 230MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7934/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Tsuyoshi Ozawa for the report and thank Steve Loughran for the comment. Attaching a patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Tsuyoshi Ozawa for the report and thank Steve Loughran for the comment. Attaching a patch.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          this might be a locale issue.

          * by searching for 68–5–99.7 rule. We flag an RPC as slow RPC
          

          Looking at the line, I think they are long hyphens "—" not minus signs "-"

          If you supply a patch to change the symbols I'll +1 it

          Show
          stevel@apache.org Steve Loughran added a comment - this might be a locale issue. * by searching for 68–5–99.7 rule. We flag an RPC as slow RPC Looking at the line, I think they are long hyphens "—" not minus signs "-" If you supply a patch to change the symbols I'll +1 it

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ozawa Tsuyoshi Ozawa
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development