Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12325

RPC Metrics : Add the ability track and log slow RPCs

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: ipc, metrics
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This JIRA proposes to add a counter called RpcSlowCalls and also a configuration setting that allows users to log really slow RPCs. Slow RPCs are RPCs that fall at 99th percentile. This is useful to troubleshoot why certain services like name node freezes under heavy load.

      1. Callers of WritableRpcEngine.call.png
        142 kB
        Xiaoyu Yao
      2. HADOOP-12325.001.patch
        17 kB
        Anu Engineer
      3. HADOOP-12325.002.patch
        15 kB
        Anu Engineer
      4. HADOOP-12325.003.patch
        15 kB
        Anu Engineer
      5. HADOOP-12325.004.patch
        15 kB
        Anu Engineer
      6. HADOOP-12325.005.patch
        16 kB
        Anu Engineer
      7. HADOOP-12325.005.test.patch
        16 kB
        Akira Ajisaka
      8. HADOOP-12325.006.patch
        16 kB
        Anu Engineer
      9. HADOOP-12325-branch-2.7.00.patch
        18 kB
        Zhe Zhang

        Issue Links

          Activity

          Hide
          anu Anu Engineer added a comment -

          This patch adds :

          • An metric called RpcSlowCalls
          • Ability to log Slow calls if ipc.server.log.slow.rpc is set to true
          Show
          anu Anu Engineer added a comment - This patch adds : An metric called RpcSlowCalls Ability to log Slow calls if ipc.server.log.slow.rpc is set to true
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 24s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 8m 18s There were no new javac warning messages.
          +1 javadoc 10m 12s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 22s The applied patch generated 4 new checkstyle issues (total was 465, now 468).
          -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
          +1 findbugs 2m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 23m 21s Tests failed in hadoop-common.
              65m 12s  



          Reason Tests
          Failed unit tests hadoop.net.TestNetUtils
            hadoop.ha.TestZKFailoverController
            hadoop.ipc.TestRPC



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750629/HADOOP-12325.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / dc7a061
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/artifact/patchprocess/diffcheckstylehadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 24s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 8m 18s There were no new javac warning messages. +1 javadoc 10m 12s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 22s The applied patch generated 4 new checkstyle issues (total was 465, now 468). -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 23m 21s Tests failed in hadoop-common.     65m 12s   Reason Tests Failed unit tests hadoop.net.TestNetUtils   hadoop.ha.TestZKFailoverController   hadoop.ipc.TestRPC Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750629/HADOOP-12325.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / dc7a061 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7482/console This message was automatically generated.
          Hide
          anu Anu Engineer added a comment -

          None of the test failures seems to be related to this patch. I have verified the failed RPC test does execute properly with this patch applied.

          Show
          anu Anu Engineer added a comment - None of the test failures seems to be related to this patch. I have verified the failed RPC test does execute properly with this patch applied.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks for working on this Anu Engineer. Below are some early comments:

          1. Do you miss updating all the caller of ProtobufRpcEngine.call() to pass receiveTime using Time.monotonicNow() instead of the Time.now()?

          For example, the constructor of Call() is still use Time.now() and some callers ProtobufRpcEngine.call(Server, String, Writable, long) (org.apache.hadoop.ipc) also passes receiveTime returned from Time.now().

          org.apache.hadoop.ipc.Server.java
          private boolean processResponse(LinkedList<Call> responseQueue,
                                              boolean inHandler) throws IOException {
                        // set the serve time when the response has to be sent later
                        call.timestamp = Time.now();
          

          Compare Time.monotonicNow() with Time.now() will produce unpredictable results. Searching through the code, I found that changing all the Call#timestamp from Time.Now() to Time.MonotonicNow is a broader change than the original purpose of this JIRA. It is probably better to just keep the current usage of Time.now() AS-IS for this ticket and use a separate JIRA to track changing Time.now() to Time.monotonic() for RPC call layer usage.

          2. Do we need update WritableRpcEngine.java class with logSlowRpcCalls()?

          3. NIT: Can you put the magic number 1024 as final variable like
          "final int minSampleSize = 1024" and
          move some of the comments to javadoc of the function: "Also we start this
          682 * logic only after we have enough sample size."

          // 1024 is just a guess -- not a number computed based on
          691	    // sample size analysis. It is chosen with the hope that this
          692	    // number is high enough to avoid spurious logging, yet useful
          693	    // in practice.
          

          4. Can you change the following from

          String message = String.format(
          697	          "Slow RPC : %s took %d milliseconds to process. Rpc Request" +
          698	              "  :  %s",
          699	          request.getMethodName(), processingTime, request.toString());
          700	      LOG.warn(message);
          

          to the following for better logging performance.

          LOG.warn("Slow RPC : {} took {} milliseconds to process. Rpc Request" +
          698	              "  :  {}",request.getMethodName(), processingTime, request.toString());
          

          5. NIT: Rpc -> RPC to be consistent

          73	   * @param server - RPC Server
          	   * @param request - Rpc Request
          

          6. Can you make the SleepRequestProto accepting a duration parameter instead of the fixed SLEEP_DURATION (1000ms)? That will make it more useful for future tests without additional code changes.

          7. Is it possible to test with 1K fast calls instead of 10K calls to save test resources without affecting the results?

          Show
          xyao Xiaoyu Yao added a comment - Thanks for working on this Anu Engineer . Below are some early comments: 1. Do you miss updating all the caller of ProtobufRpcEngine.call() to pass receiveTime using Time.monotonicNow() instead of the Time.now()? For example, the constructor of Call() is still use Time.now() and some callers ProtobufRpcEngine.call(Server, String, Writable, long) (org.apache.hadoop.ipc) also passes receiveTime returned from Time.now(). org.apache.hadoop.ipc.Server.java private boolean processResponse(LinkedList<Call> responseQueue, boolean inHandler) throws IOException { // set the serve time when the response has to be sent later call.timestamp = Time.now(); Compare Time.monotonicNow() with Time.now() will produce unpredictable results. Searching through the code, I found that changing all the Call#timestamp from Time.Now() to Time.MonotonicNow is a broader change than the original purpose of this JIRA. It is probably better to just keep the current usage of Time.now() AS-IS for this ticket and use a separate JIRA to track changing Time.now() to Time.monotonic() for RPC call layer usage. 2. Do we need update WritableRpcEngine.java class with logSlowRpcCalls()? 3. NIT: Can you put the magic number 1024 as final variable like "final int minSampleSize = 1024" and move some of the comments to javadoc of the function: "Also we start this 682 * logic only after we have enough sample size." // 1024 is just a guess -- not a number computed based on 691 // sample size analysis. It is chosen with the hope that this 692 // number is high enough to avoid spurious logging, yet useful 693 // in practice. 4. Can you change the following from String message = String .format( 697 "Slow RPC : %s took %d milliseconds to process. Rpc Request" + 698 " : %s" , 699 request.getMethodName(), processingTime, request.toString()); 700 LOG.warn(message); to the following for better logging performance. LOG.warn( "Slow RPC : {} took {} milliseconds to process. Rpc Request" + 698 " : {}" ,request.getMethodName(), processingTime, request.toString()); 5. NIT: Rpc -> RPC to be consistent 73 * @param server - RPC Server * @param request - Rpc Request 6. Can you make the SleepRequestProto accepting a duration parameter instead of the fixed SLEEP_DURATION (1000ms)? That will make it more useful for future tests without additional code changes. 7. Is it possible to test with 1K fast calls instead of 10K calls to save test resources without affecting the results?
          Hide
          anu Anu Engineer added a comment -

          Thanks for detailed review Xiaoyu Yao . I have attached a revised patch. Please see below for my detailed comments.

          1. Do you miss updating all the caller of ProtobufRpcEngine.call() to pass receiveTime using Time.monotonicNow() instead of the Time.now()?

          fixed, I have reverted to using Time.now() for in this patch.

          2. Do we need update WritableRpcEngine.java class with logSlowRpcCalls()?

          I could not find any place where we were using WritableRpcEngine for real, hence I did not make that change.

          3. NIT: Can you put the magic number 1024 as final variable like

          fixed

          4. Can you change the following from

          fixed

          5. NIT: Rpc -> RPC to be consistent

          fixed

          Can you make the SleepRequestProto accepting a duration parameter instead of the fixed SLEEP_DURATION (1000ms)?

          done

          7. Is it possible to test with 1K fast calls instead of 10K calls to save test resources without affecting the results?

          I had benchmarked these calls and even with 10K it is in milliseconds. The reason I was making 10 K calls is to make sure that the test exercises the computation and the statistical significance properly.

          Show
          anu Anu Engineer added a comment - Thanks for detailed review Xiaoyu Yao . I have attached a revised patch. Please see below for my detailed comments. 1. Do you miss updating all the caller of ProtobufRpcEngine.call() to pass receiveTime using Time.monotonicNow() instead of the Time.now()? fixed, I have reverted to using Time.now() for in this patch. 2. Do we need update WritableRpcEngine.java class with logSlowRpcCalls()? I could not find any place where we were using WritableRpcEngine for real, hence I did not make that change. 3. NIT: Can you put the magic number 1024 as final variable like fixed 4. Can you change the following from fixed 5. NIT: Rpc -> RPC to be consistent fixed Can you make the SleepRequestProto accepting a duration parameter instead of the fixed SLEEP_DURATION (1000ms)? done 7. Is it possible to test with 1K fast calls instead of 10K calls to save test resources without affecting the results? I had benchmarked these calls and even with 10K it is in milliseconds. The reason I was making 10 K calls is to make sure that the test exercises the computation and the statistical significance properly.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Anu Engineer for updating that patch! +1 for the latest patch pending Jenkins.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Anu Engineer for updating that patch! +1 for the latest patch pending Jenkins.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          I kicked off a Jenkins build. Looks like the last one OOM'ed.

          Show
          arpitagarwal Arpit Agarwal added a comment - I kicked off a Jenkins build. Looks like the last one OOM'ed.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 8s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 7m 58s There were no new javac warning messages.
          +1 javadoc 10m 1s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 11s The applied patch generated 4 new checkstyle issues (total was 457, now 460).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 22m 33s Tests failed in hadoop-common.
              63m 12s  



          Reason Tests
          Failed unit tests hadoop.ha.TestZKFailoverController
            hadoop.net.TestNetUtils



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12751148/HADOOP-12325.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 4e14f79
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7515/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7515/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7515/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7515/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 8s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 10m 1s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 11s The applied patch generated 4 new checkstyle issues (total was 457, now 460). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 33s Tests failed in hadoop-common.     63m 12s   Reason Tests Failed unit tests hadoop.ha.TestZKFailoverController   hadoop.net.TestNetUtils Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751148/HADOOP-12325.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4e14f79 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7515/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7515/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7515/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7515/console This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          The unit test failure does not seem to be related to this change. Anu Engineer, can you fix the checkstyle issues?

          Show
          xyao Xiaoyu Yao added a comment - The unit test failure does not seem to be related to this change. Anu Engineer , can you fix the checkstyle issues?
          Hide
          anu Anu Engineer added a comment -

          Fixed CheckStyle issues , two issues still remain, please ignore them.

          • Server.java - File is too long
          • Variable 'logSlowRPC' must be private - it is a hadoop metric and follows the general pattern in the file.
          Show
          anu Anu Engineer added a comment - Fixed CheckStyle issues , two issues still remain, please ignore them. Server.java - File is too long Variable 'logSlowRPC' must be private - it is a hadoop metric and follows the general pattern in the file.
          Hide
          xyao Xiaoyu Yao added a comment -

          Anu Engineer, thanks for updating the patch. Some further comments:

          I could not find any place where we were using WritableRpcEngine for real, hence I did not make that change.

          I've attached a caller hierarchy from IntelliJ for WritableRpcEngine#call. I think we should logSlowRpcCalls for both ProtobufRpcEngine#call and WritableRpcEngine#call. The easy way to do this is to refactor logSlowRpcCalls from ProtobufRpcEngine.java to Server.java. This way, both ProtocoBufRpcEngine#call and WritableRpcEngine#call can simply call server#logSlowRpcCalls instead.

          There is an early JIRA HDFS-5180 with patches available sharing the similar idea. We can resolve that one once HADOOP-12325 is fixed.

          Show
          xyao Xiaoyu Yao added a comment - Anu Engineer , thanks for updating the patch. Some further comments: I could not find any place where we were using WritableRpcEngine for real, hence I did not make that change. I've attached a caller hierarchy from IntelliJ for WritableRpcEngine#call. I think we should logSlowRpcCalls for both ProtobufRpcEngine#call and WritableRpcEngine#call. The easy way to do this is to refactor logSlowRpcCalls from ProtobufRpcEngine.java to Server.java. This way, both ProtocoBufRpcEngine#call and WritableRpcEngine#call can simply call server#logSlowRpcCalls instead. There is an early JIRA HDFS-5180 with patches available sharing the similar idea. We can resolve that one once HADOOP-12325 is fixed.
          Hide
          anu Anu Engineer added a comment -

          Xiaoyu Yao Thanks for the comments and the call graph to WritableRpcEngine. You are absolutely right in the sense that it is possible to call into WritableRpcEngine. But AFAIK no service in hadoop does it these days and all services use protobuf RPC. Hence the logging code is contained in ProtobufRPCEngine.

          I would think that modifying WritableRPCEngine would not be very useful since no services really is passing WritableRPCEngine as the RPC engine, and hence logging slow calls is not very useful. Please let me know if you agree with this analysis or if you really would like to move the code to server.java and log slow calls for both ProtobufRpcEngine as well as WritableRpcEngine.

          Show
          anu Anu Engineer added a comment - Xiaoyu Yao Thanks for the comments and the call graph to WritableRpcEngine. You are absolutely right in the sense that it is possible to call into WritableRpcEngine. But AFAIK no service in hadoop does it these days and all services use protobuf RPC. Hence the logging code is contained in ProtobufRPCEngine. I would think that modifying WritableRPCEngine would not be very useful since no services really is passing WritableRPCEngine as the RPC engine, and hence logging slow calls is not very useful. Please let me know if you agree with this analysis or if you really would like to move the code to server.java and log slow calls for both ProtobufRpcEngine as well as WritableRpcEngine.
          Hide
          anu Anu Engineer added a comment -

          fix java doc

          Show
          anu Anu Engineer added a comment - fix java doc
          Hide
          xyao Xiaoyu Yao added a comment -

          Anu Engineer, I can see Yarn/MR2 as part of Hadoop call into WritableRpcEngine#call from the call graph. I still think we should refactor logSlowRpcCalls from ProtobufRpcEngine.java to Server.java. Once we have that, changes in ProtobufRpcEngine and WritableRPCEngine should be minimal and straightforward.

          Show
          xyao Xiaoyu Yao added a comment - Anu Engineer , I can see Yarn/MR2 as part of Hadoop call into WritableRpcEngine#call from the call graph. I still think we should refactor logSlowRpcCalls from ProtobufRpcEngine.java to Server.java. Once we have that, changes in ProtobufRpcEngine and WritableRPCEngine should be minimal and straightforward.
          Hide
          anu Anu Engineer added a comment -

          Thanks for your comments. I will re-factor the patch and upload.

          Show
          anu Anu Engineer added a comment - Thanks for your comments. I will re-factor the patch and upload.
          Hide
          anu Anu Engineer added a comment -

          Support Slow RPC logging for WriteableRpcEngine also

          Show
          anu Anu Engineer added a comment - Support Slow RPC logging for WriteableRpcEngine also
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Anu Engineer for updating the patch. +1 pending Jenkins.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Anu Engineer for updating the patch. +1 pending Jenkins.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Anu Engineer for creating the patch. Two comments:

          1. Would you add a whitespace before "took " in the log message?

          +        LOG.warn(
          +            "Slow RPC : " + methodName + "took " + processingTime +
          +                " milliseconds to process from client " + client);
          

          2. After running the regression test locally, I can't see any logs about sleep RPC. I'm thinking the test should output the log as follows:

          2015-08-24 15:16:31,771 WARN  ipc.Server (Server.java:logSlowRpcCalls(438)) - Slow RPC : sleep 1001 milliseconds to process from client 127.0.0.1:52257
          

          Would you fix this?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Anu Engineer for creating the patch. Two comments: 1. Would you add a whitespace before "took " in the log message? + LOG.warn( + "Slow RPC : " + methodName + "took " + processingTime + + " milliseconds to process from client " + client); 2. After running the regression test locally, I can't see any logs about sleep RPC. I'm thinking the test should output the log as follows: 2015-08-24 15:16:31,771 WARN ipc.Server (Server.java:logSlowRpcCalls(438)) - Slow RPC : sleep 1001 milliseconds to process from client 127.0.0.1:52257 Would you fix this?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching a patch to verify that the slow call is logged. Now the test fails.

          Show
          ajisakaa Akira Ajisaka added a comment - Attaching a patch to verify that the slow call is logged. Now the test fails.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 44s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 11m 8s There were no new javac warning messages.
          +1 javadoc 13m 21s There were no new javadoc warning messages.
          +1 release audit 0m 37s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 29s The applied patch generated 2 new checkstyle issues (total was 511, now 512).
          +1 whitespace 0m 3s The patch has no lines that end in whitespace.
          +1 install 2m 16s mvn install still works.
          +1 eclipse:eclipse 0m 51s The patch built with eclipse:eclipse.
          +1 findbugs 2m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 25m 7s Tests failed in hadoop-common.
              75m 6s  



          Reason Tests
          Failed unit tests hadoop.ipc.TestProtoBufRpc
            hadoop.security.token.delegation.web.TestWebDelegationToken



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12751978/HADOOP-12325.005.test.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / feaf034
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7519/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7519/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7519/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7519/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 11m 8s There were no new javac warning messages. +1 javadoc 13m 21s There were no new javadoc warning messages. +1 release audit 0m 37s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 29s The applied patch generated 2 new checkstyle issues (total was 511, now 512). +1 whitespace 0m 3s The patch has no lines that end in whitespace. +1 install 2m 16s mvn install still works. +1 eclipse:eclipse 0m 51s The patch built with eclipse:eclipse. +1 findbugs 2m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 25m 7s Tests failed in hadoop-common.     75m 6s   Reason Tests Failed unit tests hadoop.ipc.TestProtoBufRpc   hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751978/HADOOP-12325.005.test.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / feaf034 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7519/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7519/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7519/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7519/console This message was automatically generated.
          Hide
          anu Anu Engineer added a comment -

          Akira Ajisaka Thanks for your review and changes to the test file. Please see my comments below

          1. Would you add a whitespace before "took " in the log message?

          fixed.

          2. After running the regression test locally, I can't see any logs about sleep RPC.

          On my machine if I open the file org.apache.hadoop.ipc.TestProtoBufRpc-output.txt in the sure-fire reports directory, I am able to see the following line.

          2015-08-24 10:52:16,713 WARN  ipc.Server (Server.java:logSlowRpcCalls(438)) - Slow RPC : sleep took 3004 milliseconds to process from client 10.0.1.35:57223
          

          Attaching a patch to verify that the slow call is logged. Now the test fails.

          With the new call

           long after = getLongCounter("RpcSlowCalls", rpcMetrics); 

          somehow the mocking layer is still returning the old snap-shotted value. I have modified the tests to call server layer directly and tests are now behaving as expected.

          Show
          anu Anu Engineer added a comment - Akira Ajisaka Thanks for your review and changes to the test file. Please see my comments below 1. Would you add a whitespace before "took " in the log message? fixed. 2. After running the regression test locally, I can't see any logs about sleep RPC. On my machine if I open the file org.apache.hadoop.ipc.TestProtoBufRpc-output.txt in the sure-fire reports directory, I am able to see the following line. 2015-08-24 10:52:16,713 WARN ipc.Server (Server.java:logSlowRpcCalls(438)) - Slow RPC : sleep took 3004 milliseconds to process from client 10.0.1.35:57223 Attaching a patch to verify that the slow call is logged. Now the test fails. With the new call long after = getLongCounter( "RpcSlowCalls" , rpcMetrics); somehow the mocking layer is still returning the old snap-shotted value. I have modified the tests to call server layer directly and tests are now behaving as expected.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 9s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 7m 58s There were no new javac warning messages.
          +1 javadoc 9m 52s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 7s The applied patch generated 2 new checkstyle issues (total was 511, now 512).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 1m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 49s Tests passed in hadoop-common.
              63m 22s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752053/HADOOP-12325.006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / b5ce87f
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7521/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7521/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7521/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7521/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 9m 52s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 7s The applied patch generated 2 new checkstyle issues (total was 511, now 512). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 49s Tests passed in hadoop-common.     63m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752053/HADOOP-12325.006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b5ce87f checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7521/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7521/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7521/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7521/console This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Anu Engineer updating the patch! The Jenkins result looks good to me. I will commit it shortly.
          Ignore the checkstyle issue "Variable 'rpcSlowCalls' must be private and have accessor methods." since it is inconsistent with the existing code.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Anu Engineer updating the patch! The Jenkins result looks good to me. I will commit it shortly. Ignore the checkstyle issue "Variable 'rpcSlowCalls' must be private and have accessor methods." since it is inconsistent with the existing code.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Anu Engineer for the contribution and Akira Ajisaka for the review.
          I've commit the change to trunk and branch-2.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Anu Engineer for the contribution and Akira Ajisaka for the review. I've commit the change to trunk and branch-2.
          Hide
          xyao Xiaoyu Yao added a comment -

          Also resolve HDFS-5180 as a dup of HADOOP-12325.

          Show
          xyao Xiaoyu Yao added a comment - Also resolve HDFS-5180 as a dup of HADOOP-12325 .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8345/)
          HADOOP-12325. RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36)

          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8345/ ) HADOOP-12325 . RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #305 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/305/)
          HADOOP-12325. RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #305 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/305/ ) HADOOP-12325 . RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #301 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/301/)
          HADOOP-12325. RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #301 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/301/ ) HADOOP-12325 . RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1034 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1034/)
          HADOOP-12325. RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1034 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1034/ ) HADOOP-12325 . RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2231 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2231/)
          HADOOP-12325. RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2231 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2231/ ) HADOOP-12325 . RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2250/)
          HADOOP-12325. RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2250/ ) HADOOP-12325 . RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #293 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/293/)
          HADOOP-12325. RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #293 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/293/ ) HADOOP-12325 . RPC Metrics : Add the ability track and log slow RPCs. Contributed by Anu Engineer (xyao: rev 48774d0a45d95557affbd6bbaf8035cc9575ef36) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Anu Engineer for the update. Late +1 from me. Thanks Xiaoyu Yao for reviewing and committing the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Anu Engineer for the update. Late +1 from me. Thanks Xiaoyu Yao for reviewing and committing the patch.
          Hide
          zhz Zhe Zhang added a comment -

          Sorry to reopen the JIRA. I think it is a good addition to branch-2.7 and want to test branch-2.7 patch.

          Show
          zhz Zhe Zhang added a comment - Sorry to reopen the JIRA. I think it is a good addition to branch-2.7 and want to test branch-2.7 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 37s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 6m 38s branch-2.7 passed
          +1 compile 6m 27s branch-2.7 passed with JDK v1.8.0_111
          +1 compile 7m 3s branch-2.7 passed with JDK v1.7.0_111
          +1 checkstyle 0m 29s branch-2.7 passed
          +1 mvnsite 0m 49s branch-2.7 passed
          +1 mvneclipse 0m 16s branch-2.7 passed
          -1 findbugs 1m 43s hadoop-common-project/hadoop-common in branch-2.7 has 3 extant Findbugs warnings.
          +1 javadoc 0m 47s branch-2.7 passed with JDK v1.8.0_111
          +1 javadoc 0m 57s branch-2.7 passed with JDK v1.7.0_111
          +1 mvninstall 0m 43s the patch passed
          +1 compile 6m 24s the patch passed with JDK v1.8.0_111
          +1 cc 6m 24s the patch passed
          +1 javac 6m 24s the patch passed
          +1 compile 6m 29s the patch passed with JDK v1.7.0_111
          -1 cc 6m 29s root-jdk1.7.0_111 with JDK v1.7.0_111 generated 1 new + 43 unchanged - 1 fixed = 44 total (was 44)
          +1 javac 6m 29s the patch passed
          -0 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 2 new + 456 unchanged - 1 fixed = 458 total (was 457)
          +1 mvnsite 0m 45s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          -1 whitespace 0m 0s The patch has 3528 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 1m 34s The patch 270 line(s) with tabs.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 45s the patch passed
          -1 javadoc 0m 41s hadoop-common-project_hadoop-common-jdk1.8.0_111 with JDK v1.8.0_111 generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
          -1 javadoc 0m 54s hadoop-common-project_hadoop-common-jdk1.7.0_111 with JDK v1.7.0_111 generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)
          -1 unit 20m 47s hadoop-common in the patch failed with JDK v1.7.0_111.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          100m 11s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.util.bloom.TestBloomFilters
          JDK v1.8.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration
          JDK v1.7.0_111 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.util.bloom.TestBloomFilters
          JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-12325
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835229/HADOOP-12325-branch-2.7.00.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc
          uname Linux 9ddfa6be1074 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / c05d701
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/diff-compile-cc-root-jdk1.7.0_111.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/whitespace-tabs.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_111.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 37s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 6m 38s branch-2.7 passed +1 compile 6m 27s branch-2.7 passed with JDK v1.8.0_111 +1 compile 7m 3s branch-2.7 passed with JDK v1.7.0_111 +1 checkstyle 0m 29s branch-2.7 passed +1 mvnsite 0m 49s branch-2.7 passed +1 mvneclipse 0m 16s branch-2.7 passed -1 findbugs 1m 43s hadoop-common-project/hadoop-common in branch-2.7 has 3 extant Findbugs warnings. +1 javadoc 0m 47s branch-2.7 passed with JDK v1.8.0_111 +1 javadoc 0m 57s branch-2.7 passed with JDK v1.7.0_111 +1 mvninstall 0m 43s the patch passed +1 compile 6m 24s the patch passed with JDK v1.8.0_111 +1 cc 6m 24s the patch passed +1 javac 6m 24s the patch passed +1 compile 6m 29s the patch passed with JDK v1.7.0_111 -1 cc 6m 29s root-jdk1.7.0_111 with JDK v1.7.0_111 generated 1 new + 43 unchanged - 1 fixed = 44 total (was 44) +1 javac 6m 29s the patch passed -0 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 2 new + 456 unchanged - 1 fixed = 458 total (was 457) +1 mvnsite 0m 45s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 3528 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 1m 34s The patch 270 line(s) with tabs. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 45s the patch passed -1 javadoc 0m 41s hadoop-common-project_hadoop-common-jdk1.8.0_111 with JDK v1.8.0_111 generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5) -1 javadoc 0m 54s hadoop-common-project_hadoop-common-jdk1.7.0_111 with JDK v1.7.0_111 generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) -1 unit 20m 47s hadoop-common in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 100m 11s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.util.bloom.TestBloomFilters JDK v1.8.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration JDK v1.7.0_111 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.util.bloom.TestBloomFilters JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-12325 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835229/HADOOP-12325-branch-2.7.00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc uname Linux 9ddfa6be1074 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / c05d701 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html cc https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/diff-compile-cc-root-jdk1.7.0_111.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/whitespace-tabs.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_111.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10896/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhz Zhe Zhang added a comment -

          I verified test failures and pushed to branch-2.7.

          Show
          zhz Zhe Zhang added a comment - I verified test failures and pushed to branch-2.7.

            People

            • Assignee:
              anu Anu Engineer
              Reporter:
              anu Anu Engineer
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development