[HADOOP-12348] MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
• Component/s: metrics
• Hadoop Flags: Reviewed
• Assignee: Zhihai Xu Assign to me
• Reporter: Zhihai Xu
• Created: 22/Aug/15 07:23
• Updated: 14/Sep/16 04:15
• Resolved: 11/Sep/15 22:22

Description

MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. MetricsSourceAdapter expects time unit millisecond for jmxCacheTTL but MetricsSystemImpl passes time unit second to MetricsSourceAdapter constructor.

        jmxCacheTS = Time.now() + jmxCacheTTL;
  /**
   * Current system time.  Do not use this to calculate a duration or interval
   * to sleep, because it will be broken by settimeofday.  Instead, use
   * monotonicNow.
   * @return current time in msec.
   */
  public static long now() {
    return System.currentTimeMillis();
  }

Issue Links

• breaks: HDFS-9067 o.a.h.hdfs.server.datanode.fsdataset.impl.TestLazyWriter is failing in trunk