Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12348

MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.

    Details

    • Hadoop Flags:
      Reviewed

      Description

      MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. MetricsSourceAdapter expects time unit millisecond for jmxCacheTTL but MetricsSystemImpl passes time unit second to MetricsSourceAdapter constructor.

              jmxCacheTS = Time.now() + jmxCacheTTL;
        /**
         * Current system time.  Do not use this to calculate a duration or interval
         * to sleep, because it will be broken by settimeofday.  Instead, use
         * monotonicNow.
         * @return current time in msec.
         */
        public static long now() {
          return System.currentTimeMillis();
        }
      
      1. HADOOP-12348.branch-2.patch
        5 kB
        zhihai xu
      2. HADOOP-12348.001.patch
        5 kB
        zhihai xu
      3. HADOOP-12348.000.patch
        3 kB
        zhihai xu

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 41s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 40s There were no new javac warning messages.
          +1 javadoc 9m 51s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 4s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 54s Tests passed in hadoop-common.
              62m 31s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752953/HADOOP-12348.000.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / e166c03
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7545/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7545/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7545/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 41s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 51s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 54s Tests passed in hadoop-common.     62m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752953/HADOOP-12348.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e166c03 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7545/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7545/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7545/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          Shouldn't jmxCacheTTL in MetricsSourceAdapter be a long instead of an int?

          Show
          rkanter Robert Kanter added a comment - Shouldn't jmxCacheTTL in MetricsSourceAdapter be a long instead of an int ?
          Hide
          zxu zhihai xu added a comment -

          thanks for the review Robert Kanter, That is a good suggestion. I attached a new patch HADOOP-12348.001.patch which addressed your comment. Please review it.

          Show
          zxu zhihai xu added a comment - thanks for the review Robert Kanter , That is a good suggestion. I attached a new patch HADOOP-12348 .001.patch which addressed your comment. Please review it.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 59s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 51s There were no new javac warning messages.
          +1 javadoc 10m 9s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 9s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 2s Tests passed in hadoop-common.
              63m 36s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753107/HADOOP-12348.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / e2c9b28
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7550/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7550/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7550/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 10m 9s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 9s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 2s Tests passed in hadoop-common.     63m 36s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753107/HADOOP-12348.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e2c9b28 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7550/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7550/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7550/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 49s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 48s There were no new javac warning messages.
          +1 javadoc 9m 56s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 12s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 34s Tests passed in hadoop-common.
              65m 40s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753113/HADOOP-12348.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / e2c9b28
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 49s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 56s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 12s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 34s Tests passed in hadoop-common.     65m 40s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753113/HADOOP-12348.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e2c9b28 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          +1 LGTM

          Show
          rkanter Robert Kanter added a comment - +1 LGTM
          Hide
          rkanter Robert Kanter added a comment -

          zhihai xu, it looks like this doesn't apply cleanly to branch-2. Can you take a look and make a branch-2 version of the patch?

          Show
          rkanter Robert Kanter added a comment - zhihai xu , it looks like this doesn't apply cleanly to branch-2. Can you take a look and make a branch-2 version of the patch?
          Hide
          zxu zhihai xu added a comment -

          Robert Kanter, Yes, you are right, I attached the corresponding patch HADOOP-12348.branch-2.patch for branch-2. thanks

          Show
          zxu zhihai xu added a comment - Robert Kanter , Yes, you are right, I attached the corresponding patch HADOOP-12348 .branch-2.patch for branch-2. thanks
          Hide
          rkanter Robert Kanter added a comment -

          Thanks Zhihai. Committed to trunk and branch-2!

          Show
          rkanter Robert Kanter added a comment - Thanks Zhihai. Committed to trunk and branch-2!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8438 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8438/)
          HADOOP-12348. MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8438 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8438/ ) HADOOP-12348 . MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          Hide
          zxu zhihai xu added a comment -

          thanks robert for reviewing and committing the patch!

          Show
          zxu zhihai xu added a comment - thanks robert for reviewing and committing the patch!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #381 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/381/)
          HADOOP-12348. MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #381 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/381/ ) HADOOP-12348 . MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1113 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1113/)
          HADOOP-12348. MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1113 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1113/ ) HADOOP-12348 . MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #375 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/375/)
          HADOOP-12348. MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #375 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/375/ ) HADOOP-12348 . MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #360 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/360/)
          HADOOP-12348. MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #360 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/360/ ) HADOOP-12348 . MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2323 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2323/)
          HADOOP-12348. MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2323 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2323/ ) HADOOP-12348 . MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2300 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2300/)
          HADOOP-12348. MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2300 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2300/ ) HADOOP-12348 . MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. (zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Cherrypicked this to branch-2.7.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Cherrypicked this to branch-2.7.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8804 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8804/)
          Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8804 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8804/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2608/)
          Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2608/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #679 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/679/)
          Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #679 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/679/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1403 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1403/)
          Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1403 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1403/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #667 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/667/)
          Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #667 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/667/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          ajisakaa Akira Ajisaka added a comment -

          When HADOOP-12348 is committed to branch-2.7, HDFS-9067 should be committed to branch-2.7 as well. In addition, HDFS-8144 should be cherry-picked before HDFS-9067.

          Show
          ajisakaa Akira Ajisaka added a comment - When HADOOP-12348 is committed to branch-2.7, HDFS-9067 should be committed to branch-2.7 as well. In addition, HDFS-8144 should be cherry-picked before HDFS-9067 .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #606 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/606/)
          Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #606 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/606/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2543 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2543/)
          Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2543 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2543/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          ajisakaa Akira Ajisaka added a comment -

          TestLazyPersistFiles is failing in branch-2.7 after backporting this issue.

          Running org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
          Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 241.331 sec <<< FAILURE! - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
          testFallbackToDiskFull(org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles)  Time elapsed: 1.153 sec  <<< FAILURE!
          java.lang.AssertionError: expected:<1> but was:<0>
          	at org.junit.Assert.fail(Assert.java:88)
          	at org.junit.Assert.failNotEquals(Assert.java:743)
          	at org.junit.Assert.assertEquals(Assert.java:118)
          	at org.junit.Assert.assertEquals(Assert.java:555)
          	at org.junit.Assert.assertEquals(Assert.java:542)
          	at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.LazyPersistTestCase.verifyRamDiskJMXMetric(LazyPersistTestCase.java:404)
          	at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles.testFallbackToDiskFull(TestLazyPersistFiles.java:164)
          
          
          Results :
          
          Failed tests: 
            TestLazyPersistFiles.testFallbackToDiskFull:164->LazyPersistTestCase.verifyRamDiskJMXMetric:404 expected:<1> but was:<0>
          
          Tests run: 24, Failures: 1, Errors: 0, Skipped: 0
          
          Show
          ajisakaa Akira Ajisaka added a comment - TestLazyPersistFiles is failing in branch-2.7 after backporting this issue. Running org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 241.331 sec <<< FAILURE! - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles testFallbackToDiskFull(org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles) Time elapsed: 1.153 sec <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.LazyPersistTestCase.verifyRamDiskJMXMetric(LazyPersistTestCase.java:404) at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles.testFallbackToDiskFull(TestLazyPersistFiles.java:164) Results : Failed tests: TestLazyPersistFiles.testFallbackToDiskFull:164->LazyPersistTestCase.verifyRamDiskJMXMetric:404 expected:<1> but was:<0> Tests run: 24, Failures: 1, Errors: 0, Skipped: 0
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka since it is merged to branch-2.7 then HDFS-9067 and HDFS-9073 also need to merge.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka since it is merged to branch-2.7 then HDFS-9067 and HDFS-9073 also need to merge.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Brahma Reddy Battula thank you for the notification. I'll backport them.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Brahma Reddy Battula thank you for the notification. I'll backport them.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Cherry-picked to 2.6.5 (trivial).

          Show
          sjlee0 Sangjin Lee added a comment - Cherry-picked to 2.6.5 (trivial).

            People

            • Assignee:
              zxu zhihai xu
              Reporter:
              zxu zhihai xu
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development