Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12348

MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. MetricsSourceAdapter expects time unit millisecond for jmxCacheTTL but MetricsSystemImpl passes time unit second to MetricsSourceAdapter constructor.

              jmxCacheTS = Time.now() + jmxCacheTTL;
        /**
         * Current system time.  Do not use this to calculate a duration or interval
         * to sleep, because it will be broken by settimeofday.  Instead, use
         * monotonicNow.
         * @return current time in msec.
         */
        public static long now() {
          return System.currentTimeMillis();
        }
      

      Attachments

        1. HADOOP-12348.000.patch
          3 kB
          Zhihai Xu
        2. HADOOP-12348.001.patch
          5 kB
          Zhihai Xu
        3. HADOOP-12348.branch-2.patch
          5 kB
          Zhihai Xu

        Issue Links

          Activity

            People

              zxu Zhihai Xu
              zxu Zhihai Xu
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: