Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12202

releasedocmaker drops missing component and assignee entries

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: HADOOP-12111
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: yetus
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      After HADOOP-11807, releasedocmaker is dropping missing component and assignee entries. It shouldn't drop entries, even if they are errors that lint mode will flag.

      1. HADOOP-12202.HADOOP-12111.00.patch
        2 kB
        Allen Wittenauer
      2. HADOOP-12202.HADOOP-12111.01.patch
        2 kB
        Allen Wittenauer

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2213 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2213/)
        HADOOP-12202. releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184)

        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2213 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2213/ ) HADOOP-12202 . releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184) dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #264 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/264/)
        HADOOP-12202. releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184)

        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #264 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/264/ ) HADOOP-12202 . releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184) dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/256/)
        HADOOP-12202. releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184)

        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/256/ ) HADOOP-12202 . releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184) dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2194 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2194/)
        HADOOP-12202. releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184)

        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2194 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2194/ ) HADOOP-12202 . releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184) dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #997 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/997/)
        HADOOP-12202. releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184)

        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #997 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/997/ ) HADOOP-12202 . releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184) dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #267 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/267/)
        HADOOP-12202. releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184)

        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #267 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/267/ ) HADOOP-12202 . releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184) dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8221 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8221/)
        HADOOP-12202. releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184)

        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8221 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8221/ ) HADOOP-12202 . releasedocmaker drops missing component and assignee entries (aw) (wang: rev d7697831e3b24bec149990feed819e7d96f78184) dev-support/releasedocmaker.py
        Hide
        andrew.wang Andrew Wang added a comment -

        I pulled this down to trunk/branch-2, thanks all.

        Show
        andrew.wang Andrew Wang added a comment - I pulled this down to trunk/branch-2, thanks all.
        Hide
        aw Allen Wittenauer added a comment -

        I've reverted HADOOP-11807 from trunk, so I'm going to close this as resolved now.

        Show
        aw Allen Wittenauer added a comment - I've reverted HADOOP-11807 from trunk, so I'm going to close this as resolved now.
        Hide
        aw Allen Wittenauer added a comment -

        (ha. sorry hadoop qa, i beat you to it.)

        Show
        aw Allen Wittenauer added a comment - (ha. sorry hadoop qa, i beat you to it.)
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744059/HADOOP-12202.HADOOP-12111.01.patch
        Optional Tests  
        git revision HADOOP-12111 / adbacf7
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7184/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744059/HADOOP-12202.HADOOP-12111.01.patch Optional Tests   git revision HADOOP-12111 / adbacf7 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7184/console This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        Thanks for the quick review.

        Committed to branch.

        I guess we need to figure out what to do about hadoop trunk, but I'm inclined to just revert the last patch to it without the lint mode.

        Show
        aw Allen Wittenauer added a comment - Thanks for the quick review. Committed to branch. I guess we need to figure out what to do about hadoop trunk, but I'm inclined to just revert the last patch to it without the lint mode.
        Hide
        cnauroth Chris Nauroth added a comment -

        I blame the code reviewer who +1'd it earlier.

        +1 for v01. Thanks for fixing this.

        I just noticed that releasedocmaker.py is using a mix of 2-space and 4-space indentation. I filed HADOOP-12204 as a minor follow-up jira to clean it up.

        Show
        cnauroth Chris Nauroth added a comment - I blame the code reviewer who +1'd it earlier. +1 for v01. Thanks for fixing this. I just noticed that releasedocmaker.py is using a mix of 2-space and 4-space indentation. I filed HADOOP-12204 as a minor follow-up jira to clean it up.
        Hide
        aw Allen Wittenauer added a comment -

        -01:

        • fix a bug where files that failed lint got deleted, even when running in non-lint mode
        Show
        aw Allen Wittenauer added a comment - -01: fix a bug where files that failed lint got deleted, even when running in non-lint mode
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744035/HADOOP-12202.HADOOP-12111.00.patch
        Optional Tests  
        git revision HADOOP-12111 / 0d7a708
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7181/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744035/HADOOP-12202.HADOOP-12111.00.patch Optional Tests   git revision HADOOP-12111 / 0d7a708 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7181/console This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        I've reverted 0d7a70857552a74b60de22773bea5ea47f6ad2a7 .

        Show
        aw Allen Wittenauer added a comment - I've reverted 0d7a70857552a74b60de22773bea5ea47f6ad2a7 .
        Hide
        aw Allen Wittenauer added a comment -

        There's a bug in this that I missed. Not my day, today.

        Show
        aw Allen Wittenauer added a comment - There's a bug in this that I missed. Not my day, today.
        Hide
        aw Allen Wittenauer added a comment -

        Anyway, committed to yetus. Thanks!

        Show
        aw Allen Wittenauer added a comment - Anyway, committed to yetus. Thanks!
        Hide
        aw Allen Wittenauer added a comment -

        OK, trunk requires a different patch because it is missing some fixes from yetus.

        Show
        aw Allen Wittenauer added a comment - OK, trunk requires a different patch because it is missing some fixes from yetus.
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for the patch. Thanks, Allen!

        Show
        cnauroth Chris Nauroth added a comment - +1 for the patch. Thanks, Allen!
        Hide
        aw Allen Wittenauer added a comment -

        -00:

        • fix lint mode to work with multiple versions correctly
        • re-order how lint mode gathers errors
        • fix the missing data problems
        Show
        aw Allen Wittenauer added a comment - -00: fix lint mode to work with multiple versions correctly re-order how lint mode gathers errors fix the missing data problems

          People

          • Assignee:
            aw Allen Wittenauer
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development