Details

      Description

      • check for missing components (error)
      • check for missing assignee (error)
      • check for common version problems (warning)
      • add an error message for missing release notes
      1. HADOOP-11807.001.patch
        3 kB
        ramtin
      2. HADOOP-11807.002.patch
        3 kB
        ramtin
      3. HADOOP-11807.003.patch
        4 kB
        ramtin
      4. HADOOP-11807.004.patch
        6 kB
        ramtin
      5. HADOOP-11807.005.patch
        5 kB
        ramtin

        Activity

        Hide
        ramtinb ramtin added a comment -

        I am thinking of the following JQL for finding errors:

        project in (HADOOP,HDFS,MAPREDUCE,YARN) and fixVersion = xxx and resolution = Fixed and (component = EMPTY or assignee in (EMPTY) or "Release Note" is EMPTY)
        

        Not sure how to invoke the lint mode

        • Manually call the python script by --lintmode param and see the result in the console
        • Run it through maven by adding a new goal and see the result in the console
        • Save the output as ERRORS.md file and then generate html based on this markdown file
        Show
        ramtinb ramtin added a comment - I am thinking of the following JQL for finding errors: project in (HADOOP,HDFS,MAPREDUCE,YARN) and fixVersion = xxx and resolution = Fixed and (component = EMPTY or assignee in (EMPTY) or "Release Note" is EMPTY) Not sure how to invoke the lint mode Manually call the python script by --lintmode param and see the result in the console Run it through maven by adding a new goal and see the result in the console Save the output as ERRORS.md file and then generate html based on this markdown file
        Hide
        aw Allen Wittenauer added a comment -

        With the exception of maybe the version string checks, no extra JQL should be required. releasedocmaker already does the JQL and fills in the fields of python data structure. lint mode is really just going through that precomputed data structure and reporting problems.

        We don't want it part of the maven build; this mode needs to be part of the create-release script instead, because that's when it matters. So errors should not be markdown format, but instead printed to the screen like the current release note warning message. lint mode should exit with failure on errors so that it can fail the create-release script.

        • - version string checks are things like having two numeric versions assigned. This isn't a fatal error, but definitely needs for the release manager to investigate. Anyway, IIRC, the query does get all the versions assigned for that issue, even beyond the one requested.
        Show
        aw Allen Wittenauer added a comment - With the exception of maybe the version string checks , no extra JQL should be required. releasedocmaker already does the JQL and fills in the fields of python data structure. lint mode is really just going through that precomputed data structure and reporting problems. We don't want it part of the maven build; this mode needs to be part of the create-release script instead, because that's when it matters. So errors should not be markdown format, but instead printed to the screen like the current release note warning message. lint mode should exit with failure on errors so that it can fail the create-release script. - version string checks are things like having two numeric versions assigned. This isn't a fatal error, but definitely needs for the release manager to investigate. Anyway, IIRC, the query does get all the versions assigned for that issue, even beyond the one requested.
        Hide
        sekikn Kengo Seki added a comment -

        Hi ramtin, your patch seems to work fine. I have some comments:

        • checkMissingComponent()
          • It can be simplified like below. checkMissingAssignee() is also the same.
            def checkMissingComponent(self):
              return len(self.fields['components']) < 1 
            
        • checkMissingAssignee()
          • PEP 8 says "Comparisons to singletons like None should always be done with is or is not, never the equality operators".
            "... is not None" is more desirable than "... != None" (the original source has the same problem).
        • checkVersionString()
          • re.match() applies the pattern at the start of the string, so '^' at the head of the pattern can be removed.
            The outermost and first inner parentheses, and '.*$' may be also unnecessary.
        • main()
          • Some typos (variable erorrCount, string "componenet")
          • It may be better that errorCount and warningCount are formatted as integers, not as strings
          • I think os._exit() is not so popular and sys.exit() is preferred in general.
        Show
        sekikn Kengo Seki added a comment - Hi ramtin , your patch seems to work fine. I have some comments: checkMissingComponent() It can be simplified like below. checkMissingAssignee() is also the same. def checkMissingComponent(self): return len(self.fields['components']) < 1 checkMissingAssignee() PEP 8 says "Comparisons to singletons like None should always be done with is or is not, never the equality operators". "... is not None" is more desirable than "... != None" (the original source has the same problem). checkVersionString() re.match() applies the pattern at the start of the string, so '^' at the head of the pattern can be removed. The outermost and first inner parentheses, and '.*$' may be also unnecessary. main() Some typos (variable erorrCount, string "componenet") It may be better that errorCount and warningCount are formatted as integers, not as strings I think os._exit() is not so popular and sys.exit() is preferred in general.
        Hide
        ramtinb ramtin added a comment -

        Thank you Kengo Seki for your time to review the patch

        • checkMissingComponent()
          The current code is more readable and similar to other existing functions
        • checkMissingAssignee()
          I changed != None to is not None
        • checkVersionString()
          I think having ^ and $ help easily understand regular expression pattern
        • main()
          I changed the code
        Show
        ramtinb ramtin added a comment - Thank you Kengo Seki for your time to review the patch checkMissingComponent() The current code is more readable and similar to other existing functions checkMissingAssignee() I changed != None to is not None checkVersionString() I think having ^ and $ help easily understand regular expression pattern main() I changed the code
        Hide
        aw Allen Wittenauer added a comment -

        We need to protect the exit failure with a flag on the command line. During "normal" builds, it's ok if releasedocmaker throws these errors/warnings. But when it is/will be run as part of create-release, it needs to fail then to let the RM know that there are issues.

        Show
        aw Allen Wittenauer added a comment - We need to protect the exit failure with a flag on the command line. During "normal" builds, it's ok if releasedocmaker throws these errors/warnings. But when it is/will be run as part of create-release, it needs to fail then to let the RM know that there are issues.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
        -1 whitespace 0m 6s The patch has 42 line(s) that end in whitespace. Use git apply --whitespace=fix.
            0m 26s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731342/HADOOP-11807.002.patch
        Optional Tests  
        git revision trunk / cd6b26c
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6544/artifact/patchprocess/whitespace.txt
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6544/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. -1 whitespace 0m 6s The patch has 42 line(s) that end in whitespace. Use git apply --whitespace=fix.     0m 26s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731342/HADOOP-11807.002.patch Optional Tests   git revision trunk / cd6b26c whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6544/artifact/patchprocess/whitespace.txt Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6544/console This message was automatically generated.
        Hide
        ramtinb ramtin added a comment -

        Attached a new patch for protecting the exit failure during normal build.

        Show
        ramtinb ramtin added a comment - Attached a new patch for protecting the exit failure during normal build.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 7s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 28s There were no new javac warning messages.
        +1 javadoc 11m 33s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 44s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 common tests 26m 49s Tests passed in hadoop-common.
            64m 41s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12732277/HADOOP-11807.003.patch
        Optional Tests javadoc javac unit
        git revision trunk / f4e2b3c
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6663/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6663/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6663/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 28s There were no new javac warning messages. +1 javadoc 11m 33s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 44s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 common tests 26m 49s Tests passed in hadoop-common.     64m 41s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732277/HADOOP-11807.003.patch Optional Tests javadoc javac unit git revision trunk / f4e2b3c hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6663/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6663/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6663/console This message was automatically generated.
        Hide
        sekikn Kengo Seki added a comment -

        "Tests included" failure will disappear if HADOOP-11978 is resolved.

        Show
        sekikn Kengo Seki added a comment - "Tests included" failure will disappear if HADOOP-11978 is resolved.
        Hide
        sekikn Kengo Seki added a comment -

        ramtin, sorry for late response and thank you for your work.

        • As for my previous comment, the new patch almost looks good to me. Just one more comment, would you replace "== None" and "!= None" in the existing code with "is None" and "is not None"?
        • If there is an error, the new script fails correctly in non-normal mode, but partially generated files remain. I think it is better to defer output or clean them up.
        Show
        sekikn Kengo Seki added a comment - ramtin , sorry for late response and thank you for your work. As for my previous comment, the new patch almost looks good to me. Just one more comment, would you replace "== None" and "!= None" in the existing code with "is None" and "is not None"? If there is an error, the new script fails correctly in non-normal mode, but partially generated files remain. I think it is better to defer output or clean them up.
        Hide
        ramtinb ramtin added a comment -

        Thank you Kengo Seki for review the patch, I attached a new patch regarding to your comment.

        Show
        ramtinb ramtin added a comment - Thank you Kengo Seki for review the patch, I attached a new patch regarding to your comment.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 35s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 common tests 22m 28s Tests passed in hadoop-common.
            56m 46s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735376/HADOOP-11807.004.patch
        Optional Tests javadoc javac unit
        git revision trunk / 500a1d9
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6828/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6828/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6828/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 common tests 22m 28s Tests passed in hadoop-common.     56m 46s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735376/HADOOP-11807.004.patch Optional Tests javadoc javac unit git revision trunk / 500a1d9 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6828/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6828/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6828/console This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -
        • I'd really prefer what is currently the '--normal' mode to be the default and the fail-on-problems mode to be specifically triggered via '--lint'. It's going to be much more common to let the errors happen/be less strict about them vs. the stricter mode. (I'd push this into the ideals of Positive Programming--tests and code should be built around trues rather than falses.)
        • The version check error should really be if there are two or more numeric versions in a JIRA. For example, "./releasedocmaker.py --version HDFS-7285" is completely valid if I'm building release notes against that branch.
        Show
        aw Allen Wittenauer added a comment - I'd really prefer what is currently the '--normal' mode to be the default and the fail-on-problems mode to be specifically triggered via '--lint'. It's going to be much more common to let the errors happen/be less strict about them vs. the stricter mode. (I'd push this into the ideals of Positive Programming--tests and code should be built around trues rather than falses.) The version check error should really be if there are two or more numeric versions in a JIRA. For example, "./releasedocmaker.py --version HDFS-7285 " is completely valid if I'm building release notes against that branch.
        Hide
        ramtinb ramtin added a comment -

        Before I provide a new patch I just want to double check,

        • The script only failed when is called by '--lint' param.
        • Currently version check throws Warning and "./releasedocmaker.py --version HDFS-7285" is failed because of "missing component" Errors.
          So you are looking checkVersionString function only check "Fix Version/s" filed for not having more than one value and not be "None".
        Show
        ramtinb ramtin added a comment - Before I provide a new patch I just want to double check, The script only failed when is called by '--lint' param. Currently version check throws Warning and "./releasedocmaker.py --version HDFS-7285 " is failed because of "missing component" Errors. So you are looking checkVersionString function only check "Fix Version/s" filed for not having more than one value and not be "None".
        Hide
        ramtinb ramtin added a comment -

        New patch

        • Show error/warning messages and fail when only the script is called by "--lint" param.
        • checkVersionString accept both 2.7.0 and HDFS-7285 format.
        Show
        ramtinb ramtin added a comment - New patch Show error/warning messages and fail when only the script is called by "--lint" param. checkVersionString accept both 2.7.0 and HDFS-7285 format.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 18s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736285/HADOOP-11807.005.patch
        Optional Tests  
        git revision trunk / 6aec13c
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6872/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736285/HADOOP-11807.005.patch Optional Tests   git revision trunk / 6aec13c Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6872/console This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        +1 committed to trunk and to HADOOP-12111 branch.

        Thanks!

        Show
        aw Allen Wittenauer added a comment - +1 committed to trunk and to HADOOP-12111 branch. Thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8077 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8077/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8077 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8077/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/242/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/242/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #972 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/972/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #972 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/972/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/231/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/231/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2170 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2170/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2170 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2170/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/240/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/240/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2188 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2188/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2188 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2188/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (aw: rev 79ed0f959ffc490414ca56a73e026500c24e7078) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        aw Allen Wittenauer added a comment -

        I'm going to revert this from trunk, since it broke some things. We're keeping it in HADOOP-12111 since we've fixed those and other problems in releasedocmaker.

        Show
        aw Allen Wittenauer added a comment - I'm going to revert this from trunk, since it broke some things. We're keeping it in HADOOP-12111 since we've fixed those and other problems in releasedocmaker.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8131 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8131/)
        Revert "HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8131 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8131/ ) Revert " HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/)
        Revert "HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/ ) Revert " HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #981 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/981/)
        Revert "HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #981 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/981/ ) Revert " HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/239/)
        Revert "HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/239/ ) Revert " HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2178/)
        Revert "HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2178/ ) Revert " HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #249 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/249/)
        Revert "HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #249 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/249/ ) Revert " HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2197 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2197/)
        Revert "HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2197 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2197/ ) Revert " HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw)" (aw: rev 98e59261b7fb6f9d6d10a5c897f62222da7d2a1f) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        andrew.wang Andrew Wang added a comment -

        I pulled this down to trunk/branch-2, thanks all.

        Show
        andrew.wang Andrew Wang added a comment - I pulled this down to trunk/branch-2, thanks all.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8221 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8221/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8221 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8221/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #267 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/267/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #267 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/267/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #997 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/997/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #997 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/997/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2194 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2194/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2194 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2194/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/256/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c)

        • dev-support/releasedocmaker.py
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/256/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c) dev-support/releasedocmaker.py hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #264 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/264/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #264 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/264/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2213 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2213/)
        HADOOP-11807. add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/releasedocmaker.py
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2213 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2213/ ) HADOOP-11807 . add a lint mode to releasedocmaker (ramtin via aw) (wang: rev 098ba450cc98475b84d60bb5ac3bd7b558b2a67c) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/releasedocmaker.py

          People

          • Assignee:
            ramtinb ramtin
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development