Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11869

Suppress ParameterNumber checkstyle violations for overridden methods

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-alpha4
    • None
    • None
    • Reviewed

    Description

      There seem to be a lot of arcane errors being caused by the checkstyle rules/script. Real issues tend to be buried in this noise. Some examples :

      1. "Line is longer than 80 characters" - this shows up even for cases like import statements, package names
      2. "Missing a Javadoc comment." - for every private member including cases like "Configuration conf".

      Having rules like these will result in a large number of pre-commit job failures. We should fine tune the rules used for checkstyle.

      Attachments

        1. HADOOP-11869.ParameterNumber.patch
          0.7 kB
          Jonathan Turner Eagles

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jeagles Jonathan Turner Eagles
            sidharta-s Sidharta Seethana
            Votes:
            0 Vote for this issue
            Watchers:
            17 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment