Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11866

increase readability and reliability of checkstyle, shellcheck, and whitespace reports

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      HADOOP-11746 supports listing of the lines which has trailing white spaces but doesn't inform patch line number. Without this report output will not be of much help as in most cases it reports blank lines. Also for the first timers it would be difficult to understand the output check style script hence adding an header

      1. HADOOP-11866.20150422-1.patch
        0.6 kB
        Naganarasimha G R
      2. HADOOP-11866.20150423-1.patch
        2 kB
        Naganarasimha G R
      3. HADOOP-11866.20150427-1.patch
        8 kB
        Naganarasimha G R
      4. HADOOP-11866-05.patch
        13 kB
        Allen Wittenauer
      5. HADOOP-11866-06.patch
        16 kB
        Allen Wittenauer
      6. HADOOP-11866-07.patch
        17 kB
        Allen Wittenauer
      7. HADOOP-11866-08.patch
        17 kB
        Allen Wittenauer
      8. HADOOP-11866-checkstyle.patch
        7 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          wheat9 Haohui Mai added a comment -

          Why using a simple grep (e.g. egrep "^+.* +$" is insufficient?

          Show
          wheat9 Haohui Mai added a comment - Why using a simple grep (e.g. egrep "^+.* +$" is insufficient?
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          attaching a patch

          Show
          Naganarasimha Naganarasimha G R added a comment - attaching a patch
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          hi Haohui Mai
          current output in one of my jira
          https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/whitespace.txt

          I would like it to be

          35:+
          98:+ * be invoked. As RM will collect the node labels from NM through
          120:+ *
          163:+
          187:+
          284:+
          315:+ RMAuditLogger.logFailure(user, operation, "",
          326:+ RMAuditLogger.logFailure(user, operation, "",
          793:+
          839:+

          ur opinion ?

          Show
          Naganarasimha Naganarasimha G R added a comment - hi Haohui Mai current output in one of my jira https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/whitespace.txt I would like it to be 35:+ 98:+ * be invoked. As RM will collect the node labels from NM through 120:+ * 163:+ 187:+ 284:+ 315:+ RMAuditLogger.logFailure(user, operation, "", 326:+ RMAuditLogger.logFailure(user, operation, "", 793:+ 839:+ ur opinion ?
          Hide
          busbey Sean Busbey added a comment -

          please also give file names where the whitespace including lines are.

          Show
          busbey Sean Busbey added a comment - please also give file names where the whitespace including lines are.
          Hide
          wheat9 Haohui Mai added a comment -

          I believe that the jenkins output should only contain important information that requires developers to look at in a case by case basis. I'm yet to see the value of printing out how to fix the whitespace as it's unlikely that developers will fix all the whitespace issue manually.

          To fix all the whitespace issue automatically, you can apply the patch with git apply --whitespace=fix and create a new patch based on the result.

          Show
          wheat9 Haohui Mai added a comment - I believe that the jenkins output should only contain important information that requires developers to look at in a case by case basis. I'm yet to see the value of printing out how to fix the whitespace as it's unlikely that developers will fix all the whitespace issue manually. To fix all the whitespace issue automatically, you can apply the patch with git apply --whitespace=fix and create a new patch based on the result.
          Hide
          busbey Sean Busbey added a comment -

          How about a list of impacted file names and a suggestion to us git apply --whitespace=fix to make a clean version then? that sounds wonderful, presuming verifying the fix is straight forward.

          Show
          busbey Sean Busbey added a comment - How about a list of impacted file names and a suggestion to us git apply --whitespace=fix to make a clean version then? that sounds wonderful, presuming verifying the fix is straight forward.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the comments Haohui Mai & Sean Busbey,
          +1 for suggestion in the output file, as many like me might not be aware of git apply --whitespace=fix option,
          IMO If it was small number of white space issues then git apply --whitespace=fix would be little more work than manually correcting, so i would prefer to have line numbers to be printed so that i can do the required changes faster.
          Sean Busbey, IMHO just the filename is not so useful, file name and followed with the actual lines number within that file would be useful else line numbers based on the patch would be better. IMO later approach was simpler and better, hence updated the patch with the later approach and header for checkstyle output

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the comments Haohui Mai & Sean Busbey , +1 for suggestion in the output file, as many like me might not be aware of git apply --whitespace=fix option, IMO If it was small number of white space issues then git apply --whitespace=fix would be little more work than manually correcting, so i would prefer to have line numbers to be printed so that i can do the required changes faster. Sean Busbey , IMHO just the filename is not so useful, file name and followed with the actual lines number within that file would be useful else line numbers based on the patch would be better. IMO later approach was simpler and better, hence updated the patch with the later approach and header for checkstyle output
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6176/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6176/console in case of problems.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Allen Wittenauer &Haohui Mai,
          Any further suggestions for this patch ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Allen Wittenauer & Haohui Mai , Any further suggestions for this patch ?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace.
          +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
          0 shellcheck 0m 15s Shellcheck was not available.
              0m 17s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727663/HADOOP-11866.20150423-1.patch
          Optional Tests shellcheck
          git revision trunk / 78c6b46
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6176/artifact/patchprocess/whitespace.txt
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6176/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 15s Shellcheck was not available.     0m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727663/HADOOP-11866.20150423-1.patch Optional Tests shellcheck git revision trunk / 78c6b46 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6176/artifact/patchprocess/whitespace.txt Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6176/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/console in case of problems.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 00s dev-support patch detected.
          0 pre-patch 0m 00s Pre-patch trunk compilation is healthy.
          0 @author 0m 00s Skipping @author checks as test-patch has been patched.
          -1 whitespace 0m 00s The patch has 1 line(s) that end in whitespace.
          +1 release audit 0m 11s The applied patch does not increase the total number of release audit warnings.
          -1 shellcheck 0m 02s The applied patch generated 1 new shellcheck (v0.3.6) issues (total was 45, now 46).
              0m 17s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727663/HADOOP-11866.20150423-1.patch
          Optional Tests shellcheck
          git revision trunk / 78c6b46
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/artifact/patchprocess/whitespace.txt
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/artifact/patchprocess/diffpatchshellcheck.txt
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 00s dev-support patch detected. 0 pre-patch 0m 00s Pre-patch trunk compilation is healthy. 0 @author 0m 00s Skipping @author checks as test-patch has been patched. -1 whitespace 0m 00s The patch has 1 line(s) that end in whitespace. +1 release audit 0m 11s The applied patch does not increase the total number of release audit warnings. -1 shellcheck 0m 02s The applied patch generated 1 new shellcheck (v0.3.6) issues (total was 45, now 46).     0m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727663/HADOOP-11866.20150423-1.patch Optional Tests shellcheck git revision trunk / 78c6b46 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/artifact/patchprocess/whitespace.txt shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/artifact/patchprocess/diffpatchshellcheck.txt Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          A few things:

          a) shellcheck is complaining about the multi-line echos redirecting to a file. It's generally preferred now to group them into a subshell and then redirect the shell. But I think the message should really be directed to the patch author in the footer table via an add_footer_table call.

          b) I think it'd be worthwhile to do quite a bit more hacking on the checkstyle module. When I looked at checkstyle, I was clearly asleep. There are actually quite a few things we can do to make this much more usable:

          • Switch from the aggregate report to a per module report. (This should also reduce the run time and it makes the other things we should do easier.)
          • Rip out the python code. We aren't going to need it anymore.
          • Add -Dcheckstyle.output.file=blah and -Dcheckstyle.output.format=plain to both mvn command lines, where blah is the file we want for that module for that part of the run. Strip a large chunk of the leading pathname ($ {BASEDIR} at a minimum, but probably all of ${BASEDIR}

            and modulename, since the file is already broken up by module).

          • Now we can perform diffs and such like we do for some of the other tests (see shellcheck, for example). This has the advantage of pointing out the exact error on the exact line that broke without having to deal with giant HTML files.
          Show
          aw Allen Wittenauer added a comment - A few things: a) shellcheck is complaining about the multi-line echos redirecting to a file. It's generally preferred now to group them into a subshell and then redirect the shell. But I think the message should really be directed to the patch author in the footer table via an add_footer_table call. b) I think it'd be worthwhile to do quite a bit more hacking on the checkstyle module. When I looked at checkstyle, I was clearly asleep. There are actually quite a few things we can do to make this much more usable: Switch from the aggregate report to a per module report. (This should also reduce the run time and it makes the other things we should do easier.) Rip out the python code. We aren't going to need it anymore. Add -Dcheckstyle.output.file=blah and -Dcheckstyle.output.format=plain to both mvn command lines, where blah is the file we want for that module for that part of the run. Strip a large chunk of the leading pathname ($ {BASEDIR} at a minimum, but probably all of ${BASEDIR} and modulename, since the file is already broken up by module). Now we can perform diffs and such like we do for some of the other tests (see shellcheck, for example). This has the advantage of pointing out the exact error on the exact line that broke without having to deal with giant HTML files.
          Hide
          aw Allen Wittenauer added a comment -

          -checkstyle.patch:

          • Here's a modified version of the checkstyle.sh plug-in. It still needs some work, but gets us most of the way there.

          A few things:

          • It looks like output.file doesn't actually work. So I opted to play games with the console output.
          • New method written in shell to determine if there are actually new issues. I think it works?
          • Showing what is actually different is significantly harder than I thought it would be because of magically changing line numbers. An sdiff -s output might be better here.

          Anyway, some code to play with and fill in the gaps if you want.

          Show
          aw Allen Wittenauer added a comment - -checkstyle.patch: Here's a modified version of the checkstyle.sh plug-in. It still needs some work, but gets us most of the way there. A few things: It looks like output.file doesn't actually work. So I opted to play games with the console output. New method written in shell to determine if there are actually new issues. I think it works? Showing what is actually different is significantly harder than I thought it would be because of magically changing line numbers. An sdiff -s output might be better here. Anyway, some code to play with and fill in the gaps if you want.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6182/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6182/console in case of problems.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings.
          0 shellcheck 0m 14s Shellcheck was not available.
              0m 18s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728212/HADOOP-11866-checkstyle.patch
          Optional Tests shellcheck
          git revision trunk / 22b70e7
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6182/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 14s Shellcheck was not available.     0m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728212/HADOOP-11866-checkstyle.patch Optional Tests shellcheck git revision trunk / 22b70e7 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6182/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          (p.s., some of the ideas in that thought balloon patch should probably be ported over to shellcheck.sh.)

          Show
          aw Allen Wittenauer added a comment - (p.s., some of the ideas in that thought balloon patch should probably be ported over to shellcheck.sh.)
          Hide
          aw Allen Wittenauer added a comment -

          here, this version actually somewhat works.

          Show
          aw Allen Wittenauer added a comment - here, this version actually somewhat works.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6185/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6185/console in case of problems.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
          0 shellcheck 0m 15s Shellcheck was not available.
              0m 18s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728274/HADOOP-11866-checkstyle.patch
          Optional Tests shellcheck
          git revision trunk / 8b69c82
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6185/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 15s Shellcheck was not available.     0m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728274/HADOOP-11866-checkstyle.patch Optional Tests shellcheck git revision trunk / 8b69c82 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6185/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Allen Wittenauer for the work on improving check-style output. Uploading a merged patch containing changes for white-space and check-style.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Allen Wittenauer for the work on improving check-style output. Uploading a merged patch containing changes for white-space and check-style.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6193/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6193/console in case of problems.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
          0 shellcheck 0m 19s Shellcheck was not available.
              0m 21s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728379/HADOOP-11866.20150427-1.patch
          Optional Tests shellcheck
          git revision trunk / 5e67c4d
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6193/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 19s Shellcheck was not available.     0m 21s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728379/HADOOP-11866.20150427-1.patch Optional Tests shellcheck git revision trunk / 5e67c4d Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6193/console This message was automatically generated.
          Hide
          jeagles Jonathan Eagles added a comment -

          If further filter for checkstyle is needed beyond the current patch, we could consider the hunk line number ranges in the patch itself (Not the patch file itself, but the effective patch -> the diff after patch apply). Only checkstyle warnings within the lines should be considered to flag a patch as not checkstyle compliant. Using the same filter, a filtered version of the checkstyle output could be the artifact that will be used to eliminate to non-compliant code.

          Show
          jeagles Jonathan Eagles added a comment - If further filter for checkstyle is needed beyond the current patch, we could consider the hunk line number ranges in the patch itself (Not the patch file itself, but the effective patch -> the diff after patch apply). Only checkstyle warnings within the lines should be considered to flag a patch as not checkstyle compliant. Using the same filter, a filtered version of the checkstyle output could be the artifact that will be used to eliminate to non-compliant code.
          Hide
          aw Allen Wittenauer added a comment -

          There likely will be. The checkstyle code in this patch does an extremely naïve match against the diff file. One will get a lot more output than may be necessary, but at least something more meaningful will show up.

          I was really trying to avoid parsing the patch file, but I guess we may not have much of a choice.

          Show
          aw Allen Wittenauer added a comment - There likely will be. The checkstyle code in this patch does an extremely naïve match against the diff file. One will get a lot more output than may be necessary, but at least something more meaningful will show up. I was really trying to avoid parsing the patch file, but I guess we may not have much of a choice.
          Hide
          jeagles Jonathan Eagles added a comment -

          Let's get this in and then we can have a follow up to address that hurtle.

          Show
          jeagles Jonathan Eagles added a comment - Let's get this in and then we can have a follow up to address that hurtle.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Jonathan Eagles & Allen Wittenauer,
          can we get this patch in and address other check-style issues in either HADOOP-11869 or HADOOP-11778 ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Jonathan Eagles & Allen Wittenauer , can we get this patch in and address other check-style issues in either HADOOP-11869 or HADOOP-11778 ?
          Hide
          aw Allen Wittenauer added a comment -

          I've been playing with this patch for accuracy over the past 24 hours. In many ways the naïve approach is even worse and not very accurate.

          If Naganarasimha G R doesn't mind, I'd like to take this JIRA over and update (potentially) all of the plug-ins to take advantage of some new code I've been toying with based upon Jonathan Eagles's suggestion.

          Show
          aw Allen Wittenauer added a comment - I've been playing with this patch for accuracy over the past 24 hours. In many ways the naïve approach is even worse and not very accurate. If Naganarasimha G R doesn't mind, I'd like to take this JIRA over and update (potentially) all of the plug-ins to take advantage of some new code I've been toying with based upon Jonathan Eagles 's suggestion.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Allen Wittenauer,
          I don't mind you taking over this jira, but i feel its annoying to see patches having the white space issues and not able to make use of the output & i seldom remember the git apply --whitespace=fix option. So try to get these small changes as part of your useful modifications in as early as possible

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Allen Wittenauer , I don't mind you taking over this jira, but i feel its annoying to see patches having the white space issues and not able to make use of the output & i seldom remember the git apply --whitespace=fix option. So try to get these small changes as part of your useful modifications in as early as possible
          Hide
          aw Allen Wittenauer added a comment -

          -05:

          • added a new support file for plugins that gives a listing of files and lines changed after the patch is applied
          • fixed an issue with $ {CHANGED_FILES}

            where extra cruft from the patch was being added due to differences in how patches are formatted. This may have resulted in some patches having tests run twice or even skipped.

          • checkstyle errors are now calculated per module. this speeds up this particular test quite a bit and means that it is less likely to NPE for certain classes of patches.
            *checkstyle now shows errors before, errors after, and the filename + line number where the new errors are being reported. Unfortunately, this uses GNU diff extensions.
          • whitespace now prints the name and line of the source file that has the whitespace
          • fixed all of the shellcheck errors. newer versions of shellcheck now understand line continuations! So all those false reports triggered by awk are now gone!

          NOTE: I have a suspicion that the current checkstyle code in test-patch is actually reporting the wrong number. Patches can trigger checkstyle errors that appear outside of the lines that are patched. MAPREDUCE-6165, for example, has only 1 reported, but there are actually 8 new ones. (4 were removed by the patch.)

          Given the aggravation, etc, these issues are causing, this should probably be committed ASAP. If someone could do a quick test+review, that'd be great.

          Show
          aw Allen Wittenauer added a comment - -05: added a new support file for plugins that gives a listing of files and lines changed after the patch is applied fixed an issue with $ {CHANGED_FILES} where extra cruft from the patch was being added due to differences in how patches are formatted. This may have resulted in some patches having tests run twice or even skipped. checkstyle errors are now calculated per module. this speeds up this particular test quite a bit and means that it is less likely to NPE for certain classes of patches. *checkstyle now shows errors before, errors after, and the filename + line number where the new errors are being reported. Unfortunately, this uses GNU diff extensions. whitespace now prints the name and line of the source file that has the whitespace fixed all of the shellcheck errors. newer versions of shellcheck now understand line continuations! So all those false reports triggered by awk are now gone! NOTE: I have a suspicion that the current checkstyle code in test-patch is actually reporting the wrong number. Patches can trigger checkstyle errors that appear outside of the lines that are patched. MAPREDUCE-6165 , for example, has only 1 reported, but there are actually 8 new ones. (4 were removed by the patch.) Given the aggravation, etc, these issues are causing, this should probably be committed ASAP. If someone could do a quick test+review, that'd be great.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6223/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6223/console in case of problems.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
          0 shellcheck 0m 15s Shellcheck was not available.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 19s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12729363/HADOOP-11866-05.patch
          Optional Tests shellcheck
          git revision trunk / aa22450
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6223/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 15s Shellcheck was not available. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 19s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729363/HADOOP-11866-05.patch Optional Tests shellcheck git revision trunk / aa22450 Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6223/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          -06:

          • update shellcheck to use the same method as checkstyle. this results in much more accurate error reporting.
          Show
          aw Allen Wittenauer added a comment - -06: update shellcheck to use the same method as checkstyle. this results in much more accurate error reporting.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6227/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6227/console in case of problems.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
          0 shellcheck 0m 15s Shellcheck was not available.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 18s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12729517/HADOOP-11866-06.patch
          Optional Tests shellcheck
          git revision trunk / de9404f
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6227/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 15s Shellcheck was not available. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729517/HADOOP-11866-06.patch Optional Tests shellcheck git revision trunk / de9404f Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6227/console This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment -
          +  # compare the errors, generating a string of line
          +  # numbers.  Sorry portability: GNU diff makes this too easy
          +  ${DIFF} --unchanged-line-format="" \
          

          Not for this ticket but follow-on work, should document that the diff we need is gnu-diff and if possible test for compat it early.

          -function whitespace_preapply
          +function whitespace_postapply
           {
             local count
          +  local j
           
             big_console_header "Checking for whitespace at the end of lines"
             start_clock
           
          -  ${GREP} '^+' "${PATCH_DIR}/patch" | ${GREP} '[[:blank:]]$' > "${PATCH_DIR}/whitespace.txt"
          +  pushd "${BASEDIR}" >/dev/null
          +  for j in ${CHANGED_FILES}; do
          +    ${GREP} -nHE '[[:blank:]]$' "./${j}" | ${GREP} -f "${GITDIFFLINES}" >> "${PATCH_DIR}/whitespace.txt"
          +  done
           
             # shellcheck disable=SC2016
             count=$(wc -l "${PATCH_DIR}/whitespace.txt" | ${AWK} '{print $1}')
           
             if [[ ${count} -gt 0 ]]; then
               add_jira_table -1 whitespace "The patch has ${count}"\
          -      " line(s) that end in whitespace."
          +      " line(s) that end in whitespace. Use git apply --whitespace=fix."
               add_jira_footer whitespace "@@BASE@@/whitespace.txt"
               return 1
             fi
           
          +  popd >/dev/null
          

          There's an earlier return that doesn't properly popd.

          Show
          busbey Sean Busbey added a comment - + # compare the errors, generating a string of line + # numbers. Sorry portability: GNU diff makes this too easy + ${DIFF} --unchanged-line-format="" \ Not for this ticket but follow-on work, should document that the diff we need is gnu-diff and if possible test for compat it early. -function whitespace_preapply +function whitespace_postapply { local count + local j big_console_header "Checking for whitespace at the end of lines" start_clock - ${GREP} '^+' "${PATCH_DIR}/patch" | ${GREP} '[[:blank:]]$' > "${PATCH_DIR}/whitespace.txt" + pushd "${BASEDIR}" >/dev/ null + for j in ${CHANGED_FILES}; do + ${GREP} -nHE '[[:blank:]]$' "./${j}" | ${GREP} -f "${GITDIFFLINES}" >> "${PATCH_DIR}/whitespace.txt" + done # shellcheck disable=SC2016 count=$(wc -l "${PATCH_DIR}/whitespace.txt" | ${AWK} '{print $1}') if [[ ${count} -gt 0 ]]; then add_jira_table -1 whitespace "The patch has ${count}" \ - " line(s) that end in whitespace." + " line(s) that end in whitespace. Use git apply --whitespace=fix." add_jira_footer whitespace "@@BASE@@/whitespace.txt" return 1 fi + popd >/dev/ null There's an earlier return that doesn't properly popd.
          Hide
          aw Allen Wittenauer added a comment -

          Thanks Sean! Great catches!

          -07:

          • fixed the missing popd
          • minor whitespace cleanup
          • made sure usage at least mentions GNU diff.
          • hook up --help|-help|... to show usage
          Show
          aw Allen Wittenauer added a comment - Thanks Sean! Great catches! -07: fixed the missing popd minor whitespace cleanup made sure usage at least mentions GNU diff. hook up --help|-help|... to show usage
          Hide
          aw Allen Wittenauer added a comment -

          correct -07 file.

          Show
          aw Allen Wittenauer added a comment - correct -07 file.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6228/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6228/console in case of problems.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 release audit 0m 16s The applied patch does not increase the total number of release audit warnings.
          0 shellcheck 0m 16s Shellcheck was not available.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 19s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12729531/HADOOP-11866-07.patch
          Optional Tests shellcheck
          git revision trunk / de9404f
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6228/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 16s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 16s Shellcheck was not available. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 19s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729531/HADOOP-11866-07.patch Optional Tests shellcheck git revision trunk / de9404f Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6228/console This message was automatically generated.
          Hide
          raviprak Ravi Prakash added a comment -

          Thanks for the work!

          1. rm "$ {file}

            " 2>/dev/null is unnecessary

          2. emtpy -> empty

          These are minor nitpicks though and its fine to follow up in a different JIRA. The changes look good to me. +1

          Show
          raviprak Ravi Prakash added a comment - Thanks for the work! rm "$ {file} " 2>/dev/null is unnecessary emtpy -> empty These are minor nitpicks though and its fine to follow up in a different JIRA. The changes look good to me. +1
          Hide
          aw Allen Wittenauer added a comment -

          -08:

          • fix ravi's nits
          Show
          aw Allen Wittenauer added a comment - -08: fix ravi's nits
          Hide
          raviprak Ravi Prakash added a comment -

          +1. Thanks Allen and Naganarasimha G R

          Show
          raviprak Ravi Prakash added a comment - +1. Thanks Allen and Naganarasimha G R
          Hide
          aw Allen Wittenauer added a comment -

          Committed to trunk and (ugh) branch-2.

          Thanks everyone for the reviews/input/etc.

          Show
          aw Allen Wittenauer added a comment - Committed to trunk and (ugh) branch-2. Thanks everyone for the reviews/input/etc.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7709 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7709/)
          HADOOP-11866. increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          • dev-support/test-patch.d/whitespace.sh
          • dev-support/test-patch.d/checkstyle.sh
          • dev-support/test-patch.d/shellcheck.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7709 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7709/ ) HADOOP-11866 . increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh dev-support/test-patch.d/whitespace.sh dev-support/test-patch.d/checkstyle.sh dev-support/test-patch.d/shellcheck.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/180/)
          HADOOP-11866. increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.d/shellcheck.sh
          • dev-support/test-patch.sh
          • dev-support/test-patch.d/whitespace.sh
          • dev-support/test-patch.d/checkstyle.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/180/ ) HADOOP-11866 . increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.d/shellcheck.sh dev-support/test-patch.sh dev-support/test-patch.d/whitespace.sh dev-support/test-patch.d/checkstyle.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #914 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/914/)
          HADOOP-11866. increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110)

          • dev-support/test-patch.d/checkstyle.sh
          • dev-support/test-patch.d/shellcheck.sh
          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.d/whitespace.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #914 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/914/ ) HADOOP-11866 . increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110) dev-support/test-patch.d/checkstyle.sh dev-support/test-patch.d/shellcheck.sh dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.d/whitespace.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2112 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2112/)
          HADOOP-11866. increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110)

          • dev-support/test-patch.sh
          • dev-support/test-patch.d/whitespace.sh
          • dev-support/test-patch.d/shellcheck.sh
          • dev-support/test-patch.d/checkstyle.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2112 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2112/ ) HADOOP-11866 . increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110) dev-support/test-patch.sh dev-support/test-patch.d/whitespace.sh dev-support/test-patch.d/shellcheck.sh dev-support/test-patch.d/checkstyle.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #171 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/171/)
          HADOOP-11866. increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110)

          • dev-support/test-patch.d/shellcheck.sh
          • dev-support/test-patch.sh
          • dev-support/test-patch.d/whitespace.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.d/checkstyle.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #171 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/171/ ) HADOOP-11866 . increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110) dev-support/test-patch.d/shellcheck.sh dev-support/test-patch.sh dev-support/test-patch.d/whitespace.sh hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.d/checkstyle.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/181/)
          HADOOP-11866. increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110)

          • dev-support/test-patch.d/shellcheck.sh
          • dev-support/test-patch.d/whitespace.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          • dev-support/test-patch.d/checkstyle.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/181/ ) HADOOP-11866 . increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110) dev-support/test-patch.d/shellcheck.sh dev-support/test-patch.d/whitespace.sh hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh dev-support/test-patch.d/checkstyle.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2130 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2130/)
          HADOOP-11866. increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110)

          • dev-support/test-patch.d/shellcheck.sh
          • dev-support/test-patch.d/checkstyle.sh
          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.d/whitespace.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2130 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2130/ ) HADOOP-11866 . increase readability and reliability of checkstyle, shellcheck, and whitespace reports (aw) (aw: rev 5f8112ffd220598d997c92f681d3f69022898110) dev-support/test-patch.d/shellcheck.sh dev-support/test-patch.d/checkstyle.sh dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.d/whitespace.sh

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              Naganarasimha Naganarasimha G R
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development