Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      <!-- markdown -->
      * test-patch.sh now has new output that is different than the previous versions
      * test-patch.sh is now pluggable via the test-patch.d directory, with checkstyle and shellcheck tests included
      * JIRA comments now use much more markup to improve readability
      * test-patch.sh now supports either a file name, a URL, or a JIRA issue as input in developer mode
      * If part of the patch testing code is changed, test-patch.sh will now attempt to re-executing itself using the new version.
      * Some logic to try and reduce the amount of unnecessary tests. For example, patches that only modify markdown should not run the Java compilation tests.
      * Plugins for checkstyle, shellcheck, and whitespace now execute as necessary.
      * New test code for mvn site
      * A breakdown of the times needed to execute certain blocks as well as a total runtime is now reported to assist in fixing long running tests and optimize the entire process.
      * Several new options
        * --resetrepo will put test-patch.sh in destructive mode, similar to a normal Jenkins run
        * --testlist allows one to provide a comma delimited list of test subsystems to forcibly execute
        * --modulelist to provide a comma delimited list of module tests to execute in addition to the ones that are automatically detected
        * --offline mode to attempt to stop connecting to the Internet for certain operations
      * test-patch.sh now defaults to the POSIX equivalents on Solaris and Illumos-based operating systems
      * shelldocs.py may be used to generate test-patch.sh API information
      * FindBugs output is now listed on the JIRA comment
      * lots of general code cleanup, including attempts to remove any local state files to reduce potential race conditions
      * Some logic to determine if a patch is for a given major branch using several strategies as well as a particular git ref (using git+ref as part of the name).
      * Some logic to determine if a patch references a particular JIRA issue.
      * Unit tests are only flagged as necessary with native or Java code, since Hadoop has no framework in place yet for other types of unit tests.
      * test-patch now exits with a failure status if problems arise trying to do git checkouts. Previously the exit code was success.
      Show
      <!-- markdown --> * test-patch.sh now has new output that is different than the previous versions * test-patch.sh is now pluggable via the test-patch.d directory, with checkstyle and shellcheck tests included * JIRA comments now use much more markup to improve readability * test-patch.sh now supports either a file name, a URL, or a JIRA issue as input in developer mode * If part of the patch testing code is changed, test-patch.sh will now attempt to re-executing itself using the new version. * Some logic to try and reduce the amount of unnecessary tests. For example, patches that only modify markdown should not run the Java compilation tests. * Plugins for checkstyle, shellcheck, and whitespace now execute as necessary. * New test code for mvn site * A breakdown of the times needed to execute certain blocks as well as a total runtime is now reported to assist in fixing long running tests and optimize the entire process. * Several new options   * --resetrepo will put test-patch.sh in destructive mode, similar to a normal Jenkins run   * --testlist allows one to provide a comma delimited list of test subsystems to forcibly execute   * --modulelist to provide a comma delimited list of module tests to execute in addition to the ones that are automatically detected   * --offline mode to attempt to stop connecting to the Internet for certain operations * test-patch.sh now defaults to the POSIX equivalents on Solaris and Illumos-based operating systems * shelldocs.py may be used to generate test-patch.sh API information * FindBugs output is now listed on the JIRA comment * lots of general code cleanup, including attempts to remove any local state files to reduce potential race conditions * Some logic to determine if a patch is for a given major branch using several strategies as well as a particular git ref (using git+ref as part of the name). * Some logic to determine if a patch references a particular JIRA issue. * Unit tests are only flagged as necessary with native or Java code, since Hadoop has no framework in place yet for other types of unit tests. * test-patch now exits with a failure status if problems arise trying to do git checkouts. Previously the exit code was success.

      Description

      This code is bad and you should feel bad.

        Attachments

        1. HADOOP-11746-21.branch-2.patch
          106 kB
          Allen Wittenauer
        2. HADOOP-11746-21.patch
          112 kB
          Allen Wittenauer
        3. HADOOP-11746-20.patch
          112 kB
          Allen Wittenauer
        4. HADOOP-11746-19.patch
          112 kB
          Allen Wittenauer
        5. HADOOP-11746-18.patch
          110 kB
          Allen Wittenauer
        6. HADOOP-11746-17.patch
          109 kB
          Allen Wittenauer
        7. HADOOP-11746-16.patch
          109 kB
          Allen Wittenauer
        8. HADOOP-11746-15.patch
          110 kB
          Allen Wittenauer
        9. HADOOP-11746-14.patch
          110 kB
          Allen Wittenauer
        10. HADOOP-11746-13.patch
          108 kB
          Allen Wittenauer
        11. HADOOP-11746-12.patch
          108 kB
          Allen Wittenauer
        12. HADOOP-11746-11.patch
          106 kB
          Allen Wittenauer
        13. HADOOP-11746-10.patch
          105 kB
          Allen Wittenauer
        14. HADOOP-11746-09.patch
          100 kB
          Allen Wittenauer
        15. HADOOP-11746-07.patch
          96 kB
          Allen Wittenauer
        16. HADOOP-11746-06.patch
          96 kB
          Allen Wittenauer
        17. HADOOP-11746-05.patch
          94 kB
          Allen Wittenauer
        18. HADOOP-11746-04.patch
          82 kB
          Allen Wittenauer
        19. HADOOP-11746-03.patch
          78 kB
          Allen Wittenauer
        20. HADOOP-11746-02.patch
          64 kB
          Allen Wittenauer
        21. HADOOP-11746-01.patch
          63 kB
          Allen Wittenauer
        22. HADOOP-11746-00.patch
          44 kB
          Allen Wittenauer

          Issue Links

            Activity

              People

              • Assignee:
                aw Allen Wittenauer
                Reporter:
                aw Allen Wittenauer
              • Votes:
                2 Vote for this issue
                Watchers:
                19 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: