Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11859

PseudoAuthenticationHandler fails with httpcomponents v4.4

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      This shows in the context of WebHCat and Hive (which recently moved to httpcomponents:httpclient:4.4) but could happen in other places.

      URLEncodedUtils.parse(String, Charset) which is called from PseudoAuthenticationHandler.getUserName() with the 1st argument produced by HttpServletRequest.getQueryString().
      The later returns NULL if there is no query string in the URL.

      in httpcoponents:httpclient:4.2.5 parse() gracefully handles first argument being NULL, but in 4.4 it NPEs.

      1. HADOOP-11859.patch
        1 kB
        Eugene Koifman

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 26s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 25s There were no new javac warning messages.
          +1 javadoc 9m 31s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 5m 26s There were no new checkstyle issues.
          +1 install 1m 31s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 36s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 5m 18s Tests passed in hadoop-auth.
              45m 11s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727011/HADOOP-11859.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 2c14690
          hadoop-auth test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6143/artifact/patchprocess/testrun_hadoop-auth.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6143/testReport/
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6143//console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 26s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 25s There were no new javac warning messages. +1 javadoc 9m 31s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 5m 26s There were no new checkstyle issues. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 36s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 5m 18s Tests passed in hadoop-auth.     45m 11s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727011/HADOOP-11859.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2c14690 hadoop-auth test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6143/artifact/patchprocess/testrun_hadoop-auth.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6143/testReport/ Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6143//console This message was automatically generated.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          +1

          Show
          jnp Jitendra Nath Pandey added a comment - +1
          Hide
          jnp Jitendra Nath Pandey added a comment -

          I think TestPseudoAuthenticationHandler#testAnonymousOn covers the null querystring scenario, unit test not needed. I will commit it shortly.

          Show
          jnp Jitendra Nath Pandey added a comment - I think TestPseudoAuthenticationHandler#testAnonymousOn covers the null querystring scenario, unit test not needed. I will commit it shortly.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          Committed to trunk and branch-2. Thanks Eugene!

          Show
          jnp Jitendra Nath Pandey added a comment - Committed to trunk and branch-2. Thanks Eugene!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7637 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7637/)
          HADOOP-11859. PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7637 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7637/ ) HADOOP-11859 . PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2104 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2104/)
          HADOOP-11859. PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2104 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2104/ ) HADOOP-11859 . PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #163 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/163/)
          HADOOP-11859. PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #163 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/163/ ) HADOOP-11859 . PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/172/)
          HADOOP-11859. PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/172/ ) HADOOP-11859 . PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #906 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/906/)
          HADOOP-11859. PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #906 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/906/ ) HADOOP-11859 . PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #173 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/173/)
          HADOOP-11859. PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1)

          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #173 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/173/ ) HADOOP-11859 . PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1) hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2122 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2122/)
          HADOOP-11859. PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2122 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2122/ ) HADOOP-11859 . PseudoAuthenticationHandler fails with httpcomponents v4.4. Contributed by Eugene Koifman. (jitendra: rev 1f4767c7f2d1fdd23954c16e903acd2dca78a1e1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/PseudoAuthenticationHandler.java
          Hide
          kihwal Kihwal Lee added a comment - - edited

          cherry-picked to branch-2.7.

          Show
          kihwal Kihwal Lee added a comment - - edited cherry-picked to branch-2.7.

            People

            • Assignee:
              ekoifman Eugene Koifman
              Reporter:
              ekoifman Eugene Koifman
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development