Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11781

fix race conditions and add URL support to smart-apply-patch.sh

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Release Note:
      Now auto-downloads patch from issue-id; fixed race conditions; fixed bug affecting some patches.

      Description

      smart-apply-patch.sh has a few race conditions and is just generally crufty. It should really be rewritten.

      1. HADOOP-11781-01.patch
        3 kB
        Raymie Stata
      2. HADOOP-11781-02.patch
        3 kB
        Raymie Stata
      3. HADOOP-11781-03.patch
        3 kB
        Raymie Stata

        Issue Links

          Activity

          Hide
          raymie Raymie Stata added a comment -

          -01: cleaned up a race-condition with file names (c.f. HADOOP-11746). Added feature to take a URL and JIRA issue-identifier instead of a patch filename, so one can more quickly apply patches (we want to quickly check the backlog of patches hundreds of patches to find ones that no longer apply – this feature will help).

          Show
          raymie Raymie Stata added a comment - -01: cleaned up a race-condition with file names (c.f. HADOOP-11746 ). Added feature to take a URL and JIRA issue-identifier instead of a patch filename, so one can more quickly apply patches (we want to quickly check the backlog of patches hundreds of patches to find ones that no longer apply – this feature will help).
          Hide
          raymie Raymie Stata added a comment -

          -02: applied previous version to all 926 issues in the "patch avail" state. This test uncovered a bug that is fixed by this version. (BTW, 448 of those patches successfully apply, 478 fail to.)

          Show
          raymie Raymie Stata added a comment - -02: applied previous version to all 926 issues in the "patch avail" state. This test uncovered a bug that is fixed by this version. (BTW, 448 of those patches successfully apply, 478 fail to.)
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12708928/HADOOP-11781-02.patch
          against trunk revision 867d5d2.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6049//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6049//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708928/HADOOP-11781-02.patch against trunk revision 867d5d2. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6049//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6049//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          This is awesome! Changed the summary and description so we can push this in sooner rather than later.

          One nit: let's change the sort | uniq's to sort -u so it runs a little faster.

          Show
          aw Allen Wittenauer added a comment - This is awesome! Changed the summary and description so we can push this in sooner rather than later. One nit: let's change the sort | uniq 's to sort -u so it runs a little faster.
          Hide
          raymie Raymie Stata added a comment -

          -03: made sort -u change.

          Show
          raymie Raymie Stata added a comment - -03: made sort -u change.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12709187/HADOOP-11781-03.patch
          against trunk revision 72f6bd4.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6056//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6056//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709187/HADOOP-11781-03.patch against trunk revision 72f6bd4. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6056//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6056//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          +1 committed to trunk.

          Thanks!

          Show
          aw Allen Wittenauer added a comment - +1 committed to trunk. Thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7532 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7532/)
          HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7532 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7532/ ) HADOOP-11781 . fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/)
          HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/ ) HADOOP-11781 . fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/)
          HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/ ) HADOOP-11781 . fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/)
          HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/ ) HADOOP-11781 . fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/892/)
          HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)

          • dev-support/smart-apply-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/892/ ) HADOOP-11781 . fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db) dev-support/smart-apply-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/)
          HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/ ) HADOOP-11781 . fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/)
          HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)

          • dev-support/smart-apply-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/ ) HADOOP-11781 . fix race conditions and add URL support to smart-apply-patch.sh (Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db) dev-support/smart-apply-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              raymie Raymie Stata
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development