Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc, performance
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      The Client#call() methods that are deprecated since 0.23 have been removed.

      Description

        private static ClientCache CLIENTS=new ClientCache();
      ...
          this.client = CLIENTS.getClient(conf, factory);
      

      Meanwhile in ClientCache

      public synchronized Client getClient(Configuration conf,
            SocketFactory factory, Class<? extends Writable> valueClass) {
      ...
         Client client = clients.get(factory);
          if (client == null) {
            client = new Client(valueClass, conf, factory);
            clients.put(factory, client);
          } else {
            client.incCount();
          }
      

      All invokers end up calling these methods, resulting in IPC clients choking up.



        Attachments

        1. sync-client-threads.png
          18 kB
          Gopal V
        2. sync-client-bt.png
          69 kB
          Gopal V
        3. HADOOP-11772-wip-002.patch
          7 kB
          Akira Ajisaka
        4. HADOOP-11772-wip-001.patch
          7 kB
          Akira Ajisaka
        5. HADOOP-11772-003.patch
          12 kB
          Akira Ajisaka
        6. HADOOP-11772-002.patch
          13 kB
          Akira Ajisaka
        7. HADOOP-11772-001.patch
          3 kB
          Akira Ajisaka
        8. HADOOP-11772.004.patch
          8 kB
          Haohui Mai
        9. dfs-sync-ipc.png
          103 kB
          Gopal V
        10. cached-locking.png
          36 kB
          Gopal V
        11. cached-connections.png
          52 kB
          Gopal V
        12. after-ipc-fix.png
          19 kB
          Gopal V

          Issue Links

            Activity

              People

              • Assignee:
                wheat9 Haohui Mai
                Reporter:
                gopalv Gopal V
              • Votes:
                0 Vote for this issue
                Watchers:
                18 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: