Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12052

IPC client downgrades all exception types to IOE, breaks callers trying to use them

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      The HADOOP-11772 cache changes mean that an exception such as UnknownHostException being raised on a Client connect is now being returned as a simple IOException, wrapping an ExecutionException, with the real exception being hidden inside that.

      This breaks any application which uses the exception class in a try/catch statement so as to choose different actions depending on the failure mode. This has surfaced in the SLIDER-896 tests, but is likely to happen in production too.

      1. HADOOP-12052.patch
        1.0 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #212 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/212/)
          HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #212 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/212/ ) HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2151 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2151/)
          HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2151 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2151/ ) HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #953 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/953/)
          HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #953 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/953/ ) HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #223 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/223/)
          HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #223 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/223/ ) HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/220/)
          HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/220/ ) HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2168 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2168/)
          HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2168 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2168/ ) HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7988 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7988/)
          HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7988 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7988/ ) HADOOP-12052 IPC client downgrades all exception types to IOE, breaks callers trying to use them. (Brahma Reddy Battula via stevel) (stevel: rev 18f680977684710037c07bb068383791e8a33a9e) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1

          Show
          vinayrpet Vinayakumar B added a comment - +1
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks Steve Loughran and Varun Saxena for reviewing the patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks Steve Loughran and Varun Saxena for reviewing the patch..
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 19s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 37s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 5s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 23s Tests passed in hadoop-common.
              62m 22s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12737285/HADOOP-12052.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d7e7f6a
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6919/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6919/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6919/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 19s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 23s Tests passed in hadoop-common.     62m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12737285/HADOOP-12052.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d7e7f6a hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6919/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6919/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6919/console This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Submitting patch

          Show
          varun_saxena Varun Saxena added a comment - Submitting patch
          Hide
          stevel@apache.org Steve Loughran added a comment -

          we have the regression test in slider...

          Show
          stevel@apache.org Steve Loughran added a comment - we have the regression test in slider...
          Hide
          varun_saxena Varun Saxena added a comment -

          LGTM. Can you add a simple test case to verify the change ?

          Show
          varun_saxena Varun Saxena added a comment - LGTM. Can you add a simple test case to verify the change ?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Attaching patch..Steve Loughran ..kindly review!!

          Show
          brahmareddy Brahma Reddy Battula added a comment - Attaching patch.. Steve Loughran ..kindly review!!
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Yes ,Following change at Client.java in HADOOP-11772 induces.

          +      } catch (ExecutionException e) {
          +        throw new IOException(e);
                 }
          
          Show
          brahmareddy Brahma Reddy Battula added a comment - Yes ,Following change at Client.java in HADOOP-11772 induces. + } catch (ExecutionException e) { + throw new IOException(e); }

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development