Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11741

Add LOG.isDebugEnabled() guard for some LOG.debug()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.8.0, 3.0.0-alpha1
    • None
    • None
    • Reviewed

    Description

      isDebugEnabled() is optional. But when there are :
      1. lots of concatenating Strings
      2. complicated function calls
      in the arguments, LOG.debug(..) should be guarded with LOG.isDebugEnabled() to avoid unnecessary arguments evaluation and impove performance.

      Attachments

        1. HADOOP-11741.001.patch
          14 kB
          Walter Su
        2. HADOOP-11741.002.patch
          14 kB
          Walter Su

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. HDFS-7978 Add LOG.isDebugEnabled() guard for some LOG.debug(..)

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              walter.k.su Walter Su
              walter.k.su Walter Su
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: