Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7978

Add LOG.isDebugEnabled() guard for some LOG.debug(..)

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      isDebugEnabled() is optional. But when there are :
      1. lots of concatenating Strings
      2. complicated function calls
      in the arguments, LOG.debug(..) should be guarded with LOG.isDebugEnabled() to avoid unnecessary arguments evaluation and impove performance.

        Attachments

        1. HDFS-7978.003.patch
          16 kB
          Walter Su
        2. HDFS-7978.002.patch
          16 kB
          Walter Su
        3. HDFS-7978.001.patch
          15 kB
          Walter Su

          Issue Links

            Activity

              People

              • Assignee:
                walter.k.su Walter Su
                Reporter:
                walter.k.su Walter Su
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: