Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11685

StorageException complaining " no lease ID" during HBase distributed log splitting

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tools
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is similar to HADOOP-11523, but in a different place. During HBase distributed log splitting, multiple threads will access the same folder called "recovered.edits". However, lots of places in our WASB code did not acquire lease and simply passed null to Azure storage, which caused this issue.

      2015-02-26 03:21:28,871 WARN org.apache.hadoop.hbase.regionserver.SplitLogWorker: log splitting of WALs/workernode4.xxx.g6.internal.cloudapp.net,60020,1422071058425-splitting/workernode4.xxx.g6.internal.cloudapp.net%2C60020%2C1422071058425.1424914216773 failed, returning error
      java.io.IOException: org.apache.hadoop.fs.azure.AzureException: java.io.IOException
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.checkForErrors(HLogSplitter.java:633)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.access$000(HLogSplitter.java:121)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter$OutputSink.finishWriting(HLogSplitter.java:964)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter$LogRecoveredEditsOutputSink.finishWritingAndClose(HLogSplitter.java:1019)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLogFile(HLogSplitter.java:359)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLogFile(HLogSplitter.java:223)
      	at org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:142)
      	at org.apache.hadoop.hbase.regionserver.handler.HLogSplitterHandler.process(HLogSplitterHandler.java:79)
      	at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:128)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
      	at java.lang.Thread.run(Thread.java:745)
      Caused by: org.apache.hadoop.fs.azure.AzureException: java.io.IOException
      	at org.apache.hadoop.fs.azurenative.AzureNativeFileSystemStore.storeEmptyFolder(AzureNativeFileSystemStore.java:1477)
      	at org.apache.hadoop.fs.azurenative.NativeAzureFileSystem.mkdirs(NativeAzureFileSystem.java:1862)
      	at org.apache.hadoop.fs.azurenative.NativeAzureFileSystem.mkdirs(NativeAzureFileSystem.java:1812)
      	at org.apache.hadoop.fs.FileSystem.mkdirs(FileSystem.java:1815)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.getRegionSplitEditsPath(HLogSplitter.java:502)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter$LogRecoveredEditsOutputSink.createWAP(HLogSplitter.java:1211)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter$LogRecoveredEditsOutputSink.getWriterAndPath(HLogSplitter.java:1200)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter$LogRecoveredEditsOutputSink.append(HLogSplitter.java:1243)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter$WriterThread.writeBuffer(HLogSplitter.java:851)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter$WriterThread.doRun(HLogSplitter.java:843)
      	at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter$WriterThread.run(HLogSplitter.java:813)
      Caused by: java.io.IOException
      	at com.microsoft.windowsazure.storage.core.Utility.initIOException(Utility.java:493)
      	at com.microsoft.windowsazure.storage.blob.BlobOutputStream.close(BlobOutputStream.java:282)
      	at org.apache.hadoop.fs.azurenative.AzureNativeFileSystemStore.storeEmptyFolder(AzureNativeFileSystemStore.java:1472)
      	... 10 more
      Caused by: com.microsoft.windowsazure.storage.StorageException: There is currently a lease on the blob and no lease ID was specified in the request.
      	at com.microsoft.windowsazure.storage.StorageException.translateException(StorageException.java:163)
      	at com.microsoft.windowsazure.storage.core.StorageRequest.materializeException(StorageRequest.java:306)
      	at com.microsoft.windowsazure.storage.core.ExecutionEngine.executeWithRetry(ExecutionEngine.java:229)
      	at com.microsoft.windowsazure.storage.blob.CloudBlockBlob.commitBlockList(CloudBlockBlob.java:248)
      	at com.microsoft.windowsazure.storage.blob.BlobOutputStream.commit(BlobOutputStream.java:319)
      	at com.microsoft.windowsazure.storage.blob.BlobOutputStream.close(BlobOutputStream.java:279)
      	... 11 more
      
      1. HADOOP-11685.01.patch
        1 kB
        Duo Xu
      2. HADOOP-11685.02.patch
        1 kB
        Duo Xu
      3. HADOOP-11685.03.patch
        1 kB
        Duo Xu
      4. HADOOP-11685.04.patch
        3 kB
        Duo Xu
      5. HADOOP-11685.05.patch
        3 kB
        Duo Xu
      6. HADOOP-11685.06.patch
        4 kB
        Duo Xu
      7. HADOOP-11685.07.patch
        4 kB
        Duo Xu

        Issue Links

          Activity

          Hide
          onpduo Duo Xu added a comment -

          This exception occurred before HADOOP-11523 was patched and we lacked storage logs for further debugging and cannot reproduce. I will close this for now, if this error appears again after HADOOP-11523 fix in PROD. I will reopen this JIRA.

          Show
          onpduo Duo Xu added a comment - This exception occurred before HADOOP-11523 was patched and we lacked storage logs for further debugging and cannot reproduce. I will close this for now, if this error appears again after HADOOP-11523 fix in PROD. I will reopen this JIRA.
          Hide
          onpduo Duo Xu added a comment -

          The same exceptions were found in one customer's cluster.

          Show
          onpduo Duo Xu added a comment - The same exceptions were found in one customer's cluster.
          Hide
          onpduo Duo Xu added a comment -

          The issue in this code path is when HBase is doing distributed log splitting, for example, WAL1 is being split by regionserver1, WAL2 is being split by regionserver2. The first step in distributed log splitting is to create "recovered.edits" sub folder under certain region's folder. So it is possible there are two threads trying to create this folder at the same time, but in WASB there is no lock for this operation. This causes the "blob lease id" issue.

          Show
          onpduo Duo Xu added a comment - The issue in this code path is when HBase is doing distributed log splitting, for example, WAL1 is being split by regionserver1, WAL2 is being split by regionserver2. The first step in distributed log splitting is to create "recovered.edits" sub folder under certain region's folder. So it is possible there are two threads trying to create this folder at the same time, but in WASB there is no lock for this operation. This causes the "blob lease id" issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 20m 20s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          -1 mvninstall 6m 55s root in trunk failed.
          +1 compile 0m 16s trunk passed with JDK v1.8.0_60
          +1 compile 0m 12s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 14s trunk passed
          +1 mvneclipse 0m 54s trunk passed
          +1 findbugs 0m 38s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 12s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 12s the patch passed
          +1 compile 0m 9s the patch passed with JDK v1.8.0_60
          +1 javac 0m 9s the patch passed
          +1 compile 0m 10s the patch passed with JDK v1.7.0_79
          +1 javac 0m 10s the patch passed
          -1 checkstyle 0m 7s Patch generated 4 new checkstyle issues in hadoop-tools/hadoop-azure (total was 33, now 37).
          +1 mvneclipse 0m 10s the patch passed
          -1 whitespace 0m 0s The patch has 3 line(s) with tabs.
          +1 findbugs 0m 35s the patch passed
          +1 javadoc 0m 10s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 11s the patch passed with JDK v1.7.0_79
          +1 unit 0m 59s hadoop-azure in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 11s hadoop-azure in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 25s Patch generated 1 ASF License warnings.
          34m 59s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-20
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767504/HADOOP-11685.01.patch
          JIRA Issue HADOOP-11685
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 72d284e4db6f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-30c4bc4/dev-support/personality/hadoop.sh
          git revision trunk / 8175c4f
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/artifact/patchprocess/whitespace-tabs.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/artifact/patchprocess/patch-asflicense-problems.txt
          Max memory used 70MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 20m 20s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 6m 55s root in trunk failed. +1 compile 0m 16s trunk passed with JDK v1.8.0_60 +1 compile 0m 12s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 14s trunk passed +1 mvneclipse 0m 54s trunk passed +1 findbugs 0m 38s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 12s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 12s the patch passed +1 compile 0m 9s the patch passed with JDK v1.8.0_60 +1 javac 0m 9s the patch passed +1 compile 0m 10s the patch passed with JDK v1.7.0_79 +1 javac 0m 10s the patch passed -1 checkstyle 0m 7s Patch generated 4 new checkstyle issues in hadoop-tools/hadoop-azure (total was 33, now 37). +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) with tabs. +1 findbugs 0m 35s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 11s the patch passed with JDK v1.7.0_79 +1 unit 0m 59s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 11s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 25s Patch generated 1 ASF License warnings. 34m 59s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-20 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767504/HADOOP-11685.01.patch JIRA Issue HADOOP-11685 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 72d284e4db6f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-30c4bc4/dev-support/personality/hadoop.sh git revision trunk / 8175c4f Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/artifact/patchprocess/whitespace-tabs.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/artifact/patchprocess/patch-asflicense-problems.txt Max memory used 70MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7885/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 5s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 2m 56s trunk passed
          +1 compile 0m 12s trunk passed with JDK v1.8.0_60
          +1 compile 0m 13s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 8s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 11s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 13s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 15s the patch passed
          +1 compile 0m 12s the patch passed with JDK v1.8.0_60
          +1 javac 0m 12s the patch passed
          +1 compile 0m 13s the patch passed with JDK v1.7.0_79
          +1 javac 0m 13s the patch passed
          -1 checkstyle 0m 8s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-azure (total was 33, now 34).
          +1 mvneclipse 0m 11s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 0m 37s the patch passed
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_79
          +1 unit 0m 59s hadoop-azure in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 13s hadoop-azure in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
          10m 11s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-20
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767625/HADOOP-11685.02.patch
          JIRA Issue HADOOP-11685
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 48743b4cc40c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee2a191/dev-support/personality/hadoop.sh
          git revision trunk / 71e533a
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/artifact/patchprocess/patch-asflicense-problems.txt
          Max memory used 224MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 5s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 2m 56s trunk passed +1 compile 0m 12s trunk passed with JDK v1.8.0_60 +1 compile 0m 13s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 8s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 11s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 13s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 15s the patch passed +1 compile 0m 12s the patch passed with JDK v1.8.0_60 +1 javac 0m 12s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_79 +1 javac 0m 13s the patch passed -1 checkstyle 0m 8s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-azure (total was 33, now 34). +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_79 +1 unit 0m 59s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 13s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 10m 11s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-20 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767625/HADOOP-11685.02.patch JIRA Issue HADOOP-11685 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 48743b4cc40c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee2a191/dev-support/personality/hadoop.sh git revision trunk / 71e533a Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/artifact/patchprocess/patch-asflicense-problems.txt Max memory used 224MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7892/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 9m 46s trunk passed
          +1 compile 0m 13s trunk passed with JDK v1.8.0_60
          +1 compile 0m 13s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 12s trunk passed
          +1 mvneclipse 1m 2s trunk passed
          +1 findbugs 0m 37s trunk passed
          +1 javadoc 0m 15s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 13s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 16s the patch passed
          +1 compile 0m 12s the patch passed with JDK v1.8.0_60
          +1 javac 0m 12s the patch passed
          +1 compile 0m 13s the patch passed with JDK v1.7.0_79
          +1 javac 0m 13s the patch passed
          +1 checkstyle 0m 8s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 38s the patch passed
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_79
          +1 unit 1m 0s hadoop-azure in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 13s hadoop-azure in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 24s Patch generated 1 ASF License warnings.
          18m 18s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-20
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767637/HADOOP-11685.03.patch
          JIRA Issue HADOOP-11685
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 3ab0dbd134da 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee2a191/dev-support/personality/hadoop.sh
          git revision trunk / 6381ddc
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7893/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7893/artifact/patchprocess/patch-asflicense-problems.txt
          Max memory used 229MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7893/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 46s trunk passed +1 compile 0m 13s trunk passed with JDK v1.8.0_60 +1 compile 0m 13s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 12s trunk passed +1 mvneclipse 1m 2s trunk passed +1 findbugs 0m 37s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 13s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 16s the patch passed +1 compile 0m 12s the patch passed with JDK v1.8.0_60 +1 javac 0m 12s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_79 +1 javac 0m 13s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_79 +1 unit 1m 0s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 13s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 24s Patch generated 1 ASF License warnings. 18m 18s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-20 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767637/HADOOP-11685.03.patch JIRA Issue HADOOP-11685 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 3ab0dbd134da 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee2a191/dev-support/personality/hadoop.sh git revision trunk / 6381ddc Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7893/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7893/artifact/patchprocess/patch-asflicense-problems.txt Max memory used 229MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7893/console This message was automatically generated.
          Hide
          onpduo Duo Xu added a comment -

          Lin Chan Chris Nauroth Could you take a look at this patch?

          The function storeEmptyFolder basically tries to create an empty blob with folder property. So if we get this exception "there is a lease on the blob, ....", which implicitly means the blob has been already created, we do not throw this exception and simply return.

          Show
          onpduo Duo Xu added a comment - Lin Chan Chris Nauroth Could you take a look at this patch? The function storeEmptyFolder basically tries to create an empty blob with folder property. So if we get this exception "there is a lease on the blob, ....", which implicitly means the blob has been already created, we do not throw this exception and simply return.
          Hide
          linchan Lin Chan added a comment -

          Patch looks good to me.

          Show
          linchan Lin Chan added a comment - Patch looks good to me.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hello Duo Xu.

          There is something I don't quite understand about this analysis.

          So it is possible there are two threads trying to create this folder at the same time, but in WASB there is no lock for this operation. This causes the "blob lease id" issue.

          From the stack trace, we are definitely in the mkdirs code path. However, my understanding is that leases are not acquired on mkdirs operations. They are acquired in the rename code path if atomic rename is enabled for the path (as it should be for an HBase WAL). Therefore, I don't understand the theory that the root cause was concurrent mkdirs calls.

          If there was concurrent rename activity happening at the same time, then this explanation would make more sense. The other thread would have held a lease throughout the rename, and then this thread would have failed on the mkdirs for lack of a lease. Is there rename activity when this error occurs?

          Please let me know your thoughts on this.

          Show
          cnauroth Chris Nauroth added a comment - Hello Duo Xu . There is something I don't quite understand about this analysis. So it is possible there are two threads trying to create this folder at the same time, but in WASB there is no lock for this operation. This causes the "blob lease id" issue. From the stack trace, we are definitely in the mkdirs code path. However, my understanding is that leases are not acquired on mkdirs operations. They are acquired in the rename code path if atomic rename is enabled for the path (as it should be for an HBase WAL). Therefore, I don't understand the theory that the root cause was concurrent mkdirs calls. If there was concurrent rename activity happening at the same time, then this explanation would make more sense. The other thread would have held a lease throughout the rename , and then this thread would have failed on the mkdirs for lack of a lease. Is there rename activity when this error occurs? Please let me know your thoughts on this.
          Hide
          onpduo Duo Xu added a comment -

          Chris Nauroth

          Yes, the scenario you are talking about is possible. During distributed log splitting, the general steps are
          1. One node or regionserver crashes
          2. Other nodes get the WALs of that node, and for each node, a worker thread will start to split the WALs it received from that crashed node
          3. The worker thread will create "recovered.edits" folder under the region whose edits were recorded in the WAL if not exists, for example,

          wasb:///hbase/data/default/table/3c842e8823c192d1028dc72ac3f22886/recovered.edits/

          4. Then it will write edits of the WAL to a temp file under the "recovered.edits" folder, like

          wasb:///hbase/data/default/table/3c842e8823c192d1028dc72ac3f22886/recovered.edits/15.temp

          . In this step, each thread is writing to different file so no conflicts.
          5. Finally after it finished reading that WAL file, it will rename it to

          wasb:///hbase/data/default/table/3c842e8823c192d1028dc72ac3f22886/recovered.edits/15

          for log replay. In this step, it will update the "recovered.edits" folder lastmodifiedtime property. And multiple threads may update the same folder, but this is fixed in HADOOP-11523.
          6. Go back to step 3.

          Since WALs contain the same range of regions, the worker thread on each node may do step 3~5 at the same time on the same region folder path.

          So you think the exception happens when for example the worker thread 1 is doing 5 and the worker thread 2 is doing 3. However, if you look at mkdir in WASB, it will pre-check whether "recovered.edits" has already been created or not. So this case is based on the thread 1 finishes step 3-5 between thread2 passes pre-check and starts to create the empty blob in step 3. This is a very short time but possible.

          However, a more possible case is when multiple nodes get the WALs from the crashed node, and some time they all find the first edits in their WAL which belong to the same region, then they try to do step 3, since these edits are the first one belong to that region in each WAL, there is no "recovered.edits" folder under that region. Thus the pre-check will pass for all worker threads. Then all of them are trying to create a empty blob on the same path. The exception happens when calling

          openOutputStream(blob).close();

          . Looking into the code, although WASB does not explicitly acquire lease on this call, but internally since this is a write operation, a lease will be automatically acquired in SDK layer. If worker thread 1 acquires the lease, other worker threads will fail here.

          No matter which case, since this mkdir operation is simply trying to create a "recovered.edits" folder or other folders in other scenarios, so if the exception is "There is currently a lease on the blob...", which means the folder/blob has already been created, we just need to return success rather than throwing exception here.

          Show
          onpduo Duo Xu added a comment - Chris Nauroth Yes, the scenario you are talking about is possible. During distributed log splitting, the general steps are 1. One node or regionserver crashes 2. Other nodes get the WALs of that node, and for each node, a worker thread will start to split the WALs it received from that crashed node 3. The worker thread will create "recovered.edits" folder under the region whose edits were recorded in the WAL if not exists, for example, wasb:///hbase/data/default/table/3c842e8823c192d1028dc72ac3f22886/recovered.edits/ 4. Then it will write edits of the WAL to a temp file under the "recovered.edits" folder, like wasb:///hbase/data/default/table/3c842e8823c192d1028dc72ac3f22886/recovered.edits/15.temp . In this step, each thread is writing to different file so no conflicts. 5. Finally after it finished reading that WAL file, it will rename it to wasb:///hbase/data/default/table/3c842e8823c192d1028dc72ac3f22886/recovered.edits/15 for log replay. In this step, it will update the "recovered.edits" folder lastmodifiedtime property. And multiple threads may update the same folder, but this is fixed in HADOOP-11523 . 6. Go back to step 3. Since WALs contain the same range of regions, the worker thread on each node may do step 3~5 at the same time on the same region folder path. So you think the exception happens when for example the worker thread 1 is doing 5 and the worker thread 2 is doing 3. However, if you look at mkdir in WASB, it will pre-check whether "recovered.edits" has already been created or not. So this case is based on the thread 1 finishes step 3-5 between thread2 passes pre-check and starts to create the empty blob in step 3. This is a very short time but possible. However, a more possible case is when multiple nodes get the WALs from the crashed node, and some time they all find the first edits in their WAL which belong to the same region, then they try to do step 3, since these edits are the first one belong to that region in each WAL, there is no "recovered.edits" folder under that region. Thus the pre-check will pass for all worker threads. Then all of them are trying to create a empty blob on the same path. The exception happens when calling openOutputStream(blob).close(); . Looking into the code, although WASB does not explicitly acquire lease on this call, but internally since this is a write operation, a lease will be automatically acquired in SDK layer. If worker thread 1 acquires the lease, other worker threads will fail here. No matter which case, since this mkdir operation is simply trying to create a "recovered.edits" folder or other folders in other scenarios, so if the exception is "There is currently a lease on the blob...", which means the folder/blob has already been created, we just need to return success rather than throwing exception here.
          Hide
          onpduo Duo Xu added a comment -

          Chris Nauroth

          Looking into the code, although WASB does not explicitly acquire lease on this call, but internally since this is a write operation, a lease will be automatically acquired in SDK layer. If worker thread 1 acquires the lease, other worker threads will fail here.

          Sorry, I am not so sure whether this is true. Lin Chan should be able to clarify this. But my thought is although WASB does not explicitly acquire lease for this API call, writing to the same blob at the same time is not allowed and will throw exception at Azure Storage server side.

          Show
          onpduo Duo Xu added a comment - Chris Nauroth Looking into the code, although WASB does not explicitly acquire lease on this call, but internally since this is a write operation, a lease will be automatically acquired in SDK layer. If worker thread 1 acquires the lease, other worker threads will fail here. Sorry, I am not so sure whether this is true. Lin Chan should be able to clarify this. But my thought is although WASB does not explicitly acquire lease for this API call, writing to the same blob at the same time is not allowed and will throw exception at Azure Storage server side.
          Hide
          onpduo Duo Xu added a comment -

          Chris Nauroth

          After talking with Lin and looking at the SDK, Azure Storage will not acquire lease automatically. If WASB does not acquire lease explicitly, then there is no lease on that blob.

          So you are right, the exception very likely happens when one thread is trying to rename the blob, while the other thread is calling mkdir.

          Anyway the fix should still works here. If there is a lease on the blob, the blob has already been created, so just return success for the mkdir call.

          Show
          onpduo Duo Xu added a comment - Chris Nauroth After talking with Lin and looking at the SDK, Azure Storage will not acquire lease automatically. If WASB does not acquire lease explicitly, then there is no lease on that blob. So you are right, the exception very likely happens when one thread is trying to rename the blob, while the other thread is calling mkdir. Anyway the fix should still works here. If there is a lease on the blob, the blob has already been created, so just return success for the mkdir call.
          Hide
          cnauroth Chris Nauroth added a comment -

          Duo Xu, thanks for investigating further and sharing more details.

          Considering that the mkdirs (step 3 in your example) will be followed by creating a file under that directory, presumably using createNonRecursive (step 4) and a subsequent rename of that file (step 5), is there still a risk of a failure later in the sequence even after this patch? It sounds like this patch would get us past step 3, but not necessarily steps 4 or 5. The thread might see a successful mkdir, but then immediately fail on those later steps.

          There are no unit tests in the patch. Has anything else been done to verify the fix?

          Show
          cnauroth Chris Nauroth added a comment - Duo Xu , thanks for investigating further and sharing more details. Considering that the mkdirs (step 3 in your example) will be followed by creating a file under that directory, presumably using createNonRecursive (step 4) and a subsequent rename of that file (step 5), is there still a risk of a failure later in the sequence even after this patch? It sounds like this patch would get us past step 3, but not necessarily steps 4 or 5. The thread might see a successful mkdir , but then immediately fail on those later steps. There are no unit tests in the patch. Has anything else been done to verify the fix?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 15s trunk passed
          +1 compile 0m 13s trunk passed with JDK v1.8.0_60
          +1 compile 0m 14s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 7s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 30s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_79
          -1 mvninstall 0m 13s hadoop-azure in the patch failed.
          -1 compile 0m 12s hadoop-azure in the patch failed with JDK v1.8.0_60.
          -1 javac 0m 12s hadoop-azure in the patch failed with JDK v1.8.0_60.
          -1 compile 0m 14s hadoop-azure in the patch failed with JDK v1.7.0_79.
          -1 javac 0m 14s hadoop-azure in the patch failed with JDK v1.7.0_79.
          -1 checkstyle 0m 8s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-azure (total was 31, now 32).
          +1 mvneclipse 0m 11s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 findbugs 0m 13s hadoop-azure in the patch failed.
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_79
          -1 unit 0m 11s hadoop-azure in the patch failed with JDK v1.8.0_60.
          -1 unit 0m 13s hadoop-azure in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          8m 24s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-26
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768763/HADOOP-11685.04.patch
          JIRA Issue HADOOP-11685
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux d4616069b319 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh
          git revision trunk / 123b3db
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_60.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_60.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/testReport/
          Max memory used 224MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 15s trunk passed +1 compile 0m 13s trunk passed with JDK v1.8.0_60 +1 compile 0m 14s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 7s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 30s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_79 -1 mvninstall 0m 13s hadoop-azure in the patch failed. -1 compile 0m 12s hadoop-azure in the patch failed with JDK v1.8.0_60. -1 javac 0m 12s hadoop-azure in the patch failed with JDK v1.8.0_60. -1 compile 0m 14s hadoop-azure in the patch failed with JDK v1.7.0_79. -1 javac 0m 14s hadoop-azure in the patch failed with JDK v1.7.0_79. -1 checkstyle 0m 8s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-azure (total was 31, now 32). +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 findbugs 0m 13s hadoop-azure in the patch failed. +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_79 -1 unit 0m 11s hadoop-azure in the patch failed with JDK v1.8.0_60. -1 unit 0m 13s hadoop-azure in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 8m 24s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-26 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768763/HADOOP-11685.04.patch JIRA Issue HADOOP-11685 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux d4616069b319 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh git revision trunk / 123b3db Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_60.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_60.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/testReport/ Max memory used 224MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7937/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 2m 54s trunk passed
          +1 compile 0m 13s trunk passed with JDK v1.8.0_66
          +1 compile 0m 13s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 8s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 31s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_79
          -1 mvninstall 0m 13s hadoop-azure in the patch failed.
          -1 compile 0m 14s hadoop-azure in the patch failed with JDK v1.8.0_66.
          -1 javac 0m 14s hadoop-azure in the patch failed with JDK v1.8.0_66.
          -1 compile 0m 16s hadoop-azure in the patch failed with JDK v1.7.0_79.
          -1 javac 0m 16s hadoop-azure in the patch failed with JDK v1.7.0_79.
          +1 checkstyle 0m 9s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) with tabs.
          -1 findbugs 0m 16s hadoop-azure in the patch failed.
          +1 javadoc 0m 18s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 18s the patch passed with JDK v1.7.0_79
          -1 unit 0m 18s hadoop-azure in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 18s hadoop-azure in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 29s Patch does not generate ASF License warnings.
          8m 55s



          Subsystem Report/Notes
          Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-10-27
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768806/HADOOP-11685.05.patch
          JIRA Issue HADOOP-11685
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 7141a833b3e3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh
          git revision trunk / 56e4f62
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/testReport/
          Max memory used 225MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 2m 54s trunk passed +1 compile 0m 13s trunk passed with JDK v1.8.0_66 +1 compile 0m 13s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 8s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_79 -1 mvninstall 0m 13s hadoop-azure in the patch failed. -1 compile 0m 14s hadoop-azure in the patch failed with JDK v1.8.0_66. -1 javac 0m 14s hadoop-azure in the patch failed with JDK v1.8.0_66. -1 compile 0m 16s hadoop-azure in the patch failed with JDK v1.7.0_79. -1 javac 0m 16s hadoop-azure in the patch failed with JDK v1.7.0_79. +1 checkstyle 0m 9s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) with tabs. -1 findbugs 0m 16s hadoop-azure in the patch failed. +1 javadoc 0m 18s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 18s the patch passed with JDK v1.7.0_79 -1 unit 0m 18s hadoop-azure in the patch failed with JDK v1.8.0_66. -1 unit 0m 18s hadoop-azure in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 29s Patch does not generate ASF License warnings. 8m 55s Subsystem Report/Notes Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-10-27 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768806/HADOOP-11685.05.patch JIRA Issue HADOOP-11685 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 7141a833b3e3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-b9c369f/dev-support/personality/hadoop.sh git revision trunk / 56e4f62 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/testReport/ Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7944/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 23s trunk passed
          +1 compile 0m 14s trunk passed with JDK v1.8.0_60
          +1 compile 0m 14s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 10s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 0m 35s trunk passed
          +1 javadoc 0m 14s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 17s the patch passed
          +1 compile 0m 14s the patch passed with JDK v1.8.0_60
          +1 javac 0m 14s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.7.0_79
          +1 javac 0m 15s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 45s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 14s the patch passed with JDK v1.7.0_79
          +1 unit 1m 5s hadoop-azure in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 19s hadoop-azure in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 24s Patch generated 1 ASF License warnings.
          11m 49s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-27
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769055/HADOOP-11685.06.patch
          JIRA Issue HADOOP-11685
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 1d4184e62689 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-2392ab4/dev-support/personality/hadoop.sh
          git revision trunk / 68ce93c
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7953/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7953/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Max memory used 224MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7953/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 23s trunk passed +1 compile 0m 14s trunk passed with JDK v1.8.0_60 +1 compile 0m 14s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 10s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 14s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 17s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_60 +1 javac 0m 14s the patch passed +1 compile 0m 15s the patch passed with JDK v1.7.0_79 +1 javac 0m 15s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 45s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 14s the patch passed with JDK v1.7.0_79 +1 unit 1m 5s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 19s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 24s Patch generated 1 ASF License warnings. 11m 49s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-27 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769055/HADOOP-11685.06.patch JIRA Issue HADOOP-11685 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 1d4184e62689 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-2392ab4/dev-support/personality/hadoop.sh git revision trunk / 68ce93c Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7953/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7953/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Max memory used 224MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7953/console This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hi Duo Xu.

          Patch v06 is looking pretty good. The "asflicense" failure is unrelated, and it will be fixed by my HADOOP-12519 patch.

          Instead of making NativeAzureFileSystem#createPermissionStatus public, I recommend making it package-private (no access modifier) and applying the VisibleForTesting annotation.

          I'm comparing the v03 patch and the v06 patch, and it looks like the exception handling in v06 could swallow some exceptions by mistake. v03 had an else block for the case when the IOException has a cause that is not a StorageException. That else block has gone away in v06. It seems this could swallow general I/O errors, like connection refused, when they should get reported back to the caller.

          I had made an earlier comment about how this patch might fix the mkdirs only to fail at a later step in HBase log splitting. What are your thoughts on this?

          https://issues.apache.org/jira/browse/HADOOP-11685?focusedCommentId=14970059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14970059

          Show
          cnauroth Chris Nauroth added a comment - Hi Duo Xu . Patch v06 is looking pretty good. The "asflicense" failure is unrelated, and it will be fixed by my HADOOP-12519 patch. Instead of making NativeAzureFileSystem#createPermissionStatus public, I recommend making it package-private (no access modifier) and applying the VisibleForTesting annotation. I'm comparing the v03 patch and the v06 patch, and it looks like the exception handling in v06 could swallow some exceptions by mistake. v03 had an else block for the case when the IOException has a cause that is not a StorageException . That else block has gone away in v06. It seems this could swallow general I/O errors, like connection refused, when they should get reported back to the caller. I had made an earlier comment about how this patch might fix the mkdirs only to fail at a later step in HBase log splitting. What are your thoughts on this? https://issues.apache.org/jira/browse/HADOOP-11685?focusedCommentId=14970059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14970059
          Hide
          onpduo Duo Xu added a comment -

          Chris Nauroth

          That is a copy-paste mistake, I will submit a new patch.

          Looking at the code, createNonRecursive will acquire the lease on that folder before creating files under that folder. rename will acquire the lease on that folder before updating its metadata.

          So at one time, there could be three types of threads accessing that folder, one is doing step 3, one is doing step 4, and one is doing step 5. step 3 will not fail after the patch. step4 and step5 both acquire the lease before creating files/updating folder properties. Thus no thread conflicts here I think.

          Show
          onpduo Duo Xu added a comment - Chris Nauroth That is a copy-paste mistake, I will submit a new patch. Looking at the code, createNonRecursive will acquire the lease on that folder before creating files under that folder. rename will acquire the lease on that folder before updating its metadata. So at one time, there could be three types of threads accessing that folder, one is doing step 3, one is doing step 4, and one is doing step 5. step 3 will not fail after the patch. step4 and step5 both acquire the lease before creating files/updating folder properties. Thus no thread conflicts here I think.
          Hide
          cnauroth Chris Nauroth added a comment -

          Duo Xu, thanks for digging into that more and explaining the full flow. I agree that the lease-holding operations will not trigger similar failures. This is almost ready to commit, pending another revision to address what I pointed out in the prior comment. Thanks!

          Show
          cnauroth Chris Nauroth added a comment - Duo Xu , thanks for digging into that more and explaining the full flow. I agree that the lease-holding operations will not trigger similar failures. This is almost ready to commit, pending another revision to address what I pointed out in the prior comment. Thanks!
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for patch v07, pending a fresh Jenkins run.

          Show
          cnauroth Chris Nauroth added a comment - +1 for patch v07, pending a fresh Jenkins run.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 13s trunk passed
          +1 compile 0m 12s trunk passed with JDK v1.8.0_60
          +1 compile 0m 13s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 8s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 0m 30s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 13s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 15s the patch passed
          +1 compile 0m 12s the patch passed with JDK v1.8.0_60
          +1 javac 0m 12s the patch passed
          +1 compile 0m 14s the patch passed with JDK v1.7.0_79
          +1 javac 0m 14s the patch passed
          +1 checkstyle 0m 8s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 38s the patch passed
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 14s the patch passed with JDK v1.7.0_79
          +1 unit 1m 0s hadoop-azure in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 13s hadoop-azure in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
          11m 15s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-28
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769158/HADOOP-11685.07.patch
          JIRA Issue HADOOP-11685
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux d08660e90944 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-06655ab/dev-support/personality/hadoop.sh
          git revision trunk / 68ce93c
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7960/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7960/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Max memory used 225MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7960/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 13s trunk passed +1 compile 0m 12s trunk passed with JDK v1.8.0_60 +1 compile 0m 13s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 8s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 0m 30s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 13s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 15s the patch passed +1 compile 0m 12s the patch passed with JDK v1.8.0_60 +1 javac 0m 12s the patch passed +1 compile 0m 14s the patch passed with JDK v1.7.0_79 +1 javac 0m 14s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 14s the patch passed with JDK v1.7.0_79 +1 unit 1m 0s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 13s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 11m 15s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-28 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769158/HADOOP-11685.07.patch JIRA Issue HADOOP-11685 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux d08660e90944 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-06655ab/dev-support/personality/hadoop.sh git revision trunk / 68ce93c Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7960/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7960/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7960/console This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          I have committed this to trunk and branch-2. Duo Xu, thank you for contributing the patch.

          Show
          cnauroth Chris Nauroth added a comment - I have committed this to trunk and branch-2. Duo Xu , thank you for contributing the patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8717 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8717/)
          HADOOP-11685. StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead)

          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8717 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8717/ ) HADOOP-11685 . StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2536 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2536/)
          HADOOP-11685. StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead)

          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2536 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2536/ ) HADOOP-11685 . StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #606 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/606/)
          HADOOP-11685. StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead)

          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #606 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/606/ ) HADOOP-11685 . StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1329 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1329/)
          HADOOP-11685. StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead)

          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1329 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1329/ ) HADOOP-11685 . StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #593 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/593/)
          HADOOP-11685. StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead)

          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #593 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/593/ ) HADOOP-11685 . StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2483 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2483/)
          HADOOP-11685. StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead)

          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2483 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2483/ ) HADOOP-11685 . StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #545 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/545/)
          HADOOP-11685. StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead)

          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java
          • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #545 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/545/ ) HADOOP-11685 . StorageException complaining " no lease ID" during HBase (cnauroth: rev 1f7ecb0c84042783f9fcf3f77d7d889dc58c9ead) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemLive.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              onpduo Duo Xu
              Reporter:
              onpduo Duo Xu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development