Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: native
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      io.native.lib.available was removed. Always use native libraries if they exist.

      Description

      According to the discussion in HADOOP-8642, we should remove io.native.lib.available from trunk, and always use native libraries if they exist.

      1. HADOOP-11627.patch
        0.8 kB
        Brahma Reddy Battula
      2. HADOOP-11627-002.patch
        6 kB
        Brahma Reddy Battula
      3. HADOOP-11627-003.patch
        16 kB
        Brahma Reddy Battula
      4. HADOOP-11627-004.patch
        15 kB
        Brahma Reddy Battula
      5. HADOOP-11627-005.patch
        14 kB
        Brahma Reddy Battula
      6. HADOOP-11627-006.patch
        22 kB
        Brahma Reddy Battula
      7. HADOOP-11627-007.patch
        25 kB
        Brahma Reddy Battula
      8. HADOOP-11627-008.patch
        25 kB
        Brahma Reddy Battula
      9. HADOOP-11627-009.patch
        25 kB
        Vinayakumar B
      10. HADOOP-11627-010.patch
        26 kB
        Brahma Reddy Battula
      11. HADOOP-11627-011.patch
        26 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Brahma Reddy Battula, thanks for taking this.
          Removing the property from the configuration is not sufficient. All the code related to the property should be removed. I'm thinking it would be better to document the property to DeprecatedProperties.md that the value is always true.

          Show
          ajisakaa Akira Ajisaka added a comment - Hi Brahma Reddy Battula , thanks for taking this. Removing the property from the configuration is not sufficient. All the code related to the property should be removed. I'm thinking it would be better to document the property to DeprecatedProperties.md that the value is always true.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -
          Show
          ozawa Tsuyoshi Ozawa added a comment - Maybe Akira's patch on HADOOP-8642 is helpful for you. https://issues.apache.org/jira/secure/attachment/12698829/HADOOP-8642.4.patch
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks Akira for review..Updated the patch based on your comments..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks Akira for review..Updated the patch based on your comments..
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks Ozawa for pointing to this issue..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks Ozawa for pointing to this issue..
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Looking over the patch.

          This issue should address to remove IO_NATIVE_LIB_AVAILABLE_KEY. We need to change loadNativeLibraries not to check IO_NATIVE_LIB_AVAILABLE_KEY. Does this make sense?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Looking over the patch. This issue should address to remove IO_NATIVE_LIB_AVAILABLE_KEY. We need to change loadNativeLibraries not to check IO_NATIVE_LIB_AVAILABLE_KEY. Does this make sense?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          We need to change loadNativeLibraries not to check IO_NATIVE_LIB_AVAILABLE_KEY. Does this make sense?

          Thanks Tsuyoshi. Make sense to me. zlib and bzip2 also check IO_NATIVE_LIB_AVAILABLE_KEY. We should remove these. The purpose of this issue is to remove io.native.lib.available, IO_NATIVE_LIB_AVAILABLE_KEY, and IO_NATIVE_LIB_AVAILABLE_DEFAULT completely from the source code tree, without DeprecatedProperties.md.

          Show
          ajisakaa Akira Ajisaka added a comment - We need to change loadNativeLibraries not to check IO_NATIVE_LIB_AVAILABLE_KEY. Does this make sense? Thanks Tsuyoshi. Make sense to me. zlib and bzip2 also check IO_NATIVE_LIB_AVAILABLE_KEY . We should remove these. The purpose of this issue is to remove io.native.lib.available , IO_NATIVE_LIB_AVAILABLE_KEY , and IO_NATIVE_LIB_AVAILABLE_DEFAULT completely from the source code tree, without DeprecatedProperties.md .
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks a lot ..Yes, it make sense..Updated the patch

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks a lot ..Yes, it make sense..Updated the patch
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks akira.and sorry,I misunderstood...Updated the patch based on your comments..Removed partially for some of the testcases whose io.native.lib.available is false(might not require I feel).Ran testcases locally , all are passing..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks akira.and sorry,I misunderstood...Updated the patch based on your comments..Removed partially for some of the testcases whose io.native.lib.available is false(might not require I feel).Ran testcases locally , all are passing..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Getting close. Overall looks good to me without test code.

          -    // Don't use native libs for this test.
          -    Configuration conf = new Configuration();
          -    conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false);
          -    assertFalse("ZlibFactory is using native libs against request",
          -        ZlibFactory.isNativeZlibLoaded(conf));
          

          For testing non-native library, we can introduce a @VisibleForTesting setter method for ZlibFactory.nativeZlibLoaded. That way we can disable native zlib library in tests. It's the same for bzip2.

          • Notice: We must reset ZlibFactory.nativeZlibLoad and Bzip2Factory.nativeBzip2Loaded by @After method when we use setter methods.
          Show
          ajisakaa Akira Ajisaka added a comment - Getting close. Overall looks good to me without test code. - // Don't use native libs for this test. - Configuration conf = new Configuration(); - conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false ); - assertFalse( "ZlibFactory is using native libs against request" , - ZlibFactory.isNativeZlibLoaded(conf)); For testing non-native library, we can introduce a @VisibleForTesting setter method for ZlibFactory.nativeZlibLoaded . That way we can disable native zlib library in tests. It's the same for bzip2. Notice: We must reset ZlibFactory.nativeZlibLoad and Bzip2Factory.nativeBzip2Loaded by @After method when we use setter methods.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          It's the same for bzip2.

          Rethinking this, it's not the same.

          • ZlibFactory tries to load native library when the class is initialized. (only once)
          • Bzip2Factory tries to load native library when isNativeBzip2Loaded(Configuration) is called. (not only once)

          I don't see any existing tests for non-native bzip2 (dummy) library, so we don't need to introduce a setter method for Bzip2Factory. For non-native gzip library, setting ZlibFactory.nativeZlibLoaded to false is sufficient.
          Sorry for the confusion.

          Show
          ajisakaa Akira Ajisaka added a comment - It's the same for bzip2. Rethinking this, it's not the same. ZlibFactory tries to load native library when the class is initialized. (only once) Bzip2Factory tries to load native library when isNativeBzip2Loaded(Configuration) is called. (not only once) I don't see any existing tests for non-native bzip2 (dummy) library, so we don't need to introduce a setter method for Bzip2Factory. For non-native gzip library, setting ZlibFactory.nativeZlibLoaded to false is sufficient. Sorry for the confusion.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks a lot for review..Please check updated patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks a lot for review..Please check updated patch..
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Ran all the testcases for regression locally , all are passing.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Ran all the testcases for regression locally , all are passing.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12702595/HADOOP-11627-004.patch
          against trunk revision ed70fa1.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5847//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702595/HADOOP-11627-004.patch against trunk revision ed70fa1. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5847//console This message is automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Brahma Reddy Battula, would you rebase the patch?

          Show
          ajisakaa Akira Ajisaka added a comment - Hi Brahma Reddy Battula , would you rebase the patch?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Rebased the patch..Thanks!

          Show
          brahmareddy Brahma Reddy Battula added a comment - Rebased the patch..Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703609/HADOOP-11627-005.patch
          against trunk revision 7711049.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs:

          org.apache.hadoop.mapreduce.v2.hs.TestJobHistoryParsing

          The test build failed in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5907//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5907//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703609/HADOOP-11627-005.patch against trunk revision 7711049. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs: org.apache.hadoop.mapreduce.v2.hs.TestJobHistoryParsing The test build failed in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5907//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5907//console This message is automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Testcase failures are unrelated to this patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated to this patch..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Brahma Reddy Battula for rebasing. Some comments:
          1. Would you remove the following code from TestTFileSeqFileComparison.java?

                conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY,
                                true);
          

          2. Some tests fail in TestCodec.java when -Pnative is specified.

          Failed tests: 
            TestCodec.testGzipCompatibility:661 expected:<class org.apache.hadoop.io.compress.zlib.BuiltInGzipDecompressor> but was:<class org.apache.hadoop.io.compress.GzipCodec$GzipZlibDecompressor>
            TestCodec.testGzipCodecWriteJava:879->testGzipCodecWrite:829 ZlibFactory is using native libs against request
            TestCodec.testGzipLongOverflow:778 ZlibFactory is using native libs against request
            TestCodec.testGzipCodecRead:727 ZlibFactory is using native libs against request
            TestCodec.testBuiltInGzipConcat:710->GzipConcatTest:696 expected:<class org.apache.hadoop.io.compress.zlib.BuiltInGzipDecompressor> but was:<class org.apache.hadoop.io.compress.GzipCodec$GzipZlibDecompressor>
          
          Tests run: 24, Failures: 5, Errors: 0, Skipped: 1
          

          I'm thinking we can fix these failures by adding a setter method for ZlibFactory.nativeZlibLoaded and setting the variable to false instead of just removing conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false). If we use the setter method, we should add @After method in the test to reset the variable.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for rebasing. Some comments: 1. Would you remove the following code from TestTFileSeqFileComparison.java? conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, true ); 2. Some tests fail in TestCodec.java when -Pnative is specified. Failed tests: TestCodec.testGzipCompatibility:661 expected:<class org.apache.hadoop.io.compress.zlib.BuiltInGzipDecompressor> but was:<class org.apache.hadoop.io.compress.GzipCodec$GzipZlibDecompressor> TestCodec.testGzipCodecWriteJava:879->testGzipCodecWrite:829 ZlibFactory is using native libs against request TestCodec.testGzipLongOverflow:778 ZlibFactory is using native libs against request TestCodec.testGzipCodecRead:727 ZlibFactory is using native libs against request TestCodec.testBuiltInGzipConcat:710->GzipConcatTest:696 expected:<class org.apache.hadoop.io.compress.zlib.BuiltInGzipDecompressor> but was:<class org.apache.hadoop.io.compress.GzipCodec$GzipZlibDecompressor> Tests run: 24, Failures: 5, Errors: 0, Skipped: 1 I'm thinking we can fix these failures by adding a setter method for ZlibFactory.nativeZlibLoaded and setting the variable to false instead of just removing conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false) . If we use the setter method, we should add @After method in the test to reset the variable.
          Hide
          vinayrpet Vinayakumar B added a comment -

          1. Would you remove the following code from TestTFileSeqFileComparison.java?

          I wonder how compilation passed for this in QA?

          I'm thinking we can fix these failures by adding a setter method for ZlibFactory.nativeZlibLoaded and setting the variable to false instead of just removing conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false). If we use the setter method, we should add @After method in the test to reset the variable.

          Thats a good idea. While resetting after test need to reset to its original value (not just true). How about reloading, same as in static block. Do below changes in ZLibfactory and calling ZlibFactory.loadNativeZLib in @After method.

             static {
          +    loadNativeZLib();
          +  }
          +
          +  @VisibleForTesting
          +  public static void loadNativeZLib() {
               if (NativeCodeLoader.isNativeCodeLoaded()) {
                 nativeZlibLoaded = ZlibCompressor.isNativeZlibLoaded() &&
                   ZlibDecompressor.isNativeZlibLoaded();

          regarding patch, some nits
          1. DeprecatedProperties.md can have the description as below. because the property was not avoiding loading libs, but it was avoiding usage of them for compression codecs.

          +| io.native.lib.available | NONE - By Default native libs will be used for bz2 and zlib compression codecs if available. |

          2. TestConcatenatedCompressedInput.java also need similar treatment as TestCodec to avoid failure when -Pnative specified.

          Show
          vinayrpet Vinayakumar B added a comment - 1. Would you remove the following code from TestTFileSeqFileComparison.java? I wonder how compilation passed for this in QA? I'm thinking we can fix these failures by adding a setter method for ZlibFactory.nativeZlibLoaded and setting the variable to false instead of just removing conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false). If we use the setter method, we should add @After method in the test to reset the variable. Thats a good idea. While resetting after test need to reset to its original value (not just true). How about reloading, same as in static block. Do below changes in ZLibfactory and calling ZlibFactory.loadNativeZLib in @After method. static { + loadNativeZLib(); + } + + @VisibleForTesting + public static void loadNativeZLib() { if (NativeCodeLoader.isNativeCodeLoaded()) { nativeZlibLoaded = ZlibCompressor.isNativeZlibLoaded() && ZlibDecompressor.isNativeZlibLoaded(); regarding patch, some nits 1. DeprecatedProperties.md can have the description as below. because the property was not avoiding loading libs, but it was avoiding usage of them for compression codecs. +| io. native .lib.available | NONE - By Default native libs will be used for bz2 and zlib compression codecs if available. | 2. TestConcatenatedCompressedInput.java also need similar treatment as TestCodec to avoid failure when -Pnative specified.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks a lot for taking look into this issue..Updated patch..Kindly review the same...

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks a lot for taking look into this issue..Updated patch..Kindly review the same...
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12708734/HADOOP-11627-006.patch
          against trunk revision 2e79f1c.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

          org.apache.hadoop.mapred.pipes.TestPipeApplication
          org.apache.hadoop.mapreduce.v2.TestMRJobsWithProfiler
          org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService
          org.apache.hadoop.mapred.TestMRTimelineEventHandling
          org.apache.hadoop.mapred.TestClusterMRNotification

          The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

          org.apache.hadoop.mapred.TestMiniMRChildTask
          org.apache.hadoop.mapred.TestJobCleanup
          org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
          org.apache.hadoop.mapred.TestLazyOutput
          org.apache.hadoop.mapreduce.TestMRJobClient
          org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter
          org.apache.hadoop.mapreduce.TestLargeSort
          org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution
          org.apache.hadoop.mapreduce.v2.TestMRJobs
          org.apache.hadoop.mapreduce.v2.TestUberAM

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6040//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6040//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708734/HADOOP-11627-006.patch against trunk revision 2e79f1c. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapred.pipes.TestPipeApplication org.apache.hadoop.mapreduce.v2.TestMRJobsWithProfiler org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService org.apache.hadoop.mapred.TestMRTimelineEventHandling org.apache.hadoop.mapred.TestClusterMRNotification The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapred.TestMiniMRChildTask org.apache.hadoop.mapred.TestJobCleanup org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers org.apache.hadoop.mapred.TestLazyOutput org.apache.hadoop.mapreduce.TestMRJobClient org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter org.apache.hadoop.mapreduce.TestLargeSort org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution org.apache.hadoop.mapreduce.v2.TestMRJobs org.apache.hadoop.mapreduce.v2.TestUberAM Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6040//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6040//console This message is automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Testcase failures are unrelated this patch...

          Show
          brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated this patch...
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Brahma Reddy Battula for updating the patch. Some comments.
          1. Would you remove unused imports from the following files?

          • ZlibFactory.java
          • BZip2Factory.java
          • NativeCodeLoader.java
          • TestZlibCompressorDecompressor.java
          • TestConcatenatedCompressedInput.java

          2. In TestCodec.java, would you add ZlibFactory.setNativeZlibLoaded(false) in the below tests?

          @@ -458,7 +461,6 @@ public void testCodecInitWithCompressionLevel() throws Exception {
                          + ": native libs not loaded");
               }
               conf = new Configuration();
          -    conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false);
               codecTestWithNOCompression( conf,
                                    "org.apache.hadoop.io.compress.DefaultCodec");
             }
          
               } else {
                 LOG.warn("testCodecPoolCompressorReinit skipped: native libs not loaded");
               }
          -    conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false);
               DefaultCodec dfc = ReflectionUtils.newInstance(DefaultCodec.class, conf);
               gzipReinitTest(conf, dfc);
             }
          
          @@ -901,8 +899,6 @@ public void testCodecPoolAndGzipDecompressor() {
           
               // Don't use native libs for this test.
               Configuration conf = new Configuration();
          -    conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY,
          -                    false);
          

          3. I'm thinking try-finally statement in TestConcatenatedCompressedInput#testPrototypeInflaterGzip() is not needed. Adding ZlibFactory.loadNativeZLib() before doMultipleGzipBufferSizes(jobConf, true) is sufficient for me.

          @@ -352,7 +360,13 @@ public void testBuiltInGzipDecompressor() throws IOException {
                            84, lineNum);
           
               // test BuiltInGzipDecompressor with lots of different input-buffer sizes
          -    doMultipleGzipBufferSizes(jobConf, false);
          +    // Don't use native libs
          +    try {
          +      ZlibFactory.setNativeZlibLoaded(false);
          +      doMultipleGzipBufferSizes(jobConf, false);
          +    } finally {
          +      ZlibFactory.loadNativeZLib();
          +    }
          
          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for updating the patch. Some comments. 1. Would you remove unused imports from the following files? ZlibFactory.java BZip2Factory.java NativeCodeLoader.java TestZlibCompressorDecompressor.java TestConcatenatedCompressedInput.java 2. In TestCodec.java , would you add ZlibFactory.setNativeZlibLoaded(false) in the below tests? @@ -458,7 +461,6 @@ public void testCodecInitWithCompressionLevel() throws Exception { + ": native libs not loaded" ); } conf = new Configuration(); - conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false ); codecTestWithNOCompression( conf, "org.apache.hadoop.io.compress.DefaultCodec" ); } } else { LOG.warn( "testCodecPoolCompressorReinit skipped: native libs not loaded" ); } - conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, false ); DefaultCodec dfc = ReflectionUtils.newInstance(DefaultCodec.class, conf); gzipReinitTest(conf, dfc); } @@ -901,8 +899,6 @@ public void testCodecPoolAndGzipDecompressor() { // Don't use native libs for this test. Configuration conf = new Configuration(); - conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, - false ); 3. I'm thinking try-finally statement in TestConcatenatedCompressedInput#testPrototypeInflaterGzip() is not needed. Adding ZlibFactory.loadNativeZLib() before doMultipleGzipBufferSizes(jobConf, true) is sufficient for me. @@ -352,7 +360,13 @@ public void testBuiltInGzipDecompressor() throws IOException { 84, lineNum); // test BuiltInGzipDecompressor with lots of different input-buffer sizes - doMultipleGzipBufferSizes(jobConf, false ); + // Don't use native libs + try { + ZlibFactory.setNativeZlibLoaded( false ); + doMultipleGzipBufferSizes(jobConf, false ); + } finally { + ZlibFactory.loadNativeZLib(); + }
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I found two issues in TestCodec.java when I reviewed the patch. Filed HADOOP-11800 for fixing these.

          Show
          ajisakaa Akira Ajisaka added a comment - I found two issues in TestCodec.java when I reviewed the patch. Filed HADOOP-11800 for fixing these.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          thanks a lot for review.. Updated the patch.. Kindly review....

          Show
          brahmareddy Brahma Reddy Battula added a comment - thanks a lot for review.. Updated the patch.. Kindly review....
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12709372/HADOOP-11627-007.patch
          against trunk revision ef591b1.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

          org.apache.hadoop.io.compress.TestCodec
          org.apache.hadoop.mapreduce.v2.TestMRJobsWithProfiler
          org.apache.hadoop.mapred.TestMRTimelineEventHandling
          org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService
          org.apache.hadoop.mapred.pipes.TestPipeApplication
          org.apache.hadoop.mapred.TestClusterMRNotification

          The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

          org.apache.hadoop.mapred.TestMiniMRChildTask
          org.apache.hadoop.mapred.TestLazyOutput
          org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
          org.apache.hadoop.mapred.TestJobCleanup
          org.apache.hadoop.mapreduce.TestLargeSort
          org.apache.hadoop.mapreduce.TestMapReduceLazyOutput
          org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution
          org.apache.hadoop.mapreduce.v2.TestUberAM
          org.apache.hadoop.mapreduce.v2.TestMRJobs
          org.apache.hadoop.mapreduce.TestMRJobClient
          org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6062//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6062//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709372/HADOOP-11627-007.patch against trunk revision ef591b1. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.io.compress.TestCodec org.apache.hadoop.mapreduce.v2.TestMRJobsWithProfiler org.apache.hadoop.mapred.TestMRTimelineEventHandling org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService org.apache.hadoop.mapred.pipes.TestPipeApplication org.apache.hadoop.mapred.TestClusterMRNotification The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapred.TestMiniMRChildTask org.apache.hadoop.mapred.TestLazyOutput org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers org.apache.hadoop.mapred.TestJobCleanup org.apache.hadoop.mapreduce.TestLargeSort org.apache.hadoop.mapreduce.TestMapReduceLazyOutput org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution org.apache.hadoop.mapreduce.v2.TestUberAM org.apache.hadoop.mapreduce.v2.TestMRJobs org.apache.hadoop.mapreduce.TestMRJobClient org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6062//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6062//console This message is automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Resubmitting the patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Resubmitting the patch..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Brahma Reddy Battula for updating the patch.

            @Test
            public void testGzipCodecWriteJava() throws IOException {
              testGzipCodecWrite(false);
            }
          
            @Test
            public void testGzipNativeCodecWrite() throws IOException {
              // don't use native libs
              ZlibFactory.setNativeZlibLoaded(false);
              testGzipCodecWrite(true);
            }
          

          Would you move ZlibFactory.setNativeZlibLoaded(false) into testGzipCodecWriteJava()? I'm thinking that fixes the test failure. (https://builds.apache.org/job/PreCommit-HADOOP-Build/6062//testReport/org.apache.hadoop.io.compress/TestCodec/testGzipCodecWriteJava/)

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for updating the patch. @Test public void testGzipCodecWriteJava() throws IOException { testGzipCodecWrite( false ); } @Test public void testGzipNativeCodecWrite() throws IOException { // don't use native libs ZlibFactory.setNativeZlibLoaded( false ); testGzipCodecWrite( true ); } Would you move ZlibFactory.setNativeZlibLoaded(false) into testGzipCodecWriteJava() ? I'm thinking that fixes the test failure. ( https://builds.apache.org/job/PreCommit-HADOOP-Build/6062//testReport/org.apache.hadoop.io.compress/TestCodec/testGzipCodecWriteJava/ )
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks your review..Actually all the testcases are locally passing..Anyway I updated the patch and testcases are locally passing after this patch..Kindly review...

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks your review..Actually all the testcases are locally passing..Anyway I updated the patch and testcases are locally passing after this patch..Kindly review...
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12725955/HADOOP-11627-008.patch
          against trunk revision 80a2a12.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6112//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6112//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725955/HADOOP-11627-008.patch against trunk revision 80a2a12. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6112//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6112//console This message is automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka Kindly review the latest patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka Kindly review the latest patch..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Mostly looks good. One comment:

          +| io.native.lib.available | NONE - By Default native libs will be used for bz2 and zlib compression codecs if available. |
          

          Not only bz2 and zlib but also other native libraries will be always used if available. (Please see HADOOP-8642) Would you change the description such as "NONE - Always use native libraries if available."?
          I'm +1 if that is addressed.

          Show
          ajisakaa Akira Ajisaka added a comment - Mostly looks good. One comment: +| io. native .lib.available | NONE - By Default native libs will be used for bz2 and zlib compression codecs if available. | Not only bz2 and zlib but also other native libraries will be always used if available. (Please see HADOOP-8642 ) Would you change the description such as "NONE - Always use native libraries if available."? I'm +1 if that is addressed.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Attached the one-line updated patch

          Show
          vinayrpet Vinayakumar B added a comment - Attached the one-line updated patch
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 32s Pre-patch trunk site compilation may be broken.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 26s There were no new javac warning messages.
          +1 javadoc 9m 32s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 site 1m 58s Site compilation is broken.
          -1 checkstyle 5m 27s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 2m 19s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 22m 48s Tests passed in hadoop-common.
          -1 mapreduce tests 107m 3s Tests failed in hadoop-mapreduce-client-jobclient.
              175m 35s  



          Reason Tests
          Failed unit tests hadoop.mapred.TestMRIntermediateDataEncryption
          Timed out tests org.apache.hadoop.mapred.TestClusterMapReduceTestCase



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727102/HADOOP-11627-009.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / e71d0d8
          site https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/artifact/patchprocess/patchSiteWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/testReport/
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6144//console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 32s Pre-patch trunk site compilation may be broken. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 26s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 site 1m 58s Site compilation is broken. -1 checkstyle 5m 27s The applied patch generated 1 additional checkstyle issues. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 19s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 48s Tests passed in hadoop-common. -1 mapreduce tests 107m 3s Tests failed in hadoop-mapreduce-client-jobclient.     175m 35s   Reason Tests Failed unit tests hadoop.mapred.TestMRIntermediateDataEncryption Timed out tests org.apache.hadoop.mapred.TestClusterMapReduceTestCase Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727102/HADOOP-11627-009.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / e71d0d8 site https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/artifact/patchprocess/patchSiteWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/artifact/patchprocess/checkstyle-result-diff.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6144/testReport/ Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6144//console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          Looks like YARN-3410 broke YarnCommands.md. Yay for site testing!

          Show
          aw Allen Wittenauer added a comment - Looks like YARN-3410 broke YarnCommands.md. Yay for site testing!
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Test case failures are unrelated to this patch...

          Show
          brahmareddy Brahma Reddy Battula added a comment - Test case failures are unrelated to this patch...
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Test case failures are unrelated to this patch...

          Show
          brahmareddy Brahma Reddy Battula added a comment - Test case failures are unrelated to this patch...
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Can I reopen YARN-3410....? just to fix this one..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Can I reopen YARN-3410 ....? just to fix this one..?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you Allen!

          The number of checkstyle warnings was increased in ZlibFactory. (66 -> 68)
          Newly introduced warnings are as follows:

          <error line="48" column="3" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
          <error line="62" column="3" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
          <error line="63" column="42" severity="error" message="Parameter nativeZlibLoaded should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
          <error line="63" column="50" severity="error" message="&apos;nativeZlibLoaded&apos; hides a field." source="com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck"/>
          

          "Missing a Javadoc comment."

          Would you add javadoc for loadNativeZlib() and setNativeZlibLoaded(boolean)?
          I'm thinking It would be better to add "why the tests call these methods?". For example,

          • loadNativeZlib ... Load native library and set the flag whether to use native library. The method is also used for reset the flag modified by setNativeZlibLoaded.
          • setNativeZlibLoaded ... Set the flag whether to use native library. Used for testing non-native libraries.

          "'natieZlibLoaded'; hides a field."

          public static void setNativeZlibLoaded(boolean nativeZlibLoaded) {
            ZlibFactory.nativeZlibLoaded = nativeZlibLoaded;
          }
          

          The code sets the flag correctly, so I don't think we must fix the warning.
          Hint: Renaming the input variable 'nativeZlibLoaded' to 'isLoaded' or something will fix the warning.

          "Parameter nativeZlibLoaded should be final."

          I'm thinking the parameter should be final.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you Allen! The number of checkstyle warnings was increased in ZlibFactory. (66 -> 68) Newly introduced warnings are as follows: <error line= "48" column= "3" severity= "error" message= "Missing a Javadoc comment." source= "com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck" /> <error line= "62" column= "3" severity= "error" message= "Missing a Javadoc comment." source= "com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck" /> <error line= "63" column= "42" severity= "error" message= "Parameter nativeZlibLoaded should be final ." source= "com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck" /> <error line= "63" column= "50" severity= "error" message= "&apos;nativeZlibLoaded&apos; hides a field." source= "com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck" /> "Missing a Javadoc comment." Would you add javadoc for loadNativeZlib() and setNativeZlibLoaded(boolean) ? I'm thinking It would be better to add "why the tests call these methods?". For example, loadNativeZlib ... Load native library and set the flag whether to use native library. The method is also used for reset the flag modified by setNativeZlibLoaded. setNativeZlibLoaded ... Set the flag whether to use native library. Used for testing non-native libraries. "'natieZlibLoaded'; hides a field." public static void setNativeZlibLoaded( boolean nativeZlibLoaded) { ZlibFactory.nativeZlibLoaded = nativeZlibLoaded; } The code sets the flag correctly, so I don't think we must fix the warning. Hint: Renaming the input variable 'nativeZlibLoaded' to 'isLoaded' or something will fix the warning. "Parameter nativeZlibLoaded should be final." I'm thinking the parameter should be final.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Attached patch for addressing check-style comments...Kindly review..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Attached patch for addressing check-style comments...Kindly review..
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 32s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace.
          +1 javac 7m 29s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 58s Site still builds.
          +1 checkstyle 5m 21s There were no new checkstyle issues.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 findbugs 2m 18s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 23m 17s Tests passed in hadoop-common.
          +1 mapreduce tests 106m 5s Tests passed in hadoop-mapreduce-client-jobclient.
              177m 4s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727550/HADOOP-11627-010.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 18eb5e7
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/testReport/
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 58s Site still builds. +1 checkstyle 5m 21s There were no new checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 2m 18s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 17s Tests passed in hadoop-common. +1 mapreduce tests 106m 5s Tests passed in hadoop-mapreduce-client-jobclient.     177m 4s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727550/HADOOP-11627-010.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 18eb5e7 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/testReport/ Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6164/console This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Attached patch to Address white space ( Even it's not induced )

          Show
          brahmareddy Brahma Reddy Battula added a comment - Attached patch to Address white space ( Even it's not induced )
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 38s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace.
          +1 javac 7m 27s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 56s Site still builds.
          +1 checkstyle 3m 56s There were no new checkstyle issues.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 findbugs 2m 17s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          -1 common tests 36m 45s Tests failed in hadoop-common.
          +1 mapreduce tests 105m 48s Tests passed in hadoop-mapreduce-client-jobclient.
              188m 55s  



          Reason Tests
          Timed out tests org.apache.hadoop.http.TestHttpCookieFlag



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727586/HADOOP-11627-011.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / baf8bc6
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/testReport/
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 56s Site still builds. +1 checkstyle 3m 56s There were no new checkstyle issues. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 2m 17s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 common tests 36m 45s Tests failed in hadoop-common. +1 mapreduce tests 105m 48s Tests passed in hadoop-mapreduce-client-jobclient.     188m 55s   Reason Tests Timed out tests org.apache.hadoop.http.TestHttpCookieFlag Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727586/HADOOP-11627-011.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / baf8bc6 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/testReport/ Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6166/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Looks good to me, +1. The timeout looks unrelated to the patch. Committing this to trunk.

          The patch has 1 line(s) that end in whitespace.

          I'll fix it by git apply -p1 /path/to/the/patch --whitespace=fix.

          Show
          ajisakaa Akira Ajisaka added a comment - Looks good to me, +1. The timeout looks unrelated to the patch. Committing this to trunk. The patch has 1 line(s) that end in whitespace. I'll fix it by git apply -p1 /path/to/the/patch --whitespace=fix .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Brahma Reddy Battula for the continuous work.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Brahma Reddy Battula for the continuous work.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7655 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7655/)
          HADOOP-11627. Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
          • hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7655 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7655/ ) HADOOP-11627 . Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/)
          HADOOP-11627. Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java
          • hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/ ) HADOOP-11627 . Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #164 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/164/)
          HADOOP-11627. Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
          • hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #164 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/164/ ) HADOOP-11627 . Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #173 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/173/)
          HADOOP-11627. Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #173 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/173/ ) HADOOP-11627 . Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #907 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/907/)
          HADOOP-11627. Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
          • hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #907 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/907/ ) HADOOP-11627 . Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/174/)
          HADOOP-11627. Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/174/ ) HADOOP-11627 . Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2123 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2123/)
          HADOOP-11627. Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java
          • hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2123 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2123/ ) HADOOP-11627 . Remove io.native.lib.available. Contributed by Brahma Reddy Battula. (aajisaka: rev ac281e3fc8681e9b421cb5fb442851293766e949) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/Bzip2Factory.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          wenqingChen wenqingChen added a comment -

          Can you help me make a iOS end-to-end encryption plugin?

          Show
          wenqingChen wenqingChen added a comment - Can you help me make a iOS end-to-end encryption plugin?

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development