Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11800

Clean up some test methods in TestCodec.java

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Found two issues when reviewing the patches in HADOOP-11627.
      1. There is no @Test annotation, so the test is not executed.

        public void testCodecPoolAndGzipDecompressor() {
      

      2. The method should be private because it is called from other tests.

        public void testGzipCodecWrite(boolean useNative) throws IOException {
      
      1. HADOOP-11800.patch
        1 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2103 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2103/)
          HADOOP-11800. Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2103 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2103/ ) HADOOP-11800 . Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #154 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/154/)
          HADOOP-11800. Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #154 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/154/ ) HADOOP-11800 . Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2085 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2085/)
          HADOOP-11800. Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2085 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2085/ ) HADOOP-11800 . Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/144/)
          HADOOP-11800. Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/144/ ) HADOOP-11800 . Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #887 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/887/)
          HADOOP-11800. Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #887 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/887/ ) HADOOP-11800 . Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #153 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/153/)
          HADOOP-11800. Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #153 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/153/ ) HADOOP-11800 . Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks Akira!!!

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks Akira!!!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7504 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7504/)
          HADOOP-11800. Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7504 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7504/ ) HADOOP-11800 . Clean up some test methods in TestCodec.java. Contributed by Brahma Reddy Battula. (aajisaka: rev 228ae9aaa40750cb796bbdfd69ba5646c28cd4e7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for the contribution.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12709227/HADOOP-11800.patch
          against trunk revision 72f6bd4.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6058//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6058//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709227/HADOOP-11800.patch against trunk revision 72f6bd4. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6058//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6058//console This message is automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1 pending Jenkins. Thanks Brahma Reddy Battula for taking this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1 pending Jenkins. Thanks Brahma Reddy Battula for taking this.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka Thanks for reporting this jira... Attached the patch..Kindly review...

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka Thanks for reporting this jira... Attached the patch..Kindly review...

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development