Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11473

test-patch says "-1 overall" even when all checks are +1

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None

      Description

      I noticed recently that test-patch is posting "-1 overall" despite all sub-checks being +1. See HDFS-7533 and HDFS-7598 for some examples.

        Issue Links

          Activity

          Hide
          jlowe Jason Lowe added a comment -

          This appears to be caused by HADOOP-11352. A check was removed but the corresponding (( RESULT = RESULT + $? )) code was not. That left two math operations in a row, and the result code of the first is non-zero leading to RESULT being non-zero even when all checks return zero result codes.

          Show
          jlowe Jason Lowe added a comment - This appears to be caused by HADOOP-11352 . A check was removed but the corresponding (( RESULT = RESULT + $? )) code was not. That left two math operations in a row, and the result code of the first is non-zero leading to RESULT being non-zero even when all checks return zero result codes.
          Hide
          jlowe Jason Lowe added a comment -

          Attaching a patch that removes the extra (( RESULT = $RESULT + $? )) code.

          Show
          jlowe Jason Lowe added a comment - Attaching a patch that removes the extra (( RESULT = $RESULT + $? )) code.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12691746/HADOOP-11473.001.patch
          against trunk revision b78b4a1.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5391//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5391//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691746/HADOOP-11473.001.patch against trunk revision b78b4a1. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5391//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5391//console This message is automatically generated.
          Hide
          raviprak Ravi Prakash added a comment -

          lgtm. +1. Will commit shortly.

          Show
          raviprak Ravi Prakash added a comment - lgtm. +1. Will commit shortly.
          Hide
          raviprak Ravi Prakash added a comment -

          I've committed this to trunk. Thanks a lot Jason.

          Show
          raviprak Ravi Prakash added a comment - I've committed this to trunk. Thanks a lot Jason.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6846 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6846/)
          HADOOP-11473. test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6846 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6846/ ) HADOOP-11473 . test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #72 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/72/)
          HADOOP-11473. test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #72 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/72/ ) HADOOP-11473 . test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #806 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/806/)
          HADOOP-11473. test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #806 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/806/ ) HADOOP-11473 . test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #69 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/69/)
          HADOOP-11473. test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #69 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/69/ ) HADOOP-11473 . test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2004 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2004/)
          HADOOP-11473. test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2004 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2004/ ) HADOOP-11473 . test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #73 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/73/)
          HADOOP-11473. test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #73 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/73/ ) HADOOP-11473 . test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2023 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2023/)
          HADOOP-11473. test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2023 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2023/ ) HADOOP-11473 . test-patch says "-1 overall" even when all checks are +1 (raviprak: rev f3507fa35cd5edf7be8945e84beb29965276d80b) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh

            People

            • Assignee:
              jlowe Jason Lowe
              Reporter:
              jlowe Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development