Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11352

Clean up test-patch.sh to disable "+1 contrib tests"

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      Jenkins test-patch.sh always comments as "+1 contrib tests. The patch passed contrib unit tests.", however, the script runs no contrib tests.
      This issue was found when fixing HDFS-7448.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #34 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/34/)
          HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #34 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/34/ ) HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #771 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/771/)
          HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #771 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/771/ ) HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1967 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1967/)
          HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1967 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1967/ ) HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #35 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/35/)
          HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #35 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/35/ ) HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1987 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1987/)
          HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1987 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1987/ ) HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #37 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/37/)
          HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #37 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/37/ ) HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Steve for the review and commit!

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Steve for the review and commit!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6677 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6677/)
          HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6677 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6677/ ) HADOOP-11352 Clean up test-patch.sh to disable "+1 contrib tests" (stevel: rev 82707b44196d63150a8668fa97aa824344b3f9a0) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          stevel@apache.org Steve Loughran added a comment -

          fixed

          Show
          stevel@apache.org Steve Loughran added a comment - fixed
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685264/HADOOP-11352.patch
          against trunk revision 0653918.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5158//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5158//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685264/HADOOP-11352.patch against trunk revision 0653918. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5158//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5158//console This message is automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching a patch to remove runContribTests and checkInjectSystemFaults. The latter is also no-op (always return 0).

          Show
          ajisakaa Akira Ajisaka added a comment - Attaching a patch to remove runContribTests and checkInjectSystemFaults . The latter is also no-op (always return 0).
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The only contrib source is under hadoop-hdfs/src/contrib/bkjournal

          Oh, I was thinking that there were some contrib sources. Thanks for the information.

          the question becomes "why didn't those tests run/get picked up".

          HDFS-7097 did not change bkjournal at all, so the tests were not picked up. HDFS-7448 changed bkjournal test code, so the tests were picked up.

          I suggest removing the script to run contrib tests from test-patch.sh because the script actually does no-op and the jira comment "+1 contrib tests" is confusing.

          Show
          ajisakaa Akira Ajisaka added a comment - The only contrib source is under hadoop-hdfs/src/contrib/bkjournal Oh, I was thinking that there were some contrib sources. Thanks for the information. the question becomes "why didn't those tests run/get picked up". HDFS-7097 did not change bkjournal at all, so the tests were not picked up. HDFS-7448 changed bkjournal test code, so the tests were picked up. I suggest removing the script to run contrib tests from test-patch.sh because the script actually does no-op and the jira comment "+1 contrib tests" is confusing.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          The move to maven including a culling of the contrib directory, which is why it was commented out

          The only contrib source is under hadoop-hdfs/src/contrib/bkjournal...this is referenced in the /hadoop-hdfs-project POM, so the question becomes "why didn't those tests run/get picked up".

          While moving the Maven builds to java7 I have tweaked them to pick up all the surefire-tests/*.xml files, though that doesn't explain why the patch didn't pick up the failure. Maybe it was just that the patch ran on java6 as the HDFS-7448 bug only surfaced on java7+

          Show
          stevel@apache.org Steve Loughran added a comment - The move to maven including a culling of the contrib directory, which is why it was commented out The only contrib source is under hadoop-hdfs/src/contrib/bkjournal ...this is referenced in the /hadoop-hdfs-project POM, so the question becomes "why didn't those tests run/get picked up". While moving the Maven builds to java7 I have tweaked them to pick up all the surefire-tests/*.xml files, though that doesn't explain why the patch didn't pick up the failure. Maybe it was just that the patch ran on java6 as the HDFS-7448 bug only surfaced on java7+

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development