Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11104

org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Passing a negative value to the interval field of MetricsRegistry#newQuantiles should throw a MetricsException with a clear error message. The current stack trace looks something like:

      java.lang.IllegalArgumentException: null
      at java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
      at org.apache.hadoop.metrics2.lib.MutableQuantiles.<init>(MutableQuantiles.java:107)
      at org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)

      Along similar lines, should the other methods like MetricsRegistry#newCounter() also have parameter checking for negative int/long values?

      1. HADOOP-11104.005.patch
        3 kB
        Ray Chiang
      2. HADOOP-11104.004.patch
        3 kB
        Ray Chiang
      3. HADOOP-11104.003.patch
        3 kB
        Ray Chiang
      4. HADOOP-11104.002.patch
        5 kB
        Ray Chiang
      5. HADOOP-11104.001.patch
        5 kB
        Ray Chiang

        Activity

        Hide
        rchiang Ray Chiang added a comment -

        Initial version

        Show
        rchiang Ray Chiang added a comment - Initial version
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12695961/HADOOP-11104.001.patch
        against trunk revision ffc75d6.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//artifact/patchprocess/patchReleaseAuditProblems.txt
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12695961/HADOOP-11104.001.patch against trunk revision ffc75d6. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//artifact/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//console This message is automatically generated.
        Hide
        rchiang Ray Chiang added a comment -

        RE: Release audit

        "Sorting icons.psd" not part of the patch

        Show
        rchiang Ray Chiang added a comment - RE: Release audit "Sorting icons.psd" not part of the patch
        Hide
        rchiang Ray Chiang added a comment -

        It looks like the release audit problem is fixed in YARN-3113.

        Show
        rchiang Ray Chiang added a comment - It looks like the release audit problem is fixed in YARN-3113 .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 32s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace.
        +1 javac 7m 27s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 7m 47s The applied patch generated 1 additional checkstyle issues.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 37s Tests passed in hadoop-common.
            67m 12s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12695961/HADOOP-11104.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2e21548
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/whitespace.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/checkstyle-result-diff.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 7m 47s The applied patch generated 1 additional checkstyle issues. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 37s Tests passed in hadoop-common.     67m 12s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12695961/HADOOP-11104.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2e21548 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/whitespace.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/checkstyle-result-diff.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/console This message was automatically generated.
        Hide
        rchiang Ray Chiang added a comment -

        Fix whitespace issues.

        Show
        rchiang Ray Chiang added a comment - Fix whitespace issues.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 3m 58s There were no new checkstyle issues.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 0s Tests passed in hadoop-common.
            63m 4s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729533/HADOOP-11104.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / de9404f
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 3m 58s There were no new checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 0s Tests passed in hadoop-common.     63m 4s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729533/HADOOP-11104.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / de9404f hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Ray Chiang for the report and the patch.
        I agree with you that we should check if the interval for Quantiles is positive and throw a clear error message. For Counter, Gauge and Stats, I'm thinking we don't need to check the initial value because they works well even if the initial value is negative.

        +    if (interval < 0) {
        +      throw new MetricsException("Illegal interval: " + interval);
        +    }
        
        • It would be better to add to the message that the interval should be positive, and document to the javadoc that the method will throw MetricsException if the interval is not more than 0.
        • interval < 0 should be interval <= 0.
        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang for the report and the patch. I agree with you that we should check if the interval for Quantiles is positive and throw a clear error message. For Counter, Gauge and Stats, I'm thinking we don't need to check the initial value because they works well even if the initial value is negative. + if (interval < 0) { + throw new MetricsException( "Illegal interval: " + interval); + } It would be better to add to the message that the interval should be positive, and document to the javadoc that the method will throw MetricsException if the interval is not more than 0. interval < 0 should be interval <= 0 .
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Cancelling the patch for the comment.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Cancelling the patch for the comment.
        Hide
        rchiang Ray Chiang added a comment -

        Update with Akira's suggestions.

        Show
        rchiang Ray Chiang added a comment - Update with Akira's suggestions.
        Hide
        rchiang Ray Chiang added a comment -

        Forgot to submit patch.

        Show
        rchiang Ray Chiang added a comment - Forgot to submit patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 24m 30s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 10m 48s There were no new javac warning messages.
        +1 javadoc 14m 48s There were no new javadoc warning messages.
        +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 38s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 2m 15s mvn install still works.
        +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse.
        +1 findbugs 2m 43s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 28m 22s Tests failed in hadoop-common.
            86m 19s  



        Reason Tests
        Failed unit tests hadoop.ha.TestZKFailoverController



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12761524/HADOOP-11104.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / cc2b473
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 24m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 10m 48s There were no new javac warning messages. +1 javadoc 14m 48s There were no new javadoc warning messages. +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 38s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 2m 15s mvn install still works. +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse. +1 findbugs 2m 43s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 28m 22s Tests failed in hadoop-common.     86m 19s   Reason Tests Failed unit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761524/HADOOP-11104.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cc2b473 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/console This message was automatically generated.
        Hide
        rchiang Ray Chiang added a comment -

        RE: Failed unit test

        TestZKFailoverController passes in my tree.

        Show
        rchiang Ray Chiang added a comment - RE: Failed unit test TestZKFailoverController passes in my tree.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, thanks Ray Chiang for updating the patch.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, thanks Ray Chiang for updating the patch.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Cancelling my +1, Ray Chiang would you render the lines within 80 characters?

        +    expectMetricsException("Interval should be positive.  Value passed is: -20", new Runnable() {
        +      @Override
        +      public void run() { r.newQuantiles("q1", "New Quantile 1", "qq1", "qv1", (int)-20); }
        +    });
        

        I'm +1 if that is addressed. Sorry for late response.

        Show
        ajisakaa Akira Ajisaka added a comment - Cancelling my +1, Ray Chiang would you render the lines within 80 characters? + expectMetricsException( "Interval should be positive. Value passed is: -20" , new Runnable () { + @Override + public void run() { r.newQuantiles( "q1" , "New Quantile 1" , "qq1" , "qv1" , ( int )-20); } + }); I'm +1 if that is addressed. Sorry for late response.
        Hide
        rchiang Ray Chiang added a comment -
        • Fixed whitespace
        Show
        rchiang Ray Chiang added a comment - Fixed whitespace
        Hide
        rchiang Ray Chiang added a comment -

        No problem. I could swear that I did that before, but I must have misplaced a patch somewhere. Thanks for catching it.

        Show
        rchiang Ray Chiang added a comment - No problem. I could swear that I did that before, but I must have misplaced a patch somewhere. Thanks for catching it.
        Hide
        rchiang Ray Chiang added a comment -

        Ugh, meaning I fixed line length, not whitespace.

        Show
        rchiang Ray Chiang added a comment - Ugh, meaning I fixed line length, not whitespace.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 55s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 49s There were no new javac warning messages.
        +1 javadoc 10m 5s There were no new javadoc warning messages.
        -1 release audit 0m 16s The applied patch generated 1 release audit warnings.
        +1 checkstyle 1m 4s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 7m 35s Tests failed in hadoop-common.
            47m 41s  



        Reason Tests
        Failed unit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.fs.shell.TestCopyPreserveFlag



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764648/HADOOP-11104.004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / ecbfd68
        Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 55s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 49s There were no new javac warning messages. +1 javadoc 10m 5s There were no new javadoc warning messages. -1 release audit 0m 16s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 7m 35s Tests failed in hadoop-common.     47m 41s   Reason Tests Failed unit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.shell.TestCopyPreserveFlag Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764648/HADOOP-11104.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ecbfd68 Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/console This message was automatically generated.
        Hide
        rchiang Ray Chiang added a comment -

        RE: Release audit

        "Missing Apache header" in /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/CHANGES-HDFS-EC-7285.txt. This patch does not modify this file.

        RE: Failed unit tests

        Both tests pass in my tree.

        Show
        rchiang Ray Chiang added a comment - RE: Release audit "Missing Apache header" in /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/CHANGES-HDFS-EC-7285.txt. This patch does not modify this file. RE: Failed unit tests Both tests pass in my tree.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Ray Chiang for updating the patch!

        +      public void run() { r.newQuantiles("q1", "New Quantile 1", "qq1", "qv1", (int)-20); }
        

        The line is longer than 80 characters, so would you please render the line? In addition, you don't need to specify (int) there.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang for updating the patch! + public void run() { r.newQuantiles( "q1" , "New Quantile 1" , "qq1" , "qv1" , ( int )-20); } The line is longer than 80 characters, so would you please render the line? In addition, you don't need to specify (int) there.
        Hide
        rchiang Ray Chiang added a comment -
        • Fixes line length based on feedback
        Show
        rchiang Ray Chiang added a comment - Fixes line length based on feedback
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 23s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 9m 13s There were no new javac warning messages.
        +1 javadoc 11m 31s There were no new javadoc warning messages.
        -1 release audit 0m 20s The applied patch generated 1 release audit warnings.
        +1 checkstyle 1m 17s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 2m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 7m 45s Tests passed in hadoop-common.
            54m 51s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12765669/HADOOP-11104.005.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0841940
        Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 23s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 9m 13s There were no new javac warning messages. +1 javadoc 11m 31s There were no new javadoc warning messages. -1 release audit 0m 20s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 17s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 7m 45s Tests passed in hadoop-common.     54m 51s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765669/HADOOP-11104.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0841940 Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1

        Show
        ajisakaa Akira Ajisaka added a comment - +1
        Hide
        ajisakaa Akira Ajisaka added a comment -

        The release audit warning is not related to the patch. I've committed this to trunk and branch-2. Thanks Ray Chiang for your contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - The release audit warning is not related to the patch. I've committed this to trunk and branch-2. Thanks Ray Chiang for your contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8598 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8598/)
        HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8598 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8598/ ) HADOOP-11104 . org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2446 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2446/)
        HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2446 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2446/ ) HADOOP-11104 . org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1239 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1239/)
        HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1239 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1239/ ) HADOOP-11104 . org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #474 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/474/)
        HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #474 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/474/ ) HADOOP-11104 . org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #502 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/502/)
        HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #502 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/502/ ) HADOOP-11104 . org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #512 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/512/)
        HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #512 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/512/ ) HADOOP-11104 . org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
        Hide
        rchiang Ray Chiang added a comment -

        Thanks for the commit and reviews!

        Show
        rchiang Ray Chiang added a comment - Thanks for the commit and reviews!

          People

          • Assignee:
            rchiang Ray Chiang
            Reporter:
            rchiang Ray Chiang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development