[HADOOP-11104] org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Labels: newbie supportability
• Hadoop Flags: Reviewed
• Assignee: Ray Chiang
• Reporter: Ray Chiang
• Created: 18/Sep/14 05:40
• Updated: 30/Aug/16 01:31
• Resolved: 09/Oct/15 02:12

Description

Passing a negative value to the interval field of MetricsRegistry#newQuantiles should throw a MetricsException with a clear error message. The current stack trace looks something like:

java.lang.IllegalArgumentException: null
at java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
at org.apache.hadoop.metrics2.lib.MutableQuantiles.<init>(MutableQuantiles.java:107)
at org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)

Along similar lines, should the other methods like MetricsRegistry#newCounter() also have parameter checking for negative int/long values?