Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      jenkins patchprocess links of the form https://builds.apache.org/job/PreCommit-HADOOP-Build/<build_id>//artifact/trunk/patchprocess/diffJavadocWarnings.txt and so forth are dead links. We should fix them to reflect the new source layout after git.

      1. HADOOP-11084.001.patch
        3 kB
        Colin P. McCabe
      2. HADOOP-11084.002.patch
        0.7 kB
        Arpit Agarwal
      3. HADOOP-11084.003.patch
        2 kB
        Arpit Agarwal

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12667894/HADOOP-11084.001.patch
          against trunk revision 5ec7fcd.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.
          See https://builds.apache.org/job/PreCommit-HADOOP-Build/4694//artifact/trunk/patchprocess/diffJavadocWarnings.txt for details.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-nfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4694//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4694//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12667894/HADOOP-11084.001.patch against trunk revision 5ec7fcd. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. See https://builds.apache.org/job/PreCommit-HADOOP-Build/4694//artifact/trunk/patchprocess/diffJavadocWarnings.txt for details. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4694//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4694//console This message is automatically generated.
          Hide
          kkambatl Karthik Kambatla (Inactive) added a comment -

          We should other builds too - HDFS, YARN, MapReduce

          Show
          kkambatl Karthik Kambatla (Inactive) added a comment - We should other builds too - HDFS, YARN, MapReduce
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1 committed. I left out the javadoc change

          Show
          stevel@apache.org Steve Loughran added a comment - +1 committed. I left out the javadoc change
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Steve Loughran. I hope that this fixes things... unfortunately it's tough to test this kind of change since jenkins runs with the previous test-patch.sh.

          Karthik Kambatla: I'm not sure how test-patch.sh could deal with the patchJavacWarnings.txt file showing up in a different directory than PreCommit-HADOOP-Build-patchprocess. I guess one way we could do it is by adding a new environment variable that Jenkins passes in to test-patch.sh. The other way is we could do a search through path components of $PATCH_DIR for directories ending in 'patchprocess' and symlink the first one we found to 'patchprocess' (effectively restoring the old scheme where this was always under $BUILD_URL/artifact/patchprocess/diffJavadocWarnings.txt).

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Steve Loughran . I hope that this fixes things... unfortunately it's tough to test this kind of change since jenkins runs with the previous test-patch.sh . Karthik Kambatla : I'm not sure how test-patch.sh could deal with the patchJavacWarnings.txt file showing up in a different directory than PreCommit-HADOOP-Build-patchprocess . I guess one way we could do it is by adding a new environment variable that Jenkins passes in to test-patch.sh . The other way is we could do a search through path components of $PATCH_DIR for directories ending in 'patchprocess' and symlink the first one we found to 'patchprocess' (effectively restoring the old scheme where this was always under $BUILD_URL/artifact/patchprocess/diffJavadocWarnings.txt ).
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #685 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/685/)
          HADOOP-11084 jenkins patchprocess links are broken (stevel: rev 474f116f57b9f8467226b739f4d6a660882e923a)

          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #685 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/685/ ) HADOOP-11084 jenkins patchprocess links are broken (stevel: rev 474f116f57b9f8467226b739f4d6a660882e923a) dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1901 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1901/)
          HADOOP-11084 jenkins patchprocess links are broken (stevel: rev 474f116f57b9f8467226b739f4d6a660882e923a)

          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1901 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1901/ ) HADOOP-11084 jenkins patchprocess links are broken (stevel: rev 474f116f57b9f8467226b739f4d6a660882e923a) dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1876 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1876/)
          HADOOP-11084 jenkins patchprocess links are broken (stevel: rev 474f116f57b9f8467226b739f4d6a660882e923a)

          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1876 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1876/ ) HADOOP-11084 jenkins patchprocess links are broken (stevel: rev 474f116f57b9f8467226b739f4d6a660882e923a) dev-support/test-patch.sh
          Hide
          cmccabe Colin P. McCabe added a comment -

          Is there any possibility that we could start putting stuff in:

          $BASE_URL/<build_id>//artifact/trunk/patchprocess/diffJavadocWarnings.txt
          

          again?

          Since the $BASE_URL already contains a string like "PreCommit-HADOOP-Build", it seems like putting that string another time into the path doesn't add any more information, and makes it really hard to write a correct script to locate the build products. What do you guys think?

          Show
          cmccabe Colin P. McCabe added a comment - Is there any possibility that we could start putting stuff in: $BASE_URL/<build_id> //artifact/trunk/patchprocess/diffJavadocWarnings.txt again? Since the $BASE_URL already contains a string like "PreCommit-HADOOP-Build", it seems like putting that string another time into the path doesn't add any more information, and makes it really hard to write a correct script to locate the build products. What do you guys think?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          If it's easier to do, go back to it. I'll update jenkins with whatever values you want added

          Show
          stevel@apache.org Steve Loughran added a comment - If it's easier to do, go back to it. I'll update jenkins with whatever values you want added
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Patch to fix the findbugs link.

          Show
          arpitagarwal Arpit Agarwal added a comment - Patch to fix the findbugs link.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12671738/HADOOP-11084.002.patch
          against trunk revision b38e52b.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4823//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4823//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671738/HADOOP-11084.002.patch against trunk revision b38e52b. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4823//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4823//console This message is automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          I noticed that there are still a lot of "PreCommit-HADOOP-Build-patchprocess" strings in test-patch.sh, should all of these be updated to be just "patchprocess"? e.g. javac, rat.

          Show
          andrew.wang Andrew Wang added a comment - I noticed that there are still a lot of "PreCommit-HADOOP-Build-patchprocess" strings in test-patch.sh, should all of these be updated to be just "patchprocess"? e.g. javac, rat.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Wasn't very sure about those since I didn't have examples of good links to compare against for Javadoc, rat and javac warnings.

          Updated patch to fix them also.

          Show
          arpitagarwal Arpit Agarwal added a comment - Wasn't very sure about those since I didn't have examples of good links to compare against for Javadoc, rat and javac warnings. Updated patch to fix them also.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks Arpit, I can provide one of my recent runs as an example:

          https://issues.apache.org/jira/browse/HDFS-7077?focusedCommentId=14147555&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14147555

          The new URL worked for these javac and rat links, so I think it's correct.

          Show
          andrew.wang Andrew Wang added a comment - Thanks Arpit, I can provide one of my recent runs as an example: https://issues.apache.org/jira/browse/HDFS-7077?focusedCommentId=14147555&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14147555 The new URL worked for these javac and rat links, so I think it's correct.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for the link and verification Andrew.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for the link and verification Andrew.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12671828/HADOOP-11084.003.patch
          against trunk revision 84b9c63.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4827//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4827//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671828/HADOOP-11084.003.patch against trunk revision 84b9c63. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4827//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4827//console This message is automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 LGTM

          Show
          andrew.wang Andrew Wang added a comment - +1 LGTM
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thank you for the quick review. I committed it to trunk.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thank you for the quick review. I committed it to trunk.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6141 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6141/)
          HADOOP-11084. Jenkins patchprocess links are broken. (Arpit Agarwal) (arp: rev 9e985e6b9432725dc6ee702333a257e05e357957)

          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6141 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6141/ ) HADOOP-11084 . Jenkins patchprocess links are broken. (Arpit Agarwal) (arp: rev 9e985e6b9432725dc6ee702333a257e05e357957) dev-support/test-patch.sh
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Arpit Agarwal.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Arpit Agarwal .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #696 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/696/)
          HADOOP-11084. Jenkins patchprocess links are broken. (Arpit Agarwal) (arp: rev 9e985e6b9432725dc6ee702333a257e05e357957)

          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #696 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/696/ ) HADOOP-11084 . Jenkins patchprocess links are broken. (Arpit Agarwal) (arp: rev 9e985e6b9432725dc6ee702333a257e05e357957) dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1887 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1887/)
          HADOOP-11084. Jenkins patchprocess links are broken. (Arpit Agarwal) (arp: rev 9e985e6b9432725dc6ee702333a257e05e357957)

          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1887 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1887/ ) HADOOP-11084 . Jenkins patchprocess links are broken. (Arpit Agarwal) (arp: rev 9e985e6b9432725dc6ee702333a257e05e357957) dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1912 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1912/)
          HADOOP-11084. Jenkins patchprocess links are broken. (Arpit Agarwal) (arp: rev 9e985e6b9432725dc6ee702333a257e05e357957)

          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1912 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1912/ ) HADOOP-11084 . Jenkins patchprocess links are broken. (Arpit Agarwal) (arp: rev 9e985e6b9432725dc6ee702333a257e05e357957) dev-support/test-patch.sh
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Hi, the links about findbugs are sometimes broken on some jiras(e.g. YARN-2312, HADOOP-11032). On my local environment, I confirmed that I cannot find the findbugs warning with the patches. Do you have any idea about this problem?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Hi, the links about findbugs are sometimes broken on some jiras(e.g. YARN-2312 , HADOOP-11032 ). On my local environment, I confirmed that I cannot find the findbugs warning with the patches. Do you have any idea about this problem?
          Hide
          cmccabe Colin P. McCabe added a comment -

          Hi, the links about findbugs are sometimes broken on some jiras(e.g. YARN-2312, HADOOP-11032). On my local environment, I confirmed that I cannot find the findbugs warning with the patches. Do you have any idea about this problem?

          I don't know what's going on on HADOOP-11032, but it's weird. From looking at the console, the build aborted in the middle with "hudson.remoting.RequestAbortedException: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel". This looks a lot like a Jenkins / build host problem... someone with shell access might need to look into why we've been hitting so many of these failures recently. I don't think it's a test-patch.sh problem since the whole patchprocess dir seems to be missing (build aborted in the middle before it could be created?)

          Show
          cmccabe Colin P. McCabe added a comment - Hi, the links about findbugs are sometimes broken on some jiras(e.g. YARN-2312 , HADOOP-11032 ). On my local environment, I confirmed that I cannot find the findbugs warning with the patches. Do you have any idea about this problem? I don't know what's going on on HADOOP-11032 , but it's weird. From looking at the console, the build aborted in the middle with "hudson.remoting.RequestAbortedException: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel". This looks a lot like a Jenkins / build host problem... someone with shell access might need to look into why we've been hitting so many of these failures recently. I don't think it's a test-patch.sh problem since the whole patchprocess dir seems to be missing (build aborted in the middle before it could be created?)
          Hide
          yzhangal Yongjun Zhang added a comment -

          HI Guys,

          Thanks for the earlier discussion and work on this issue. I am seeing invalid link:

          https://builds.apache.org/job/PreCommit-HADOOP-Build/4975//artifact/patchprocess/diffJavacWarnings.txt

          So looks like something is still broken. Would anyone please take a further look? I can create a new jira if necessary.

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - HI Guys, Thanks for the earlier discussion and work on this issue. I am seeing invalid link: https://builds.apache.org/job/PreCommit-HADOOP-Build/4975//artifact/patchprocess/diffJavacWarnings.txt So looks like something is still broken. Would anyone please take a further look? I can create a new jira if necessary. Thanks.
          Hide
          andrew.wang Andrew Wang added a comment -

          Hi Yongjun, I made some additional edits yesterday to try and fix this, and I see that recent runs do have correct artifacts, e.g.

          https://builds.apache.org/job/PreCommit-HADOOP-Build/4978/

          So, I think things are working. If you still see broken links or missing artifacts in future builds, please ping us again.

          Show
          andrew.wang Andrew Wang added a comment - Hi Yongjun, I made some additional edits yesterday to try and fix this, and I see that recent runs do have correct artifacts, e.g. https://builds.apache.org/job/PreCommit-HADOOP-Build/4978/ So, I think things are working. If you still see broken links or missing artifacts in future builds, please ping us again.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks a lot Andrew Wang!

          Show
          yzhangal Yongjun Zhang added a comment - Thanks a lot Andrew Wang !
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Andrew. It's good to have those URLs working again.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Andrew. It's good to have those URLs working again.

            People

            • Assignee:
              arpitagarwal Arpit Agarwal
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development