[HADOOP-10829] Iteration on CredentialProviderFactory.serviceLoader is thread-unsafe

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.9.0, 2.7.4, 3.0.0-beta1, 2.8.2
• Component/s: security
• Labels: BB2015-05-TBR
• Target Version/s: 2.7.4
• Assignee: Benoy Antony
• Reporter: Benoy Antony
• Created: 15/Jul/14 17:00
• Updated: 31/Aug/17 23:26
• Resolved: 11/Jul/17 01:01

Description

CredentialProviderFactory uses ServiceLoader framework to load CredentialProviderFactory

  private static final ServiceLoader<CredentialProviderFactory> serviceLoader =
      ServiceLoader.load(CredentialProviderFactory.class);

The ServiceLoader framework does lazy initialization of services which makes it thread unsafe. If accessed from multiple threads, it is better to synchronize the access.
Similar synchronization has been done while loading compression codec providers via HADOOP-8406.

Issue Links

• is related to: HADOOP-10607 Create an API to Separate Credentials/Password Storage from Applications
• is related to: HADOOP-10826 Iteration on KeyProviderFactory.serviceLoader is thread-unsafe