Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10776

Open up already widely-used APIs for delegation-token fetching & renewal to ecosystem projects

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Storm would like to be able to fetch delegation tokens and forward them on to running topologies so that they can access HDFS (STORM-346). But to do so we need to open up access to some of APIs.

      Most notably FileSystem.addDelegationTokens(), Token.renew, Credentials.getAllTokens, and UserGroupInformation but there may be others.

      At a minimum adding in storm to the list of allowed API users. But ideally making them public. Restricting access to such important functionality to just MR really makes secure HDFS inaccessible to anything except MR, or tools that reuse MR input formats.

      1. HADOOP-10776-20160822.txt
        7 kB
        Vinod Kumar Vavilapalli
      2. HADOOP-10776-branch-2-002.patch
        8 kB
        Steve Loughran
      3. HADOOP-10776-branch-2-003.patch
        10 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -

          Hi, Robert Joseph Evans. I am +1 for the proposal to make the necessary APIs public. I think it's the practical choice at this point. If we consider the example of FileSystem#addDelegationTokens, the method was added 2 years ago for 2.0.2-alpha, and the signature has not changed since then. That indicates stability. I also know that other projects have called this method despite the limited-private risk, so that's another sign that there is a general need for a public interface for using delegation tokens.

          Show
          cnauroth Chris Nauroth added a comment - Hi, Robert Joseph Evans . I am +1 for the proposal to make the necessary APIs public. I think it's the practical choice at this point. If we consider the example of FileSystem#addDelegationTokens , the method was added 2 years ago for 2.0.2-alpha, and the signature has not changed since then. That indicates stability. I also know that other projects have called this method despite the limited-private risk, so that's another sign that there is a general need for a public interface for using delegation tokens.
          Hide
          cnauroth Chris Nauroth added a comment -

          I am tentatively making this a blocker for 2.8.0. I think we are at a point where we need to treat these as Public whether we like it or not.

          Show
          cnauroth Chris Nauroth added a comment - I am tentatively making this a blocker for 2.8.0. I think we are at a point where we need to treat these as Public whether we like it or not.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 on marking them public. Apart from downstream projects many applications have come to rely on these interfaces.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 on marking them public. Apart from downstream projects many applications have come to rely on these interfaces.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Can someone do a patch for this for 2.8+?

          Show
          stevel@apache.org Steve Loughran added a comment - Can someone do a patch for this for 2.8+?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Taking a quick crack at making some of the already very widely used security related class public.

          The patch makes the following public

          • Classes: AccessControlException, Credentials, UserGroupInformation, AuthorizationException, Token.TrivialRenewer, AbstractDelegationTokenIdentifier, AbstractDelegationTokenSecretManager
          • Methods: FileSystem.getCanonicalServiceName(), FileSystem.addDelegationTokens()

          Couple of general notes

          • I'd like to skip the evolving vs public discussion for now and focus only on visibility - so I just marked everything evolving.
          • I did a quick search and obviously there are a lot more classes that need more careful thinking. Unless I've missed some of the very obvious ones, I'd like to make progress on getting the current ones done first.

          Robert Joseph Evans, Chris Nauroth, Arpit Agarwal, can one or more of you quickly look at this? Shouldn't take more than 5-10 minutes.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Taking a quick crack at making some of the already very widely used security related class public. The patch makes the following public Classes: AccessControlException, Credentials, UserGroupInformation, AuthorizationException, Token.TrivialRenewer, AbstractDelegationTokenIdentifier, AbstractDelegationTokenSecretManager Methods: FileSystem.getCanonicalServiceName(), FileSystem.addDelegationTokens() Couple of general notes I'd like to skip the evolving vs public discussion for now and focus only on visibility - so I just marked everything evolving. I did a quick search and obviously there are a lot more classes that need more careful thinking. Unless I've missed some of the very obvious ones, I'd like to make progress on getting the current ones done first. Robert Joseph Evans , Chris Nauroth , Arpit Agarwal , can one or more of you quickly look at this? Shouldn't take more than 5-10 minutes.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          And /cc'ing Steve Loughran too.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - And /cc'ing Steve Loughran too.
          Hide
          elserj Josh Elser added a comment -

          Vinod Kumar Vavilapalli, was avoiding o.a.h.s.token.SecretManager (and only opening up AbstractDelegationTokenSecretManager) intentional? A quick grep on one downstream project where I wired up delegation support shows that I had used SecretManager directly (which can probably be assumed that I copied it from another project).

          Although, if AbstractDelegationTokenSecretManager is Public, there are still some abstract methods on SecretManager that I'd need to implement when extending AbstractDelegationTokenSecretManager (which are still LimitedPrivate).

          Show
          elserj Josh Elser added a comment - Vinod Kumar Vavilapalli , was avoiding o.a.h.s.token.SecretManager (and only opening up AbstractDelegationTokenSecretManager) intentional? A quick grep on one downstream project where I wired up delegation support shows that I had used SecretManager directly (which can probably be assumed that I copied it from another project). Although, if AbstractDelegationTokenSecretManager is Public, there are still some abstract methods on SecretManager that I'd need to implement when extending AbstractDelegationTokenSecretManager (which are still LimitedPrivate).
          Hide
          cnauroth Chris Nauroth added a comment -

          Vinod Kumar Vavilapalli, thank you for picking this up. The patch looks good to me. My only request is that you add a change in SecurityUtil to mark that one Public too. That class already gets used a lot in other projects. I'll be +1 after that change.

          I think we'll want to review usage and annotations on the web auth stuff too, but this much is plenty to get in for a 2.8.0 release.

          Show
          cnauroth Chris Nauroth added a comment - Vinod Kumar Vavilapalli , thank you for picking this up. The patch looks good to me. My only request is that you add a change in SecurityUtil to mark that one Public too. That class already gets used a lot in other projects. I'll be +1 after that change. I think we'll want to review usage and annotations on the web auth stuff too, but this much is plenty to get in for a 2.8.0 release.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hello Josh Elser. SecretManager is Public and Evolving in branch-2.8, so we won't need a change there. (That's an easy thing to miss in diff-based reviews like this.) Thank you for your code review.

          Show
          cnauroth Chris Nauroth added a comment - Hello Josh Elser . SecretManager is Public and Evolving in branch-2.8, so we won't need a change there. (That's an easy thing to miss in diff-based reviews like this.) Thank you for your code review.
          Hide
          elserj Josh Elser added a comment -

          Oops! Sorry for the chatter. Should have gone to the correct version instead of letting my editor just show me a recent one.

          Show
          elserj Josh Elser added a comment - Oops! Sorry for the chatter. Should have gone to the correct version instead of letting my editor just show me a recent one.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 52s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 20s trunk passed
          +1 javadoc 0m 46s trunk passed
          +1 mvninstall 0m 38s the patch passed
          +1 compile 6m 55s the patch passed
          +1 javac 6m 55s the patch passed
          -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 2 new + 285 unchanged - 3 fixed = 287 total (was 288)
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 29s the patch passed
          -1 javadoc 0m 46s hadoop-common-project_hadoop-common generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
          -1 unit 7m 42s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          38m 15s



          Reason Tests
          Failed junit tests hadoop.ipc.TestRPC



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824914/HADOOP-10776-20160822.txt
          JIRA Issue HADOOP-10776
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d66198e913f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dc7a1c5
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. 0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 38s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 6m 55s the patch passed +1 javac 6m 55s the patch passed -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 2 new + 285 unchanged - 3 fixed = 287 total (was 288) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed -1 javadoc 0m 46s hadoop-common-project_hadoop-common generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) -1 unit 7m 42s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 15s Reason Tests Failed junit tests hadoop.ipc.TestRPC Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824914/HADOOP-10776-20160822.txt JIRA Issue HADOOP-10776 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d66198e913f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dc7a1c5 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10335/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Hi Vinod, this one looks pretty close based on Chris' last review. Think we can get it in soon?

          Show
          andrew.wang Andrew Wang added a comment - Hi Vinod, this one looks pretty close based on Chris' last review. Think we can get it in soon?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 002; patch 001 with SecurityUtils

          Show
          stevel@apache.org Steve Loughran added a comment - Patch 002; patch 001 with SecurityUtils
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 29s branch-2 passed
          +1 compile 5m 34s branch-2 passed with JDK v1.8.0_111
          +1 compile 6m 30s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 0m 29s branch-2 passed
          +1 mvnsite 0m 59s branch-2 passed
          +1 mvneclipse 0m 15s branch-2 passed
          +1 findbugs 1m 41s branch-2 passed
          +1 javadoc 0m 45s branch-2 passed with JDK v1.8.0_111
          +1 javadoc 0m 56s branch-2 passed with JDK v1.7.0_111
          +1 mvninstall 0m 39s the patch passed
          +1 compile 5m 28s the patch passed with JDK v1.8.0_111
          +1 javac 5m 28s the patch passed
          +1 compile 6m 33s the patch passed with JDK v1.7.0_111
          +1 javac 6m 33s the patch passed
          -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 4 new + 266 unchanged - 5 fixed = 270 total (was 271)
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 54s the patch passed
          -1 javadoc 0m 45s hadoop-common-project_hadoop-common-jdk1.8.0_111 with JDK v1.8.0_111 generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
          -1 javadoc 0m 58s hadoop-common-project_hadoop-common-jdk1.7.0_111 with JDK v1.7.0_111 generated 5 new + 7 unchanged - 0 fixed = 12 total (was 7)
          +1 unit 8m 20s hadoop-common in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          60m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HADOOP-10776
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840421/HADOOP-10776-branch-2-002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b8a5ff604d11 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / c28dc5e
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_111.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 29s branch-2 passed +1 compile 5m 34s branch-2 passed with JDK v1.8.0_111 +1 compile 6m 30s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 0m 59s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 41s branch-2 passed +1 javadoc 0m 45s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 56s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 39s the patch passed +1 compile 5m 28s the patch passed with JDK v1.8.0_111 +1 javac 5m 28s the patch passed +1 compile 6m 33s the patch passed with JDK v1.7.0_111 +1 javac 6m 33s the patch passed -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 4 new + 266 unchanged - 5 fixed = 270 total (was 271) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed -1 javadoc 0m 45s hadoop-common-project_hadoop-common-jdk1.8.0_111 with JDK v1.8.0_111 generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) -1 javadoc 0m 58s hadoop-common-project_hadoop-common-jdk1.7.0_111 with JDK v1.7.0_111 generated 5 new + 7 unchanged - 0 fixed = 12 total (was 7) +1 unit 8m 20s hadoop-common in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 60m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-10776 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840421/HADOOP-10776-branch-2-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b8a5ff604d11 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c28dc5e Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_111.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11130/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          patch 003 address some of the checkstyle/javadoc warnings.

          Show
          stevel@apache.org Steve Loughran added a comment - patch 003 address some of the checkstyle/javadoc warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 18s branch-2 passed
          +1 compile 6m 14s branch-2 passed with JDK v1.8.0_111
          +1 compile 6m 41s branch-2 passed with JDK v1.7.0_121
          +1 checkstyle 0m 29s branch-2 passed
          +1 mvnsite 0m 58s branch-2 passed
          +1 mvneclipse 0m 16s branch-2 passed
          +1 findbugs 1m 40s branch-2 passed
          +1 javadoc 0m 46s branch-2 passed with JDK v1.8.0_111
          +1 javadoc 0m 59s branch-2 passed with JDK v1.7.0_121
          +1 mvninstall 0m 42s the patch passed
          +1 compile 6m 43s the patch passed with JDK v1.8.0_111
          +1 javac 6m 43s the patch passed
          +1 compile 6m 45s the patch passed with JDK v1.7.0_121
          +1 javac 6m 45s the patch passed
          -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 2 new + 266 unchanged - 5 fixed = 268 total (was 271)
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 0m 46s the patch passed with JDK v1.8.0_111
          +1 javadoc 0m 57s the patch passed with JDK v1.7.0_121
          +1 unit 7m 58s hadoop-common in the patch passed with JDK v1.7.0_121.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          63m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HADOOP-10776
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840439/HADOOP-10776-branch-2-003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 91056b5db6aa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / c28dc5e
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11134/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11134/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11134/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 18s branch-2 passed +1 compile 6m 14s branch-2 passed with JDK v1.8.0_111 +1 compile 6m 41s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 0m 58s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed +1 findbugs 1m 40s branch-2 passed +1 javadoc 0m 46s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 59s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 42s the patch passed +1 compile 6m 43s the patch passed with JDK v1.8.0_111 +1 javac 6m 43s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_121 +1 javac 6m 45s the patch passed -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 2 new + 266 unchanged - 5 fixed = 268 total (was 271) +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 46s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 57s the patch passed with JDK v1.7.0_121 +1 unit 7m 58s hadoop-common in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 63m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-10776 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840439/HADOOP-10776-branch-2-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 91056b5db6aa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c28dc5e Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11134/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11134/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11134/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          1 to Vinod's patch with my minor changes; committing to branch-2.8

          Show
          stevel@apache.org Steve Loughran added a comment - 1 to Vinod's patch with my minor changes; committing to branch-2.8
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10890 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10890/)
          HADOOP-10776 Open up already widely-used APIs for delegation-token (stevel: rev 01665e456de8d79000ce273dded5ea53aa62965a)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/AccessControlException.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/AuthorizationException.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Credentials.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10890 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10890/ ) HADOOP-10776 Open up already widely-used APIs for delegation-token (stevel: rev 01665e456de8d79000ce273dded5ea53aa62965a) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/AccessControlException.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/AuthorizationException.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Credentials.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java

            People

            • Assignee:
              vinodkv Vinod Kumar Vavilapalli
              Reporter:
              revans2 Robert Joseph Evans
            • Votes:
              1 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development