[GUACAMOLE-732] navigator.mediaDevices.getUserMedia() returns a promises

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.2.0
• Component/s: guacamole-common-js
• Labels: newbie patch
• Assignee: Mike Jumper
• Reporter: Fabian Spieß
• Created: 12/Feb/19 14:53
• Updated: 17/Jun/20 17:49
• Resolved: 25/Dec/19 04:58

Description

navigator.mediaDevices.getUserMedia() in Line 426 of the AudioRecorder.js is not working with callbacks anymore, but with promises. See here.

Version 1.0.0 of AudioRecorder.js contains:

 

var beginAudioCapture = function beginAudioCapture() {



// Attempt to retrieve an audio input stream from the browser

navigator.mediaDevices.getUserMedia({ 'audio' : true }, function streamReceived(stream) {



// Create processing node which receives appropriately-sized audio buffers

processor = context.createScriptProcessor(BUFFER_SIZE, format.channels, format.channels);

processor.connect(context.destination);



// Send blobs when audio buffers are received

processor.onaudioprocess = function processAudio(e) {

writer.sendData(toSampleArray(e.inputBuffer).buffer);

};



// Connect processing node to user's audio input source

source = context.createMediaStreamSource(stream);

source.connect(processor);



// Save stream for later cleanup

mediaStream = stream;



}, function streamDenied() {



// Simply end stream if audio access is not allowed

writer.sendEnd();



// Notify of closure

if (recorder.onerror)

recorder.onerror();



});



};

 

 

A possible fix would be:

 

var beginAudioCapture = function beginAudioCapture() {
        // Attempt to retrieve an audio input stream from the browser
        navigator.mediaDevices.getUserMedia({ 'audio' : true })
            .then(stream => {
            // Create processing node which receives appropriately-sized audio buffers
            processor = context.createScriptProcessor(BUFFER_SIZE, format.channels, format.channels);
            processor.connect(context.destination);


            // Send blobs when audio buffers are received
            processor.onaudioprocess = function processAudio(e) {
                writer.sendData(toSampleArray(e.inputBuffer).buffer);
            };
           
            // Connect processing node to user's audio input source
            source = context.createMediaStreamSource(stream);
            source.connect(processor);


            // Save stream for later cleanup
            mediaStream = stream;


        }).catch(err => {
            // Simply end stream if audio access is not allowed
            writer.sendEnd();


            // Notify of closure
            if (recorder.onerror)
                recorder.onerror();


        });

 

Issue Links

• is duplicated by: GUACAMOLE-992 No sound input on Windows 10, microphone always silent
• is duplicated by: GUACAMOLE-995 RDP "Enable audio input (microphone)" does NOT work
• is duplicated by: GUACAMOLE-1003 I can't input the audio