Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-1259

Son of immediate double-free upon connecting to Windows RDP

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.3.0
    • 1.4.0
    • RDP
    • None

    Description

      From GUACAMOLE-1241:

      Regression testing against staging/1.3.0 using the Docker image, I am seeing an immediate disconnect due to a double-free when attempting to connect to Windows RDP:

      ...
      guacd[24698]: INFO:	Loading keymap "base"
      guacd[24698]: INFO:	Loading keymap "en-us-qwerty"
      guacd[24698]: INFO:	Connected to RDPDR 1.13 as client 0x0005
      free(): double free detected in tcache 2
      guacd[6]: INFO:	Connection "$e6955582-c6f2-4912-a4bd-a3ffee002cd1" removed.
      

      With there being a few memory-related RDP changes in the upcoming release (and with no such issues in 1.2.0), I suspect this is a regression.

      This is still happening when building against FreeRDP 2.0.0-rc4, not because things are incorrectly detected at build time, but because the config.h header containing the macro resulting from that detection is not included in the relevant file. The call to Stream_Free() therefore always occurs, even if FreeRDP was detected as doing this automatically.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mjumper Mike Jumper
            mjumper Mike Jumper
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment