[GUACAMOLE-1181] Memory allocated for outbound SVC PDUs may not be freed

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0, 1.2.0
• Fix Version/s: 1.3.0
• Component/s: RDP
• Assignee: Mike Jumper
• Reporter: Mike Jumper
• Created: 18/Sep/20 02:50
• Updated: 10/Jan/21 05:14
• Resolved: 30/Oct/20 02:39

Description

As reported on the mailing list, depending on the version of FreeRDP installed, the wStream allocated for transmission along a static virtual channel may not be freed:

https://lists.apache.org/thread.html/r39f830253413b2143438d09533c59e193e78729ef036bf1a1356f33b%40%3Cuser.guacamole.apache.org%3E

Possible solutions include:

• Explicitly freeing the wStream (if the version of FreeRDP present at build time will not do so)
• Leveraging the wStream pool that will be automatically freed (if the version of FreeRDP present at build time supports this)

Unfortunately, even after this is addressed, it may always be the case that a build of guacamole-server against FreeRDP 2.0.0 will suddenly start leaking memory if FreeRDP is updated and guacamole-server is not rebuilt, as the difference in behavior will only be detectable at build time.

Issue Links

• causes: GUACAMOLE-1241 Immediate double-free upon connecting to Windows RDP
• causes: GUACAMOLE-1259 Son of immediate double-free upon connecting to Windows RDP