[GROOVY-9455] STC: no error for if (!(x instanceof T)) x.methodFromT()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.19, 2.5.10, 3.0.2
• Fix Version/s: 4.0.0-alpha-1, 3.0.3, 2.5.16
• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 09/Mar/20 20:30
• Updated: 23/Jan/24 17:22
• Resolved: 14/Mar/20 06:39

Description

Variant of GROOVY-6429, GROOVY-8321, GROOVY-8412, GROOVY-8523 and GROOVY-8645.

Consider the following:

@groovy.transform.TypeChecked
void test(x) {
  if (!(x instanceof Number)) {
    x.byteValue() // accidentally had this and got no compiler error; STC has Number for typeof(x)
  } else {
    // ...
  }
}

Since the inferred type of "x" inside then block is Number, the IDE shows code assist for Number, which is misleading.

Issue Links

• relates to: GROOVY-11290 STC: multiple instanceof checks produce different results
• links to: GitHub Pull Request #1187