[GROOVY-11290] STC: multiple instanceof checks produce different results

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.18
• Fix Version/s: 3.0.21, 4.0.19, 5.0.0-alpha-6
• Component/s: Static Type Checker

Language

groovy

• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 18/Jan/24 21:58
• Updated: 05/Mar/24 01:53
• Resolved: 23/Jan/24 17:29

Description

Consider the following:

@groovy.transform.TypeChecked test1(CharSequence chars) {
  if (chars instanceof Cloneable && chars instanceof Closeable) {
      chars
  }
}
@groovy.transform.TypeChecked test2(CharSequence chars) {
  if (chars instanceof Cloneable) {
    if (chars instanceof Closeable) {
      chars
    }
  }
}

The last occurrence of "chars" in test1 has the inferred type "CharSequence & Cloneable & Closeable". However the last occurrence of "chars" in test2 has the inferred type "CharSequence & Closeable" instead of the expected result like test1.

Issue Links

• is related to: GROOVY-5226 Variables which type is determined thanks to instanceof checks should be usable as arguments without casts
• is related to: GROOVY-6429 flow typing detects unexpected error at if-else flow
• is related to: GROOVY-7333 Incorrect inferred type in instanceof check of array
• is related to: GROOVY-9455 STC: no error for if (!(x instanceof T)) x.methodFromT()
• is related to: GROOVY-9769 STC: UnionTypeClassNode created for simple instanceof scenarios