[GROOVY-9416] Avoid unnecessary looking up non default import classes when resolving types

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Assignee: Daniel Sun
• Reporter: Daniel Sun
• Created: 22/Feb/20 01:22
• Updated: 24/Feb/20 23:21
• Resolved: 23/Feb/20 04:58

Description

The fix for GROOVY-9408 has warmed up the cache of ResolveVisitor, thus the cache contains all classes from the default imported packages, so it is not necessary to look up non default imported classes against each defaut imported packages. For example,

In the following code, we do not need to look up java.lang.Foo, java.util.Foo, ..., groovy.util.Foo

Foo foo = new Foo() // Foo is not a default imported classes

Some test classes are defined under package groovy.lang and groovy.util, e.g. groovy.util.Person, groovy.lang.DummyGStringBase, they are not real Groovy core classes and should not be declared in the two packages, so the fake classes will not be imported be default.

Issue Links

• relates to: GROOVY-9408 Avoid unnecessary looking up default import classes when resolving types
• links to: GitHub Pull Request #1171