[GROOVY-9408] Avoid unnecessary looking up default import classes when resolving types

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1, 3.0.2
• Assignee: Daniel Sun
• Reporter: Daniel Sun
• Created: 19/Feb/20 01:20
• Updated: 22/Feb/20 01:23
• Resolved: 22/Feb/20 01:12

Description

ResolveVisitor will try to look up default imported classes from these packages "java.lang.", "java.util.", "java.io.", "java.net.", "groovy.lang.", "groovy.util.".

For example, when compiler finds Closure in the AST, it will try to look up "java.util.Closure", if failed, then "java.io.Clousre", ..., at last look up "groovy.lang.Closure".

As we can see, some of the above looking up is not necessary, we can avoid them by warming up org.codehaus.groovy.control.ResolveVisitor#DEFAULT_IMPORT_CLASS_AND_PACKAGES_CACHE

 

P.S. warming up the cache costs about 0.226s on my machine

 

Issue Links

• is related to: GROOVY-9416 Avoid unnecessary looking up non default import classes when resolving types
• links to: GitHub Pull Request #1169