[GROOVY-9407] ImportCustomizer skips importing in certain scenarios

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Information Provided
• Affects Version/s: 3.0.1
• External issue URL: https://github.com/spring-projects/spring-boot/issues/20119
• Assignee: Unassigned
• Reporter: Christoph Dreis
• Created: 18/Feb/20 21:29
• Updated: 15/Aug/22 15:59
• Resolved: 15/Aug/22 15:59

Description

Hi,

when upgrading Spring-Boot to Groovy 3.x (see https://github.com/spring-projects/spring-boot/issues/20119) I was noticing build failures around the importing behaviour.

I've managed to extract a minimum example where this breaks:

https://github.com/dreis2211/groovy3-import-bug

It seems that ImportCustomizer is skipping imports when multiple classes (or more specifically ClassNodes) are in the same file and the imports are configured per class/ClassNode. Please see the above example for more information.

This behaviour seems to have been introduced with GROOVY-8399 for performance reasons.

When switching the example to 2.5.9, it works again.