[GROOVY-8399] ImportCustomizer is applied once per class (should be once per module)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-rc-2
• Component/s: Compiler
• Labels: breaking
• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 02/Dec/17 21:24
• Updated: 21/Feb/20 02:17
• Resolved: 22/Nov/19 01:19

Description

CompilerConfiguration with ImportCustomizer gets applied once per class in a source unit. If unit has a lot of classes this can cause a lot of extra imports processing.CompilationUnit.applyToPrimaryClassNodes(PrimaryClassNodeOperation) is the loop that drives the CompilationCustomizers. org.codehaus.groovy.control.customizers.ImportCustomizer.call is where imports are added. Could check if ClassNode param is the primary class in the module before applying. Or ModuleNode could allow addImport and just dedup internally.

Issue Links

• links to: GitHub Pull Request #1097