[GROOVY-9158] @NamedParam arguments don't get their default value when only named parameters are used in the method call

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.7
• Fix Version/s: 2.5.16, 3.0.10, 4.0.0
• Labels: named-parameters
• Assignee: Eric Milles
• Reporter: Mathieu Grelier
• Created: 05/Jun/19 21:49
• Updated: 08/Mar/22 12:16
• Resolved: 16/Feb/22 17:03

Description

See the code below.

@NamedParam only method signatures with default values for not required ones should be possible, with corresponding named parameters only method calls.

import groovy.transform.NamedParam
import groovy.transform.NamedVariant
import static groovy.test.GroovyAssert.shouldFail
    
class NamedParamTestClass {

    Map getArgs(def arg1, def arg2) {
        Map passedArgs = [:]
        passedArgs << ["arg1":arg1, "arg2":arg2]
        passedArgs
    }
     
    @NamedVariant
    Map onlyNamedArgs(@NamedParam(required = true) String arg1, @NamedParam(required = false) String arg2 = "expected default value") {
        getArgs(arg1, arg2)
    }
    
    @NamedVariant
    Map primitiveTypeNotRequired(@NamedParam(required = false) String arg1, @NamedParam(required = false) int arg2 = 1) {
        getArgs(arg1, arg2)
    }
}

def test = new NamedParamTestClass()
Map result

result = test.onlyNamedArgs("a positional value for @NamedParam arg1")
assert result.getAt("arg2") == "expected default value"

result = test.onlyNamedArgs(arg1:"a named parameter value for @NamedParam arg1")
shouldFail(AssertionError) {
    assert result.getAt("arg2") == "expected default value" :  "arg2 was not given its default value"
}
assert result.getAt("arg2") == null

shouldFail(MissingMethodException) {
    result = test.primitiveTypeNotRequired(arg1:'1') // called with named arg
}

Last test shows also that MissingMethodException occurs when a primitive type is used with @NamedParam.

Issue Links

• is related to: GROOVY-10176 @NamedVariant with primitives can't find method