[GROOVY-10931] Remove $getLookup method generation (Groovy 4+)

• Type: Wish
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0-alpha-1
• Component/s: class generator, Compiler
• Labels: breaking invokedynamic jdk16 jdk17

Language

groovy

• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 12/Feb/23 15:49
• Updated: 23/Aug/23 09:11
• Resolved: 24/Jul/23 22:00

Description

The new $getLookup() method was discussed somewhat in the comments of GROOVY-10273. Groovy 3 has had JEP 396 (illegal access enforcement) support backported to the invoke dynamic pathways, without $getLookup. So, I'd like to restart the discussion to find out if there are any illegal-access scenarios that Groovy 4 supports that don't have a test case in Groovy 3. And if there are no scenarios that remain, I'd like to propose the removal of $getLookup method generation.

I have disabled its generation in the Groovy 5 codebase, and there are no tests that fail. So I have good confidence that it can be removed and the security hole can be plugged.

Issue Links

• is related to: GROOVY-10145 Support JDK16
• is related to: GROOVY-10290 Dynamic Groovy code in Gradle doesn't compile because of $getLookup() method is not static
• is related to: GROOVY-10319 Groovy3 CompileStatic bug: Method clone is protected in java.lang.Object
• is related to: GROOVY-10391 Default interface methods causing problems with java 17 and groovy 3.0.9
• is related to: GROOVY-10450 Cannot call BiPredicate methods on closures or lambdas on JRE 16+
• is related to: GROOVY-10709 Performance regression in Gradle with Groovy 4
• is related to: GROOVY-10273 New $getLookup() method is not marked as generated or internal
• is related to: GROOVY-9081 CLONE - Fix warning "An illegal reflective access operation has occurred"
• is related to: GROOVY-9103 CLONE - CLONE - Fix warning "An illegal reflective access operation has occurred"
• is related to: GROOVY-9144 Fix warning "An illegal reflective access operation has occurred"
• is related to: GROOVY-9217 Fix warning "An illegal reflective access operation has occurred" when setting property
• is related to: GROOVY-10438 DGM: getMetaPropertyValues and getProperties includes private entries