[GROOVY-10438] DGM: getMetaPropertyValues and getProperties includes private entries

• Type: Question
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0-alpha-1

Language

groovy

• Assignee: Unassigned
• Reporter: Eric Milles
• Created: 04/Jan/22 17:44
• Updated: 23/Aug/23 09:11
• Resolved: 25/Jul/23 22:53

Description

Consider the following:

class C {
  private getX() {}
  protected getY() {}
  @groovy.transform.PackageScope getZ() {}
}

C.metaClass.properties.each {
  println it.name + ': ' + org.codehaus.groovy.ast.AstToTextHelper.getModifiersText(it.modifiers)
}

The metaClass properties includes all visibilities. And the example could probably be extended to show static stuff as well.

class: public final native
z: <package-private>
y: protected
x: private

These properties are used (unfiltered) to generate the results for DefaultGroovyMethods getMetaPropertyValues and getProperties. GROOVY-5169 and GROOVY-7682 are partially caused by this.

Should the extension methods return private properties?

Issue Links

• is related to: GROOVY-996 protected fields not visible in subclasses
• relates to: GROOVY-7682 JsonBuilder or JsonOutput incompatible with JodaTime
• relates to: GROOVY-10550 DefaultGroovyMethods.getProperties includes constants
• relates to: GROOVY-10555 MetaClass.getProperites() returns package private fields
• relates to: GROOVY-5169 JsonOutput.toJson(object) is not returning expected results
• relates to: GROOVY-10931 Remove $getLookup method generation (Groovy 4+)