Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-3583

Remove all usages of static methods to the Cache

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      This ticket is the parent ticket to remove all invocations of CacheFactory.getAnyInstance(), GemFireCacheImpl.getInstance(), etc...
      This improvement is complete is there are no more usages of the static methods to retrieve a Cache

      As per some work that [~huynhja] has done
      _ grep -rl "GemFireCacheImpl.getInstance" --include *.java . > GemFireCacheImplList.txt

      grep -rl "CacheFactory.getAnyInstance" --include *.java . > CacheFactoryList.txt

      grep -rl "InternalDistributedSystem.getAnyInstance" --include *.java . > InternalDistributedSystemList.txt

      I've attached the files to this email...

      The combinedList.txt is a grep that combined all 3 calls into a single file... _

      [EDIT] Complete list of all singleton getters for which calls need to be removed:

      • CacheFactory.getAnyInstance()
      • CacheFactory.getInstance(DistributedSystem)
      • CacheFactory.getInstanceCloseOk(DistributedSystem)
      • GemFireCacheImpl.getExisting()
      • GemFireCacheImpl.getExisting(String)
      • GemFireCacheImpl.getForPdx(String)
      • GemFireCacheImpl.getInstance()
      • GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl)
      • InternalDistributedSystem.getAnyInstance()
      • InternalDistributedSystem getConnectedInstance()
      • InternalDistributedSystem unsafeGetConnectedInstance()

      Attachments

        1. CacheFactoryList.txt
          19 kB
          Udo Kohlmeyer
        2. CombinedList.txt
          46 kB
          Udo Kohlmeyer
        3. GemFireCacheImplList.txt
          19 kB
          Udo Kohlmeyer
        4. InternalDistributedSystemList.txt
          11 kB
          Udo Kohlmeyer
        1.
        Remove all instances of GemFireCacheImpl.getInstance from geode-cq Sub-task Open Unassigned   Actions
        2.
        Remove all singleton calls from JUnit4CacheTestCase Sub-task Open Unassigned   Actions
        3.
        JCALocalTransaction should not invoke CacheFactory.getAnyInstance Sub-task Open Unassigned   Actions
        4.
        JCAManagedConnection should not invoke CacheFactory.getAnyInstance Sub-task Open Unassigned   Actions
        5.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.execute Sub-task In Progress Avinash

        100%

        Original Estimate - Not Specified Original Estimate - Not Specified
        Time Spent - 1h 40m
        Actions
        6.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.tier.sockets Sub-task Open Unassigned   Actions
        7.
        Remove singleton calls from all tests in org.apache.geode.cache.query.dunit Sub-task Open Unassigned   Actions
        8.
        Remove singleton calls from all tests in org.apache.geode.internal.cache Sub-task Open Darrel Schneider

        100%

        Original Estimate - Not Specified Original Estimate - Not Specified
        Time Spent - 40m
        Actions
        9.
        Remove singleton calls from all tests in org.apache.geode.rest.internal.web.controllers Sub-task Open Unassigned   Actions
        10.
        Remove singleton calls from all tests in org.apache.geode.cache.asyncqueue Sub-task Open Unassigned   Actions
        11.
        Remove singleton calls from all tests in org.apache.geode.pdx Sub-task Open Avinash

        100%

        Original Estimate - Not Specified Original Estimate - Not Specified
        Time Spent - 1h
        Actions
        12.
        Remove singleton calls from all tests in org.apache.geode.management.internal.cli.commands Sub-task Open Unassigned   Actions
        13.
        Remove singleton calls from all tests in org.apache.geode.security Sub-task Open Unassigned   Actions
        14.
        Remove singleton calls from all tests in org.apache.geode.cache.query.internal.index Sub-task Open Unassigned   Actions
        15.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.extension.mock Sub-task Open Unassigned   Actions
        16.
        Remove singleton calls from all tests in org.apache.geode.cache.client Sub-task Open Unassigned   Actions
        17.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.snapshot Sub-task Open Unassigned   Actions
        18.
        Remove singleton calls from all tests in org.apache.geode.internal.jta Sub-task Open Unassigned   Actions
        19.
        Remove singleton calls from all tests in org.apache.geode.distributed Sub-task Open Unassigned   Actions
        20.
        Remove singleton calls from all tests in org.apache.geode.management Sub-task Open Unassigned   Actions
        21.
        Remove singleton calls from all tests in org.apache.geode.security.query Sub-task Open Unassigned   Actions
        22.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.partitioned Sub-task Open Unassigned   Actions
        23.
        Remove singleton calls from all tests in org.apache.geode.cache.client.internal Sub-task Open Unassigned   Actions
        24.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.backup Sub-task Open Unassigned   Actions
        25.
        Remove singleton calls from all tests in org.apache.geode.cache.query Sub-task Open Unassigned

        100%

        Original Estimate - Not Specified Original Estimate - Not Specified
        Time Spent - 20m
        Actions
        26.
        Remove singleton calls from all tests in org.apache.geode.internal Sub-task Open Unassigned   Actions
        27.
        Remove singleton calls from all tests in org.apache.geode.management.internal.configuration Sub-task Open Unassigned   Actions
        28.
        Remove singleton calls from all tests in org.apache.geode.test.dunit.rules.tests Sub-task Open Unassigned   Actions
        29.
        Remove singleton calls from membership tests in org.apache.geode Sub-task Open Unassigned   Actions
        30.
        Remove singleton calls from all tests in org.apache.geode.management.internal.cli.functions Sub-task Open Unassigned   Actions
        31.
        Remove singleton calls from all tests in org.apache.geode.memcached Sub-task Open Unassigned   Actions
        32.
        Remove singleton calls from all tests in org.apache.geode.test.dunit.internal Sub-task Open Unassigned   Actions
        33.
        Remove singleton calls from all tests in org.apache.geode.cache.query.functional Sub-task Open Unassigned   Actions
        34.
        Remove singleton calls from all tests in org.apache.geode.management.bean.stats Sub-task Open Kirk Lund   Actions
        35.
        Remove singleton calls from all tests in org.apache.geode.management.internal.unsafe Sub-task Open Kirk Lund   Actions
        36.
        Remove singleton calls from all tests in org.apache.geode.test.junit.rules Sub-task Open Unassigned   Actions
        37.
        Remove singleton calls from all tests in org.apache.geode.management.internal.pulse Sub-task Open Unassigned   Actions
        38.
        Remove singleton calls from all tests in org.apache.geode.modules.session Sub-task Open Unassigned   Actions
        39.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.wan Sub-task Open Unassigned   Actions
        40.
        Remove singleton calls from all tests in org.apache.geode.management.internal.beans Sub-task Open Kirk Lund   Actions
        41.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.wan.parallel Sub-task Open Unassigned   Actions
        42.
        Remove singleton calls from all tests in org.apache.geode.disttx Sub-task Open Unassigned   Actions
        43.
        Remove singleton calls from all tests in org.apache.geode.distributed.internal.membership.gms.membership Sub-task Open Unassigned   Actions
        44.
        Remove singleton calls from all tests in org.apache.geode.internal.jta.dunit Sub-task Open Unassigned   Actions
        45.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.functions Sub-task Open Unassigned   Actions
        46.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.locks Sub-task Open Unassigned   Actions
        47.
        Remove singleton calls from all tests in org.apache.geode.test.dunit Sub-task Open Unassigned   Actions
        48.
        Remove singleton calls from all tests in org.apache.geode.internal.cache.wan.serial Sub-task Open Unassigned   Actions
        49.
        Remove singleton calls from launcher tests in org.apache.geode.distributed Sub-task Open Unassigned   Actions
        50.
        Remove singleton calls from all tests in org.apache.geode.test.dunit.rules Sub-task Open Unassigned   Actions
        51.
        Remove singleton calls from transaction tests in org.apache.geode Sub-task Open Unassigned   Actions
        52.
        Remove singleton calls from delta test classes in org.apache.geode Sub-task Open Unassigned   Actions
        53.
        Remove singleton calls from product code in org.apache.geode.internal.memcached.commands Sub-task Open Unassigned   Actions
        54.
        Remove singleton calls from product code in org.apache.geode.management.internal.beans Sub-task Open Unassigned   Actions
        55.
        Remove singleton calls from product code in org.apache.geode.modules.util Sub-task Open Unassigned   Actions
        56.
        Remove singleton calls from product code in org.apache.geode.management.internal.cli.modes Sub-task Open Unassigned   Actions
        57.
        Remove singleton calls from serialization product code in org.apache.geode Sub-task Open Unassigned   Actions
        58.
        Remove singleton calls from product code in org.apache.geode.modules.session.catalina Sub-task Open Unassigned   Actions
        59.
        Remove singleton calls from core product code in org.apache.geode.internal Sub-task Open Unassigned   Actions
        60.
        Remove singleton calls from product code in org.apache.geode.modules.gatewaydelta Sub-task Open Unassigned   Actions
        61.
        Remove singleton calls from product code in org.apache.geode.internal.cache.wan Sub-task Open Avinash   Actions
        62.
        Remove singleton calls from product code in org.apache.geode.modules.session.internal.filter Sub-task Open Unassigned   Actions
        63.
        Remove singleton calls from product code in org.apache.geode.internal.cache.tier Sub-task Open Avinash

        100%

        Original Estimate - Not Specified Original Estimate - Not Specified
        Time Spent - 20m
        Actions
        64.
        Remove singleton calls from product code in org.apache.geode.internal.ra.spi Sub-task Open Unassigned   Actions
        65.
        Remove singleton calls from product code in org.apache.geode.management.internal Sub-task Open Unassigned   Actions
        66.
        Remove singleton calls from product code in org.apache.geode.admin.internal Sub-task Open Unassigned   Actions
        67.
        Remove singleton calls from product code in org.apache.geode.pdx.internal.json Sub-task Open Unassigned   Actions
        68.
        Remove singleton calls from product code in org.apache.geode.modules.session.bootstrap Sub-task Open Unassigned   Actions
        69.
        Remove singleton calls from client/server product code in org.apache.geode.cache.client.internal Sub-task Open Unassigned   Actions
        70.
        Remove singleton calls from product code in org.apache.geode.cache.snapshot Sub-task Open Unassigned   Actions
        71.
        Remove singleton calls from product code in org.apache.geode.management.internal.configuration.domain Sub-task Open Unassigned   Actions
        72.
        Remove singleton calls from product code in org.apache.geode.internal.admin.remote Sub-task Open Unassigned   Actions
        73.
        Remove singleton calls from product code in org.apache.geode.rest.internal.web.controllers.support Sub-task Open Unassigned   Actions
        74.
        Remove singleton calls from product code in org.apache.geode.pdx.internal Sub-task Open Unassigned   Actions
        75.
        Remove singleton calls from product code in org.apache.geode.internal.cache.tier.sockets.command Sub-task Open Unassigned   Actions
        76.
        Remove singleton calls from serialization product code in org.apache.geode.internal Sub-task Open Unassigned   Actions
        77.
        Remove singleton calls from product code in org.apache.geode.management.internal.web.controllers Sub-task Open Unassigned   Actions
        78.
        Remove singleton calls from product code in org.apache.geode.internal.cache.tier.sockets Sub-task Open Unassigned   Actions
        79.
        Remove singleton calls from product code in org.apache.geode.cache Sub-task Open Unassigned   Actions
        80.
        Remove singleton calls from transaction product code in org.apache.geode.internal.cache Sub-task Open Unassigned   Actions
        81.
        Remove singleton calls from client-queues product code in org.apache.geode.internal.cache Sub-task Open Unassigned   Actions
        82.
        Remove singleton calls from functions product code in org.apache.geode.internal.cache Sub-task Open Unassigned   Actions
        83.
        Remove singleton calls from querying product code in org.apache.geode.internal.cache Sub-task Open Unassigned   Actions
        84.
        Remove singleton calls from client/server product code in org.apache.geode.internal.cache Sub-task Open Unassigned   Actions
        85.
        Remove singleton calls from product code in org.apache.geode.distributed.internal Sub-task Open Unassigned   Actions
        86.
        Remove singleton calls from product code in org.apache.geode.cache.client Sub-task Open Unassigned   Actions
        87.
        Remove singleton calls from product code in org.apache.geode.internal.admin Sub-task Open Unassigned   Actions
        88.
        Remove singleton calls from product code in org.apache.geode.management.internal.messages Sub-task Open Unassigned   Actions
        89.
        Remove singleton calls from product code in org.apache.geode.memcached Sub-task Open Unassigned   Actions
        90.
        Remove singleton calls from product code in org.apache.geode.rest.internal.web.security Sub-task Open Unassigned   Actions
        91.
        Remove singleton calls from product code in org.apache.geode.management.internal.configuration.functions Sub-task Open Unassigned   Actions
        92.
        Remove singleton calls from product code in org.apache.geode.cache.query.internal.index Sub-task Open Unassigned   Actions
        93.
        Remove singleton calls from product code in org.apache.geode.internal.cache.execute Sub-task Open Unassigned   Actions
        94.
        Remove singleton calls from client-queues product code in org.apache.geode.cache.client.internal Sub-task Open Unassigned   Actions
        95.
        Remove singleton calls from product code in org.apache.geode.cache.query.internal Sub-task Open Unassigned   Actions
        96.
        Remove singleton calls from launcher product code in org.apache.geode.distributed Sub-task Open Unassigned   Actions
        97.
        Remove singleton calls from product code in org.apache.geode.distributed.internal.deadlock Sub-task Open Unassigned   Actions
        98.
        Remove singleton calls from product code in org.apache.geode.internal.tcp Sub-task Open Unassigned   Actions
        99.
        Remove singleton calls from product code in org.apache.geode.internal.sequencelog Sub-task Open Unassigned   Actions
        100.
        Remove singleton calls from product code in org.apache.geode.internal.jta Sub-task Open Unassigned   Actions
        101.
        Remove singleton calls from product code in org.apache.geode.internal.protocol.protobuf.statistics Sub-task Open Unassigned   Actions
        102.
        Remove singleton calls from product code in org.apache.geode.internal.net Sub-task Open Unassigned   Actions
        103.
        Remove singleton calls from launcher product code in org.apache.geode.cache.client.internal Sub-task Open Unassigned   Actions
        104.
        Remove singleton calls from product code in org.apache.geode.cache.execute Sub-task Open Unassigned   Actions
        105.
        RemotePRValuesAreNotDeserializedRegressionTest calls InternalDistributedSystem.getAnyInstance Sub-task Open Unassigned   Actions

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            ukohlmeyer Udo Kohlmeyer

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20h 40m
                20h 40m

                Slack

                  Issue deployment