[GEODE-4456] Remove singleton calls from all tests in org.apache.geode.internal.cache

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: regions, tests, transactions
• Labels: pull-request-available
• Assignee: Darrel Schneider
• Reporter: Kirk Lund
• Created: 01/Feb/18 18:37
• Updated: 06/Apr/18 01:08

Description

These tests in org.apache.geode.internal.cache invoke singleton getters.

CacheFactory.getAnyInstance():

• Bug37241DUnitTest
• CommitFunction
• GridAdvisorDUnitTest
• NestedTransactionFunction
• RollbackFunction
• SingleHopStatsDUnitTest
• UpdateVersionDUnitTest

CacheFactory.getExisting(DistributedSystem):

• PartitionedRegionTestHelper

GemFireCacheImpl.getInstance():

• DiskRegRecoveryJUnitTest
• FixedPRSinglehopDUnitTest
• NetSearchMessagingDUnitTest
• RemoteCQTransactionDUnitTest
• RemoteTransactionDUnitTest
• SystemFailureDUnitTest

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):

• ColocationHelperTest

InternalDistributedSystem.getAnyInstance():

• ClientServerTransactionDUnitTest
• GridAdvisorDUnitTest

InternalDistributedSystem.getConnectedInstance():

• ClientServerTransactionDUnitTest
• TombstoneCreationJUnitTest

Issue Links

• links to: GitHub Pull Request #1496