[GEODE-3077] Client connection counts should be accurate

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Component/s: client/server
• Assignee: Unassigned
• Reporter: Galen O'Sullivan
• Created: 14/Jun/17 22:59
• Updated: 20/Apr/18 19:56
• Resolved: 01/Sep/17 21:40

Description

As a dev user of Geode, I want to be able to look at connection counts and know they are reliable (no matter if I'm using the new client/server protocol or the old). Revisit connection-counting-related methods and ensure the counting mechanism is accurate.

Specifically:
Have a look at where and how the following three functions are used:

  public void incClientServerCnxCount() {
    this.clientServerCnxCount.incrementAndGet();
  }

  public void decClientServerCnxCount() {
    this.clientServerCnxCount.decrementAndGet();
  }

  public int getClientServerCnxCount() {
    return this.clientServerCnxCount.get();
  }

These are tracking client-server connections. Extract these into common code in ServerConnection that both NewClientServerConnection and LegacyServerConnection can use, and make sure that counts are correct in both creation and cleanup situations. Write some tests to verify.

Note: client counts look to be tracked separately from connection counts; the old protocol can have multiple connections per client. We're interested with the connection count in this ticket.

Issue Links

• duplicates: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed
• relates to: GEODE-3076 Simplify connection count logic in AcceptorImpl