[GEODE-3074] Integrate new client protocol into existing connection logic

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: client/server
• Assignee: Unassigned
• Reporter: Galen O'Sullivan
• Created: 14/Jun/17 22:30
• Updated: 01/Feb/18 22:52
• Resolved: 15/Nov/17 21:30

Description

We want to make a new client server protocol that will make it much easier for new Geode clients to be implemented in other languages.

To do this, we need a refactor of AcceptorImpl and ServerConnection to allow the server to create new client protocol handler objects and run them within the existing network / threading infrastructure.

As a first task, we can make a factory that creates instances of the new subclasses of ServerConnection : NewClientServerConnection and LegacyServerConnection. Then we can slowly refactor functionality from ServerConnection into that which is common (such as handling shutdown, stats, and interacting properly with selector or thread pool) and that which is specific to the old client protocol.

This ticket will track the many subtasks of this effort.

TODO before the whole ticket is resolved:

• Have a look through the {{Command}}s and see what they do.

• Move transient flag methods and such down to LegacyServerConnection.

• Make sure we handle failure consistently.
• Make sure Event IDs and such are OK in the Cache.

• I think that using the public Region API will make this OK.

• Comm Buffers: can we use them? If so, use them; if not, pull down to LegacyServerConnection.
• Socket receive and send sizes – see `initStreams()` in `ServerConnection`.

Other things to think about:

• Make selector work with SSL.
• think about redesigning selector in case of an incomplete message being received (buffer message – I think there's currently a bug here).

Issue Links

• is duplicated by: GEODE-2978 Add feature toggle for new protocol & merge into develop
• relates to: GEODE-3200 ServerConnection.authzRequest is no longer used

Sub-Tasks

• Bifurcate ServerConnection, create factory and feature toggle: Closed
• Refactor methods from ClientHandShake to ServerConnection.: Closed
• Client connection counts should be accurate: Closed
• Protocol connection runs in AcceptorImpl's thread pool: Closed
• Ensure new protocol shuts down cleanly: Closed
• Protocol connection runs in selector thread: Closed
• Interact correctly with CachedRegionHelper in NewClientServerConnection: Closed
• Client Health Monitor should be able to manage new protocol client connections: Closed
• New protocol should record server statistics: Closed
• Investigate unique client IDs in server connection class: Closed
• Investigate replacement of getSocketHost(), getSocketPort(), getSocketAddress(): Closed
• NewClientServerConnection and loadEmergencyClasses(): Closed