[GEODE-2863] DiskStoreImpl close does not shutdown its thread pools

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0-incubating
• Fix Version/s: 1.10.0
• Component/s: persistence
• Labels: needs-review pull-request-available storage_3
• Assignee: Mario Ivanac
• Reporter: Darrel Schneider
• Created: 02/May/17 18:53
• Updated: 26/Sep/19 18:02
• Resolved: 26/Jun/19 18:35

Description

Closing a DiskStoreImpl does not shutdown its thread pools.
It has two pools, "diskStoreTaskPool" and "delayedWritePool", that it does not shutdown.
However at least in some cases (see GEODE-2862) it does wait for all the tasks submitted to these pools to complete. But it is not clear if additional tasks could still be submitted after this wait is done.
Some logic should be added that causes the code that would submit a task to these executors to no longer do so or, if needed, to process the task inline.

Issue Links

• links to: GitHub Pull Request #3624