[GEODE-2862] shutdown hook does not wait for disk store async tasks to complete

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.0.0-incubating
• Component/s: persistence
• Labels: storage_3
• Assignee: Unassigned
• Reporter: Darrel Schneider
• Created: 02/May/17 18:46
• Updated: 08/May/17 17:28

Description

If you do a normal cache close and are using persistence then each disk store close will wait for all of its async background tasks to complete.
But if instead the JVM shutdown hook is used (see java.lang.Runtime.addShutdownHook(Thread) for a description of what causes the shutdown hook to be called) then it will not wait for the async persistent tasks to complete.

Both of these types of shutdown are considered an orderly shutdown (as opposed to a unorderly shutdown caused by things like a kill -9) and geode should only have one type of orderly shutdown. By not waiting for the async persistent tasks to complete some files may never be fully written.

Here is the code that causes the shutdown hook to not wait in DiskStoreImpl:

      // don't block the shutdown hook
      if (Thread.currentThread() != InternalDistributedSystem.shutdownHook) {
        waitForBackgroundTasks();
      }