Details

    • Type: Epic Epic
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v0.9.4
    • Component/s: Build
    • Labels:
      None

      Description

      This is a place holder issue for the maven-ization of Flume's build system.

        Issue Links

          Issues in Epic

          There are no issues in this epic.

            Activity

            Transition Time In Source Status Execution Times Last Executer Last Execution Date
            Open Open Resolved Resolved
            176d 3h 43m 1 E. Sammer 21/Apr/11 05:35
            Resolved Resolved Closed Closed
            106d 19h 38m 1 Jonathan Hsieh 06/Aug/11 01:14
            Jonathan Hsieh made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            Mark Thomas made changes -
            Project Import Tue Aug 02 16:57:12 UTC 2011 [ 1312304232406 ]
            Jonathan Hsieh made changes -
            Link This issue blocks FLUME-630 [ FLUME-630 ]
            Jonathan Hsieh made changes -
            Link This issue depends on FLUME-630 [ FLUME-630 ]
            Jonathan Hsieh made changes -
            Link This issue depends on FLUME-630 [ FLUME-630 ]
            Jonathan Hsieh made changes -
            Link This issue blocks FLUME-614 [ FLUME-614 ]
            E. Sammer made changes -
            Link This issue relates to FLUME-612 [ FLUME-612 ]
            Hide
            Jonathan Hsieh added a comment - - edited

            There are a handful of patch series that developed under the ant build and have been reviewed in various states. I've created a new branch called 'ant' where these issues can be committed. After they have been tested commited on the ant branch if the port to the maven branch is non-trivial, we should file a separate jira to port them onto the maven based master branch.

            ex: rebase just works == trivial
            ex: rename a file == trivial
            ex: code modification that requires more than 5 minutes of though. => new jira new review.
            ex: build modification to use maven to grab file instead of committing or using ivy => new jira, new review.

            Show
            Jonathan Hsieh added a comment - - edited There are a handful of patch series that developed under the ant build and have been reviewed in various states. I've created a new branch called 'ant' where these issues can be committed. After they have been tested commited on the ant branch if the port to the maven branch is non-trivial, we should file a separate jira to port them onto the maven based master branch. ex: rebase just works == trivial ex: rename a file == trivial ex: code modification that requires more than 5 minutes of though. => new jira new review. ex: build modification to use maven to grab file instead of committing or using ivy => new jira, new review.
            Jonathan Hsieh made changes -
            Link This issue blocks FLUME-609 [ FLUME-609 ]
            Jonathan Hsieh made changes -
            Link This issue blocks FLUME-608 [ FLUME-608 ]
            Hide
            Jonathan Hsieh added a comment -

            There are a handful of functionality that remain broken by FLUME-296. Please add a link a dependency/blocks to here. Also, please mark these at the blocker priority since these need to resolved before a 0.9.4 release.

            Show
            Jonathan Hsieh added a comment - There are a handful of functionality that remain broken by FLUME-296 . Please add a link a dependency/blocks to here. Also, please mark these at the blocker priority since these need to resolved before a 0.9.4 release.
            Jonathan Hsieh made changes -
            Link This issue blocks FLUME-607 [ FLUME-607 ]
            E. Sammer made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            Hide
            E. Sammer added a comment -

            It has been done! This is now pushed back to master.

            Thanks to everyone who helped review / bug stomp.

            Show
            E. Sammer added a comment - It has been done! This is now pushed back to master. Thanks to everyone who helped review / bug stomp.
            Jonathan Hsieh made changes -
            Issue Type Improvement [ 4 ] Epic [ 6 ]
            Hide
            E. Sammer added a comment -

            Jon and I decided to list remaining nits / issues as subtasks here given the scope of this JIRA.

            Show
            E. Sammer added a comment - Jon and I decided to list remaining nits / issues as subtasks here given the scope of this JIRA.
            Jonathan Hsieh made changes -
            Fix Version/s v0.9.3 [ 10040 ]
            Fix Version/s v0.9.4 [ 10050 ]
            Jonathan Hsieh made changes -
            Priority Blocker [ 1 ] Critical [ 2 ]
            Hide
            Jonathan Hsieh added a comment -

            not blocker for 0.9.3

            Show
            Jonathan Hsieh added a comment - not blocker for 0.9.3
            Jonathan Hsieh made changes -
            Priority Major [ 3 ] Blocker [ 1 ]
            Hide
            Jonathan Hsieh added a comment -

            Add -DskipTests to mvn command line. In first cut some tests hang.

            Show
            Jonathan Hsieh added a comment - Add -DskipTests to mvn command line. In first cut some tests hang.
            Hide
            Jonathan Hsieh added a comment -

            workaround:

            Override thrift executable to use the thrift installed locally in my machine's path:

            mvn clean install -Dthrift.executable=`which thrift`

            Show
            Jonathan Hsieh added a comment - workaround: Override thrift executable to use the thrift installed locally in my machine's path: mvn clean install -Dthrift.executable=`which thrift`
            Hide
            Jonathan Hsieh added a comment -

            Thrift execution failed on my local machine looking for /usr/local/thrift-0.4.0/bin/thrift. looking for a work around.

            Show
            Jonathan Hsieh added a comment - Thrift execution failed on my local machine looking for /usr/local/thrift-0.4.0/bin/thrift. looking for a work around.
            Hide
            E. Sammer added a comment -

            Correct - as of now, my GH branch matches the review. The vast majority of the changes are because git is dumb about renames (i.e. treats them as remove + add) and all java source when from src/java/* to src/

            {main,test}

            /java/*. I also did a 'git diff -M --stat flume-296..master' which makes it look far less scary.

            Show
            E. Sammer added a comment - Correct - as of now, my GH branch matches the review. The vast majority of the changes are because git is dumb about renames (i.e. treats them as remove + add) and all java source when from src/java/* to src/ {main,test} /java/*. I also did a 'git diff -M --stat flume-296..master' which makes it look far less scary.
            Hide
            Jonathan Hsieh added a comment -

            Yikes, its a 55 page review board review.

            I'm assuming this link is up to date with the latest https://github.com/esammer/flume/tree/flume-296 (git hash 4e658f9501ba97d32f19)

            Show
            Jonathan Hsieh added a comment - Yikes, its a 55 page review board review. I'm assuming this link is up to date with the latest https://github.com/esammer/flume/tree/flume-296 (git hash 4e658f9501ba97d32f19)
            Hide
            E. Sammer added a comment -
            Show
            E. Sammer added a comment - Up for review at https://review.cloudera.org/r/1444/
            Jonathan Hsieh made changes -
            Fix Version/s v0.9.3 [ 10040 ]
            Jonathan Hsieh made changes -
            Field Original Value New Value
            Link This issue blocks FLUME-332 [ FLUME-332 ]
            E. Sammer created issue -

              People

              • Assignee:
                E. Sammer
                Reporter:
                E. Sammer
              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development