Flume
  1. Flume
  2. FLUME-1796

Upgrade Thrift due to race condition in TThreadSeverPool

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: v1.3.0
    • Fix Version/s: None
    • Component/s: Test
    • Labels:
      None
    • Environment:

      RHEL 5.x based systems, some SUSE versions

      Description

      While running the Flume unit tests, I observed that under some Linux environments (RHEL 5.x based etc), the Flume thrift source tests were timing out. This is because of a race condition in TThreadPoolServer used by Flume and speicifically in the testlifecycle. I have created a JIRA issue on Thrift regarding this[1]. I have creaed this issue, just so that we cross reference it here.

      [1] THRIFT-1795 - Race condition in TThreadedServerPool java implementation,

      1. FLUME-1796.patch
        6 kB
        Venkat Ranganathan

        Issue Links

          Activity

          Hide
          Venkat Ranganathan added a comment - - edited

          Now that thrift 0.9.1 has been release, I have updated the dependencies and also fixed a few lines of code where access was overridden (made methods public instead of protected) and provided a default implementation of isOneWay() to return false.

          Also undid the workaround introduced earlier

          Built and ran tests with these changes

          Show
          Venkat Ranganathan added a comment - - edited Now that thrift 0.9.1 has been release, I have updated the dependencies and also fixed a few lines of code where access was overridden (made methods public instead of protected) and provided a default implementation of isOneWay() to return false. Also undid the workaround introduced earlier Built and ran tests with these changes
          Hide
          Hari Shreedharan added a comment -

          We should make sure we use comparable thrift versions as our dependencies. HBase has a dependency on thrift. At this point, we can bump our version minimum for hbase to 0.94.x

          Show
          Hari Shreedharan added a comment - We should make sure we use comparable thrift versions as our dependencies. HBase has a dependency on thrift. At this point, we can bump our version minimum for hbase to 0.94.x

            People

            • Assignee:
              Venkat Ranganathan
              Reporter:
              Venkat Ranganathan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development